Skip to contentSkip to conversation

ring-buffer: Fix typo in comment

PATCH In review Vasyl Gomonovych 2 participants 3 messages May 18, 2018 – May 23, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ring-buffer: Fix typo in comment

Fix typo in the words 'reserved', 'been'

---
 include/linux/ring_buffer.h | 2 +-
 kernel/trace/ring_buffer.c  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
include/linux/ring_buffer.h +1 -1
index 7d9eb39fa76a..aa500da87f2a 100644
@@ -63,7 +63,7 @@ void *ring_buffer_event_data(struct ring_buffer_event *event);
 
 /*
  * ring_buffer_discard_commit will remove an event that has not
- *   ben committed yet. If this is used, then ring_buffer_unlock_commit
+ *   been committed yet. If this is used, then ring_buffer_unlock_commit
  *   must not be called on the discarded event. This function
  *   will try to remove the event from the ring buffer completely
  *   if another event has not been written after it.
kernel/trace/ring_buffer.c +1 -1
index dcf1c4dd3efe..a8a8eb23c489 100644
@@ -2776,7 +2776,7 @@ rb_reserve_next_event(struct ring_buffer *buffer,
  * @buffer: the ring buffer to reserve from
  * @length: the length of the data to reserve (excluding event header)
  *
- * Returns a reseverd event on the ring buffer to copy directly to.
+ * Returns a reserved event on the ring buffer to copy directly to.
  * The user of this interface will need to get the body to write into
  * and can use the ring_buffer_event_data() interface.
  *
Signature · 1 line
2.14.1
maintainer
#1 lore raw
Quoted 1 line · On Fri, 18 May 2018 22:31:28 +0200 Vasyl Gomonovych <[email protected]>…

Fix typo in the words 'reserved', 'been'

Thanks, but someone sent me a bunch of spelling fixes for that file which included these. I'll be pushing that to linux-next soon.

-- Steve

Quoted 33 lines
---
 include/linux/ring_buffer.h | 2 +-
 kernel/trace/ring_buffer.c  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
include/linux/ring_buffer.h +1 -1
index 7d9eb39fa76a..aa500da87f2a 100644
@@ -63,7 +63,7 @@ void *ring_buffer_event_data(struct ring_buffer_event *event);
 
 /*
  * ring_buffer_discard_commit will remove an event that has not
- *   ben committed yet. If this is used, then ring_buffer_unlock_commit
+ *   been committed yet. If this is used, then ring_buffer_unlock_commit
  *   must not be called on the discarded event. This function
  *   will try to remove the event from the ring buffer completely
  *   if another event has not been written after it.
kernel/trace/ring_buffer.c +1 -1
index dcf1c4dd3efe..a8a8eb23c489 100644
@@ -2776,7 +2776,7 @@ rb_reserve_next_event(struct ring_buffer *buffer,
  * @buffer: the ring buffer to reserve from
  * @length: the length of the data to reserve (excluding event header)
  *
- * Returns a reseverd event on the ring buffer to copy directly to.
+ * Returns a reserved event on the ring buffer to copy directly to.
  * The user of this interface will need to get the body to write into
  * and can use the ring_buffer_event_data() interface.
  *
maintainer
#2 lore raw
Quoted 7 lines · On Tue, 22 May 2018 20:55:57 -0400 Steven Rostedt <[email protected]> wrote:
Quoted 1 line · On Fri, 18 May 2018 22:31:28 +0200 Vasyl Gomonovych <[email protected]>…

Fix typo in the words 'reserved', 'been'

Thanks, but someone sent me a bunch of spelling fixes for that file which included these. I'll be pushing that to linux-next soon.

I stand corrected. ring_buffer.c was fixed, but the "been" typo in ring_buffer.h was not. I'll add that part of this patch.

-- Steve

Quoted 35 lines
Quoted 34 lines
---
 include/linux/ring_buffer.h | 2 +-
 kernel/trace/ring_buffer.c  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
include/linux/ring_buffer.h +1 -1
index 7d9eb39fa76a..aa500da87f2a 100644
@@ -63,7 +63,7 @@ void *ring_buffer_event_data(struct ring_buffer_event *event);
 
 /*
  * ring_buffer_discard_commit will remove an event that has not
- *   ben committed yet. If this is used, then ring_buffer_unlock_commit
+ *   been committed yet. If this is used, then ring_buffer_unlock_commit
  *   must not be called on the discarded event. This function
  *   will try to remove the event from the ring buffer completely
  *   if another event has not been written after it.
kernel/trace/ring_buffer.c +1 -1
index dcf1c4dd3efe..a8a8eb23c489 100644
@@ -2776,7 +2776,7 @@ rb_reserve_next_event(struct ring_buffer *buffer,
  * @buffer: the ring buffer to reserve from
  * @length: the length of the data to reserve (excluding event header)
  *
- * Returns a reseverd event on the ring buffer to copy directly to.
+ * Returns a reserved event on the ring buffer to copy directly to.
  * The user of this interface will need to get the body to write into
  * and can use the ring_buffer_event_data() interface.
  *