xfs/132: unmount scratch fs after test
PATCH 1/1 xfs/132: unmount scratch fs after test
From: Darrick J. Wong <[email protected]>
If this test runs successfully, it'll leave a shutdown scratch fs behind. The test framework doesn't unmount the fs for us (because we told it not to check the fs) so the test framework tries to "test -d $SCRATCH_MNT" and blows up on the IO error it receives from the dead fs.
--- tests/xfs/132 | 1 + 1 file changed, 1 insertion(+)
tests/xfs/132 +1 -0
@@ -67,6 +67,7 @@ _scratch_mount # The corrupt inode should be tripped over during these initial file creates. touch $SCRATCH_MNT/file{0,1,2,3,4,5}{0,1,2,3,4,5} 2>&1 | _filter_scratch +_scratch_unmount # success, all done status=0
Quoted 17 lines · Darrick J. Wong
From: Darrick J. Wong <[email protected]>
If this test runs successfully, it'll leave a shutdown scratch fs behind. The test framework doesn't unmount the fs for us (because we told it not to check the fs) so the test framework tries to "test -d $SCRATCH_MNT" and blows up on the IO error it receives from the dead fs.
Signed-off-by Darrick J. Wong <[email protected]>--- tests/xfs/132 | 1 + 1 file changed, 1 insertion(+)tests/xfs/132 +0
-0
tests/xfs/132 _scratch_mount · line 70
Quoted 4 lines
tests/xfs/132 +1
-0@@ -67,6 +67,7 @@ _scratch_mount # The corrupt inode should be tripped over during these initial file creates. touch $SCRATCH_MNT/file{0,1,2,3,4,5}{0,1,2,3,4,5} 2>&1 | _filter_scratch +_scratch_unmount
I've already NAK'd that patch - the test harness should be unmounting scratch in all situations and returning the test harness to a known initial state before the next test runs...
Cheers,
Dave.
Signature · 2 lines
Dave Chinner [email protected]