char: agp: Change return type to vm_fault_t
PATCH v2 1/1 char: agp: Change return type to vm_fault_t
Use new return type vm_fault_t for fault handler. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type.
Ref-> commit 1c8f422059ae ("mm: change return type to vm_fault_t") was added in 4.17-rc1 to introduce the new typedef vm_fault_t. Currently we are making change to all drivers to return vm_fault_t for page fault handlers. As part of that char/agp driver is also getting changed to return vm_fault_t type from fault handler.
--- drivers/char/agp/alpha-agp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/agp/alpha-agp.c +1 -1
@@ -11,7 +11,7 @@#include "agp.h" -static int alpha_core_agp_vm_fault (struct vm_fault *vmf) +static vm_fault_t alpha_core_agp_vm_fault (struct vm_fault *vmf) {alpha_agp_info *agp = agp_bridge->dev_private_data;dma_addr_t dma_addr;
Signature · 1 line
1.9.1
Quoted 32 lines · Souptick Joarder
Use new return type
vm_fault_tfor fault handler. For now, this is just documenting that the function returns aVM_FAULTvalue rather than an errno. Once all instances are converted,vm_fault_twill become a distinct type.Ref-> commit
1c8f422059ae("mm: change return type tovm_fault_t") was added in 4.17-rc1 to introduce the new typedefvm_fault_t. Currently we are making change to all drivers to returnvm_fault_tfor page fault handlers. As part of that char/agp driver is also getting changed to returnvm_fault_ttype from fault handler.Signed-off-by Souptick Joarder <[email protected]>Reviewed-by Matthew Wilcox <[email protected]>--- drivers/char/agp/alpha-agp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/char/agp/alpha-agp.c +1
-2@@ -11,7 +11,7 @@#include "agp.h" -static int alpha_core_agp_vm_fault (struct vm_fault *vmf) +static vm_fault_t alpha_core_agp_vm_fault (struct vm_fault *vmf) {alpha_agp_info *agp = agp_bridge->dev_private_data;dma_addr_t dma_addr; --
Quoted 2 lines
1.9.1
Any comment for this patch ?
Quoted 27 lines · Souptick Joarder
Quoted 26 lines · Souptick Joarder
Use new return type
vm_fault_tfor fault handler. For now, this is just documenting that the function returns aVM_FAULTvalue rather than an errno. Once all instances are converted,vm_fault_twill become a distinct type.Ref-> commit
1c8f422059ae("mm: change return type tovm_fault_t") was added in 4.17-rc1 to introduce the new typedefvm_fault_t. Currently we are making change to all drivers to returnvm_fault_tfor page fault handlers. As part of that char/agp driver is also getting changed to returnvm_fault_ttype from fault handler.Signed-off-by Souptick Joarder <[email protected]>Reviewed-by Matthew Wilcox <[email protected]>--- drivers/char/agp/alpha-agp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/char/agp/alpha-agp.c +0
-0@@ -11,7 +11,7 @@#include "agp.h"
Quoted 10 lines
Quoted 8 lines
drivers/char/agp/alpha-agp.c +1
-2-static int alpha_core_agp_vm_fault (struct vm_fault *vmf) +static vm_fault_t alpha_core_agp_vm_fault (struct vm_fault *vmf) {alpha_agp_info *agp = agp_bridge->dev_private_data;dma_addr_t dma_addr; --1.9.1
Any comment for this patch ?
Any further comment on this patch ?
Quoted 39 lines · Souptick Joarder
Quoted 27 lines · Souptick Joarder
Quoted 26 lines · Souptick Joarder
Use new return type
vm_fault_tfor fault handler. For now, this is just documenting that the function returns aVM_FAULTvalue rather than an errno. Once all instances are converted,vm_fault_twill become a distinct type.Ref-> commit
1c8f422059ae("mm: change return type tovm_fault_t") was added in 4.17-rc1 to introduce the new typedefvm_fault_t. Currently we are making change to all drivers to returnvm_fault_tfor page fault handlers. As part of that char/agp driver is also getting changed to returnvm_fault_ttype from fault handler.Signed-off-by Souptick Joarder <[email protected]>Reviewed-by Matthew Wilcox <[email protected]>--- drivers/char/agp/alpha-agp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/char/agp/alpha-agp.c +0
-0@@ -11,7 +11,7 @@#include "agp.h" Quoted 10 lines
Quoted 8 lines
drivers/char/agp/alpha-agp.c +1
-2-static int alpha_core_agp_vm_fault (struct vm_fault *vmf) +static vm_fault_t alpha_core_agp_vm_fault (struct vm_fault *vmf) {alpha_agp_info *agp = agp_bridge->dev_private_data;dma_addr_t dma_addr; --1.9.1
Any comment for this patch ?
Quoted 1 line
Any further comment on this patch ?
Greg, Can we get this patch in queue for 4.19 ?
Quoted 40 lines · Souptick Joarder
Quoted 39 lines · Souptick Joarder
Quoted 37 lines · Souptick Joarder
Quoted 32 lines · Souptick Joarder
Use new return type
vm_fault_tfor fault handler. For now, this is just documenting that the function returns aVM_FAULTvalue rather than an errno. Once all instances are converted,vm_fault_twill become a distinct type.Ref-> commit
1c8f422059ae("mm: change return type tovm_fault_t") was added in 4.17-rc1 to introduce the new typedefvm_fault_t. Currently we are making change to all drivers to returnvm_fault_tfor page fault handlers. As part of that char/agp driver is also getting changed to returnvm_fault_ttype from fault handler.Signed-off-by Souptick Joarder <[email protected]>Reviewed-by Matthew Wilcox <[email protected]>--- drivers/char/agp/alpha-agp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/char/agp/alpha-agp.c +1
-2@@ -11,7 +11,7 @@#include "agp.h" -static int alpha_core_agp_vm_fault (struct vm_fault *vmf) +static vm_fault_t alpha_core_agp_vm_fault (struct vm_fault *vmf) {alpha_agp_info *agp = agp_bridge->dev_private_data;dma_addr_t dma_addr; --Quoted 2 lines
1.9.1
Any comment for this patch ?
Quoted 3 lines
Quoted 1 line
Any further comment on this patch ?
Greg, Can we get this patch in queue for 4.19 ?
I am not the agp maintainer, am I? That would be David...
thanks,
greg k-h
Quoted 41 lines · Greg KH
Quoted 40 lines · Souptick Joarder
Quoted 39 lines · Souptick Joarder
Quoted 37 lines · Souptick Joarder
Quoted 32 lines · Souptick Joarder
Use new return type
vm_fault_tfor fault handler. For now, this is just documenting that the function returns aVM_FAULTvalue rather than an errno. Once all instances are converted,vm_fault_twill become a distinct type.Ref-> commit
1c8f422059ae("mm: change return type tovm_fault_t") was added in 4.17-rc1 to introduce the new typedefvm_fault_t. Currently we are making change to all drivers to returnvm_fault_tfor page fault handlers. As part of that char/agp driver is also getting changed to returnvm_fault_ttype from fault handler.Signed-off-by Souptick Joarder <[email protected]>Reviewed-by Matthew Wilcox <[email protected]>--- drivers/char/agp/alpha-agp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/char/agp/alpha-agp.c +1
-2@@ -11,7 +11,7 @@#include "agp.h" -static int alpha_core_agp_vm_fault (struct vm_fault *vmf) +static vm_fault_t alpha_core_agp_vm_fault (struct vm_fault *vmf) {alpha_agp_info *agp = agp_bridge->dev_private_data;dma_addr_t dma_addr; --Quoted 2 lines
1.9.1
Any comment for this patch ?
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
Any further comment on this patch ?
Greg, Can we get this patch in queue for 4.19 ?
I am not the agp maintainer, am I? That would be David...
Sorry about it.
David, can we get this patch in queue for 4.19 ?