Skip to contentSkip to conversation

char: agp: Change return type to vm_fault_t

PATCH In review Souptick Joarder 2 participants 6 messages May 21, 2018 – Jul 2, 2018 Agpgart driver

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 char: agp: Change return type to vm_fault_t

Use new return type vm_fault_t for fault handler. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type.

Ref-> commit 1c8f422059ae ("mm: change return type to vm_fault_t") was added in 4.17-rc1 to introduce the new typedef vm_fault_t. Currently we are making change to all drivers to return vm_fault_t for page fault handlers. As part of that char/agp driver is also getting changed to return vm_fault_t type from fault handler.

---
 drivers/char/agp/alpha-agp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/agp/alpha-agp.c +1 -1
index 53fe633..c9bf2c2 100644
@@ -11,7 +11,7 @@
 
 #include "agp.h"
 
-static int alpha_core_agp_vm_fault(struct vm_fault *vmf)
+static vm_fault_t alpha_core_agp_vm_fault(struct vm_fault *vmf)
 {
 	alpha_agp_info *agp = agp_bridge->dev_private_data;
 	dma_addr_t dma_addr;
Signature · 1 line
1.9.1
#1 lore raw
Quoted 32 lines · Souptick Joarder

Use new return type vm_fault_t for fault handler. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type.

Ref-> commit 1c8f422059ae ("mm: change return type to vm_fault_t") was added in 4.17-rc1 to introduce the new typedef vm_fault_t. Currently we are making change to all drivers to return vm_fault_t for page fault handlers. As part of that char/agp driver is also getting changed to return vm_fault_t type from fault handler.

---
 drivers/char/agp/alpha-agp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/agp/alpha-agp.c +1 -2
index 53fe633..c9bf2c2 100644
@@ -11,7 +11,7 @@
 
 #include "agp.h"
 
-static int alpha_core_agp_vm_fault(struct vm_fault *vmf)
+static vm_fault_t alpha_core_agp_vm_fault(struct vm_fault *vmf)
 {
        alpha_agp_info *agp = agp_bridge->dev_private_data;
        dma_addr_t dma_addr;
--
Quoted 2 lines

1.9.1

Any comment for this patch ?

#2 lore raw
Quoted 27 lines · Souptick Joarder
Quoted 26 lines · Souptick Joarder

Use new return type vm_fault_t for fault handler. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type.

Ref-> commit 1c8f422059ae ("mm: change return type to vm_fault_t") was added in 4.17-rc1 to introduce the new typedef vm_fault_t. Currently we are making change to all drivers to return vm_fault_t for page fault handlers. As part of that char/agp driver is also getting changed to return vm_fault_t type from fault handler.

---
 drivers/char/agp/alpha-agp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/agp/alpha-agp.c +0 -0
index 53fe633..c9bf2c2 100644
@@ -11,7 +11,7 @@
 
 #include "agp.h"
 
Quoted 10 lines
Quoted 8 lines
drivers/char/agp/alpha-agp.c +1 -2
-static int alpha_core_agp_vm_fault(struct vm_fault *vmf)
+static vm_fault_t alpha_core_agp_vm_fault(struct vm_fault *vmf)
 {
        alpha_agp_info *agp = agp_bridge->dev_private_data;
        dma_addr_t dma_addr;
--

1.9.1

Any comment for this patch ?

Any further comment on this patch ?

#3 lore raw
Quoted 39 lines · Souptick Joarder
Quoted 27 lines · Souptick Joarder
Quoted 26 lines · Souptick Joarder

Use new return type vm_fault_t for fault handler. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type.

Ref-> commit 1c8f422059ae ("mm: change return type to vm_fault_t") was added in 4.17-rc1 to introduce the new typedef vm_fault_t. Currently we are making change to all drivers to return vm_fault_t for page fault handlers. As part of that char/agp driver is also getting changed to return vm_fault_t type from fault handler.

---
 drivers/char/agp/alpha-agp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/agp/alpha-agp.c +0 -0
index 53fe633..c9bf2c2 100644
@@ -11,7 +11,7 @@
 
 #include "agp.h"
 
Quoted 10 lines
Quoted 8 lines
drivers/char/agp/alpha-agp.c +1 -2
-static int alpha_core_agp_vm_fault(struct vm_fault *vmf)
+static vm_fault_t alpha_core_agp_vm_fault(struct vm_fault *vmf)
 {
        alpha_agp_info *agp = agp_bridge->dev_private_data;
        dma_addr_t dma_addr;
--

1.9.1

Any comment for this patch ?

Quoted 1 line

Any further comment on this patch ?

Greg, Can we get this patch in queue for 4.19 ?

#4 lore raw
Quoted 40 lines · Souptick Joarder
Quoted 39 lines · Souptick Joarder
Quoted 37 lines · Souptick Joarder
Quoted 32 lines · Souptick Joarder

Use new return type vm_fault_t for fault handler. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type.

Ref-> commit 1c8f422059ae ("mm: change return type to vm_fault_t") was added in 4.17-rc1 to introduce the new typedef vm_fault_t. Currently we are making change to all drivers to return vm_fault_t for page fault handlers. As part of that char/agp driver is also getting changed to return vm_fault_t type from fault handler.

---
 drivers/char/agp/alpha-agp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/agp/alpha-agp.c +1 -2
index 53fe633..c9bf2c2 100644
@@ -11,7 +11,7 @@
 
 #include "agp.h"
 
-static int alpha_core_agp_vm_fault(struct vm_fault *vmf)
+static vm_fault_t alpha_core_agp_vm_fault(struct vm_fault *vmf)
 {
        alpha_agp_info *agp = agp_bridge->dev_private_data;
        dma_addr_t dma_addr;
--
Quoted 2 lines

1.9.1

Any comment for this patch ?

Quoted 3 lines
Quoted 1 line

Any further comment on this patch ?

Greg, Can we get this patch in queue for 4.19 ?

I am not the agp maintainer, am I? That would be David...

thanks,

greg k-h

#5 lore raw
Quoted 41 lines · Greg KH
Quoted 40 lines · Souptick Joarder
Quoted 39 lines · Souptick Joarder
Quoted 37 lines · Souptick Joarder
Quoted 32 lines · Souptick Joarder

Use new return type vm_fault_t for fault handler. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type.

Ref-> commit 1c8f422059ae ("mm: change return type to vm_fault_t") was added in 4.17-rc1 to introduce the new typedef vm_fault_t. Currently we are making change to all drivers to return vm_fault_t for page fault handlers. As part of that char/agp driver is also getting changed to return vm_fault_t type from fault handler.

---
 drivers/char/agp/alpha-agp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/agp/alpha-agp.c +1 -2
index 53fe633..c9bf2c2 100644
@@ -11,7 +11,7 @@
 
 #include "agp.h"
 
-static int alpha_core_agp_vm_fault(struct vm_fault *vmf)
+static vm_fault_t alpha_core_agp_vm_fault(struct vm_fault *vmf)
 {
        alpha_agp_info *agp = agp_bridge->dev_private_data;
        dma_addr_t dma_addr;
--
Quoted 2 lines

1.9.1

Any comment for this patch ?

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

Any further comment on this patch ?

Greg, Can we get this patch in queue for 4.19 ?

I am not the agp maintainer, am I? That would be David...

Sorry about it.

David, can we get this patch in queue for 4.19 ?