xen/kbdif: Move multi-touch device parameters to backend nodes
PATCH 1/3 xen/kbdif: Move multi-touch device parameters to backend nodes
From: Oleksandr Andrushchenko <[email protected]>
In current kbdif protocol definition multi-touch device parameters are described as a part of frontend's XenBus configuration nodes while they belong to backend's configuration. Fix this by moving the parameters to the proper section.
--- xen/include/public/io/kbdif.h | 38 +++++++++++++++++------------------ 1 file changed, 19 insertions(+), 19 deletions(-)
xen/include/public/io/kbdif.h +19 -19
@@ -96,6 +96,25 @@* Maximum Y coordinate (height) to be used by the frontend * while reporting input events, pixels, [0; UINT32_MAX]. * +*----------------------- Multi-touch Device Parameters ---------------------- +* +* multi-touch-num-contacts +* Values: <uint> +* +* Number of simultaneous touches reported. +* +* multi-touch-width +* Values: <uint> +* +* Width of the touch area to be used by the frontend +* while reporting input events, pixels, [0; UINT32_MAX]. +* +* multi-touch-height +* Values: <uint> +* +* Height of the touch area to be used by the frontend +* while reporting input events, pixels, [0; UINT32_MAX]. +* ***************************************************************************** * Frontend XenBus Nodes *****************************************************************************
@@ -143,25 +162,6 @@* * OBSOLETE, not recommended for use. * PFN of the shared page. -* -*----------------------- Multi-touch Device Parameters ----------------------- -* -* multi-touch-num-contacts -* Values: <uint> -* -* Number of simultaneous touches reported. -* -* multi-touch-width -* Values: <uint> -* -* Width of the touch area to be used by the frontend -* while reporting input events, pixels, [0; UINT32_MAX]. -* -* multi-touch-height -* Values: <uint> -* -* Height of the touch area to be used by the frontend -* while reporting input events, pixels, [0; UINT32_MAX]. */ /*
Signature · 7 lines
2.17.0 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
PATCH 2/3 xen/kbdif: Add unique input device identifier
From: Oleksandr Andrushchenko <[email protected]>
If frontend is configured to expose multiple input device instances then backend may require a way to uniquely identify concrete input device within the frontend. This is useful for use-cases where virtual input device needs to be matched to physical input device. Add XenBus "unique-id" node parameter, so this sort of use-cases can be implemented.
--- xen/include/public/io/kbdif.h | 10 ++++++++++ 1 file changed, 10 insertions(+)
xen/include/public/io/kbdif.h +10 -0
@@ -82,6 +82,15 @@* for pointer devices should set this to 1. Raw (unscaled) values have * a range of [0, 0x7fff]. * +*----------------------- Device Instance Parameters ------------------------ +* +* unique-id +* Values: <uint32_t> +* +* After device instance initialization it is assigned a unique ID +* (within the front driver), so every instance of the frontend can be +* identified by the backend by this ID. +* *------------------------- Pointer Device Parameters ------------------------ * * width
@@ -204,6 +213,7 @@#define XENKBD_FIELD_MT_WIDTH "multi-touch-width"#define XENKBD_FIELD_MT_HEIGHT "multi-touch-height"#define XENKBD_FIELD_MT_NUM_CONTACTS "multi-touch-num-contacts" +#define XENKBD_FIELD_UNIQUE_ID "unique-id"/* OBSOLETE, not recommended for use */ #define XENKBD_FIELD_RING_REF "page-ref"
Signature · 7 lines
2.17.0 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [PATCH 2/3] xen/kbdif: Add unique input device identifier
Quoted 19 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
If frontend is configured to expose multiple input device instances then backend may require a way to uniquely identify concrete input device within the frontend. This is useful for use-cases where virtual input device needs to be matched to physical input device. Add XenBus "unique-id" node parameter, so this sort of use-cases can be implemented.
Signed-off-by Oleksandr Andrushchenko <[email protected]>--- xen/include/public/io/kbdif.h | 10 ++++++++++ 1 file changed, 10 insertions(+)xen/include/public/io/kbdif.h +0
-0
xen/include/public/io/kbdif.h line 88
Quoted 7 lines
xen/include/public/io/kbdif.h +4
-0@@ -82,6 +82,15 @@* for pointer devices should set this to 1. Raw (unscaled) values have * a range of [0, 0x7fff]. * +*----------------------- Device Instance Parameters ------------------------ +* +* unique-id +* Values: <uint32_t>
Wouldn't a string be easier? That way you can extend this in the future to also have an UUID or so?
Quoted 19 lines
xen/include/public/io/kbdif.h +6
-0+* +* After device instance initialization it is assigned a unique ID +* (within the front driver), so every instance of the frontend can be +* identified by the backend by this ID. +* *------------------------- Pointer Device Parameters ------------------------ * * width @@ -204,6 +213,7 @@#define XENKBD_FIELD_MT_WIDTH "multi-touch-width"#define XENKBD_FIELD_MT_HEIGHT "multi-touch-height"#define XENKBD_FIELD_MT_NUM_CONTACTS "multi-touch-num-contacts" +#define XENKBD_FIELD_UNIQUE_ID "unique-id"/* OBSOLETE, not recommended for use */ #define XENKBD_FIELD_RING_REF "page-ref"Signature · 1 line
2.17.0
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [PATCH 2/3] xen/kbdif: Add unique input device identifier
Quoted 15 lines · Konrad Rzeszutek Wilk
Quoted 14 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
If frontend is configured to expose multiple input device instances then backend may require a way to uniquely identify concrete input device within the frontend. This is useful for use-cases where virtual input device needs to be matched to physical input device. Add XenBus "unique-id" node parameter, so this sort of use-cases can be implemented.
Signed-off-by Oleksandr Andrushchenko <[email protected]>--- xen/include/public/io/kbdif.h | 10 ++++++++++ 1 file changed, 10 insertions(+)
Quoted 14 lines
xen/include/public/io/kbdif.h line 88
Quoted 12 lines
xen/include/public/io/kbdif.h +4
-0@@ -82,6 +82,15 @@* for pointer devices should set this to 1. Raw (unscaled) values have * a range of [0, 0x7fff]. * +*----------------------- Device Instance Parameters ------------------------ +* +* unique-id +* Values: <uint32_t> Wouldn't a string be easier? That way you can extend this in the future to also have an UUID or so?
Much easier. We were thinking about that as well, but sndif already has it as uint32_t. If you are ok to change uniquie-id for sndif to string then that would be much better: UUID as you mention + all protocols have unique-id consistently defined as string.
sndif's unique-id is not used by the frontend driver and we are about to start libx/xl support for sound, so I think this is the right time for such a change.
If you are fine with that then I'll send yet another patch for sndif.
Quoted 14 lines
Quoted 14 lines
xen/include/public/io/kbdif.h +6
-0+* +* After device instance initialization it is assigned a unique ID +* (within the front driver), so every instance of the frontend can be +* identified by the backend by this ID. +* *------------------------- Pointer Device Parameters ------------------------ * * width @@ -204,6 +213,7 @@#define XENKBD_FIELD_MT_WIDTH "multi-touch-width"#define XENKBD_FIELD_MT_HEIGHT "multi-touch-height"#define XENKBD_FIELD_MT_NUM_CONTACTS "multi-touch-num-contacts" +#define XENKBD_FIELD_UNIQUE_ID "unique-id"
Quoted 5 lines
Quoted 5 lines
xen/include/public/io/kbdif.h +0
-0/* OBSOLETE, not recommended for use */ #define XENKBD_FIELD_RING_REF "page-ref"Signature · 1 line
2.17.0
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Konrad Rzeszutek Wilk
Reviewed-byRe: [PATCH 2/3] xen/kbdif: Add unique input device identifier
Quoted 30 lines · Oleksandr Andrushchenko
Quoted 15 lines · Konrad Rzeszutek Wilk
Quoted 14 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
If frontend is configured to expose multiple input device instances then backend may require a way to uniquely identify concrete input device within the frontend. This is useful for use-cases where virtual input device needs to be matched to physical input device. Add XenBus "unique-id" node parameter, so this sort of use-cases can be implemented.
Signed-off-by Oleksandr Andrushchenko <[email protected]>--- xen/include/public/io/kbdif.h | 10 ++++++++++ 1 file changed, 10 insertions(+)Quoted 14 lines
xen/include/public/io/kbdif.h line 88
Quoted 12 lines
xen/include/public/io/kbdif.h +4
-0@@ -82,6 +82,15 @@* for pointer devices should set this to 1. Raw (unscaled) values have * a range of [0, 0x7fff]. * +*----------------------- Device Instance Parameters ------------------------ +* +* unique-id +* Values: <uint32_t> Wouldn't a string be easier? That way you can extend this in the future to also have an UUID or so?
Quoted 9 lines
Much easier. We were thinking about that as well, but sndif already has it as
uint32_t. If you are ok to change uniquie-id for sndif to string then that
would be much better: UUID as you mention + all protocols have unique-id consistently defined as string.
sndif's unique-id is not used by the frontend driver and we are about to start libx/xl support for sound, so I think this is the right time for such a change.
If you are fine with that then I'll send yet another patch for sndif.
Please do and feel free to add
on it.
Also pls CC Juergen so he can release-ack it.
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
xen/include/public/io/kbdif.h +5
-0+* +* After device instance initialization it is assigned a unique ID +* (within the front driver), so every instance of the frontend can be +* identified by the backend by this ID. +* *------------------------- Pointer Device Parameters ------------------------ * * width @@ -204,6 +213,7 @@#define XENKBD_FIELD_MT_WIDTH "multi-touch-width"
Quoted 9 lines
Quoted 8 lines
Quoted 8 lines
xen/include/public/io/kbdif.h +1
-0#define XENKBD_FIELD_MT_HEIGHT "multi-touch-height"#define XENKBD_FIELD_MT_NUM_CONTACTS "multi-touch-num-contacts" +#define XENKBD_FIELD_UNIQUE_ID "unique-id"/* OBSOLETE, not recommended for use */ #define XENKBD_FIELD_RING_REF "page-ref"Signature · 1 line
2.17.0
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [PATCH 2/3] xen/kbdif: Add unique input device identifier
Quoted 40 lines · Konrad Rzeszutek Wilk
Quoted 30 lines · Oleksandr Andrushchenko
Quoted 15 lines · Konrad Rzeszutek Wilk
Quoted 14 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
If frontend is configured to expose multiple input device instances then backend may require a way to uniquely identify concrete input device within the frontend. This is useful for use-cases where virtual input device needs to be matched to physical input device. Add XenBus "unique-id" node parameter, so this sort of use-cases can be implemented.
Signed-off-by Oleksandr Andrushchenko <[email protected]>--- xen/include/public/io/kbdif.h | 10 ++++++++++ 1 file changed, 10 insertions(+)Quoted 14 lines
xen/include/public/io/kbdif.h line 88
Quoted 12 lines
xen/include/public/io/kbdif.h +4
-0@@ -82,6 +82,15 @@* for pointer devices should set this to 1. Raw (unscaled) values have * a range of [0, 0x7fff]. * +*----------------------- Device Instance Parameters ------------------------ +* +* unique-id +* Values: <uint32_t> Wouldn't a string be easier? That way you can extend this in the future to also have an UUID or so?
Quoted 9 lines
Much easier. We were thinking about that as well, but sndif already has it as
uint32_t. If you are ok to change uniquie-id for sndif to string then that
would be much better: UUID as you mention + all protocols have unique-id consistently defined as string.
sndif's unique-id is not used by the frontend driver and we are about to start libx/xl support for sound, so I think this is the right time for such a change.
If you are fine with that then I'll send yet another patch for sndif.
Quoted 7 lines
Please do and feel free to add
Reviewed-by Konrad Rzeszutek Wilk <[email protected]>on it.
Also pls CC Juergen so he can release-ack it.
Thank you
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
xen/include/public/io/kbdif.h +5
-0+* +* After device instance initialization it is assigned a unique ID +* (within the front driver), so every instance of the frontend can be +* identified by the backend by this ID. +* *------------------------- Pointer Device Parameters ------------------------ * * width @@ -204,6 +213,7 @@#define XENKBD_FIELD_MT_WIDTH "multi-touch-width"
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
xen/include/public/io/kbdif.h +1
-0#define XENKBD_FIELD_MT_HEIGHT "multi-touch-height"#define XENKBD_FIELD_MT_NUM_CONTACTS "multi-touch-num-contacts" +#define XENKBD_FIELD_UNIQUE_ID "unique-id"/* OBSOLETE, not recommended for use */ #define XENKBD_FIELD_RING_REF "page-ref"Signature · 1 line
2.17.0
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
PATCH 3/3 xen/displif: Add unique display connector identifier
In reply to Oleksandr AndrushchenkoFrom: Oleksandr Andrushchenko <[email protected]>
If frontend is configured to expose multiple connectors then backend may require a way to uniquely identify concrete virtual connector within the frontend. This is useful for use-cases where connector needs to be matched to physical display connector.
Add XenBus "unique-id" node parameter, so this sort of use-cases can be implemented.
--- xen/include/public/io/displif.h | 8 ++++++++ 1 file changed, 8 insertions(+)
xen/include/public/io/displif.h +8 -0
@@ -189,6 +189,13 @@ * *----------------------------- Connector settings ---------------------------- * + * unique-id + * Values: <uint32_t> + * + * After device instance initialization each connector is assigned a + * unique ID (within the front driver), so it can be identified by the + * backend by this ID. + * * resolution * Values: <width, uint32_t>x<height, uint32_t> *
@@ -368,6 +375,7 @@#define XENDISPL_FIELD_EVT_CHANNEL "evt-event-channel"#define XENDISPL_FIELD_RESOLUTION "resolution"#define XENDISPL_FIELD_BE_ALLOC "be-alloc" +#define XENDISPL_FIELD_UNIQUE_ID "unique-id"/* ******************************************************************************
Signature · 7 lines
2.17.0 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [PATCH 3/3] xen/displif: Add unique display connector identifier
Quoted 19 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
If frontend is configured to expose multiple connectors then backend may require a way to uniquely identify concrete virtual connector within the frontend. This is useful for use-cases where connector needs to be matched to physical display connector.
Add XenBus "unique-id" node parameter, so this sort of use-cases can be implemented.Signed-off-by Oleksandr Andrushchenko <[email protected]>--- xen/include/public/io/displif.h | 8 ++++++++ 1 file changed, 8 insertions(+)xen/include/public/io/displif.h +0
-0
xen/include/public/io/displif.h line 193
Quoted 5 lines
xen/include/public/io/displif.h +2
-0@@ -189,6 +189,13 @@ * *----------------------------- Connector settings ---------------------------- * + * unique-id + * Values: <uint32_t>
Ditto, perhaps an string instead?
Quoted 19 lines
xen/include/public/io/displif.h +6
-0+* +* After device instance initialization each connector is assigned a +* unique ID (within the front driver), so it can be identified by the +* backend by this ID. +* * resolution * Values: <width, uint32_t>x<height, uint32_t> * @@ -368,6 +375,7 @@#define XENDISPL_FIELD_EVT_CHANNEL "evt-event-channel"#define XENDISPL_FIELD_RESOLUTION "resolution"#define XENDISPL_FIELD_BE_ALLOC "be-alloc" +#define XENDISPL_FIELD_UNIQUE_ID "unique-id"/* ****************************************************************************** Signature · 1 line
2.17.0
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [PATCH 3/3] xen/displif: Add unique display connector identifier
Quoted 15 lines · Konrad Rzeszutek Wilk
Quoted 14 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
If frontend is configured to expose multiple connectors then backend may require a way to uniquely identify concrete virtual connector within the frontend. This is useful for use-cases where connector needs to be matched to physical display connector.
Add XenBus "unique-id" node parameter, so this sort of use-cases can be implemented.Signed-off-by Oleksandr Andrushchenko <[email protected]>--- xen/include/public/io/displif.h | 8 ++++++++ 1 file changed, 8 insertions(+)
Quoted 11 lines
xen/include/public/io/displif.h line 193
Quoted 10 lines
xen/include/public/io/displif.h +2
-0@@ -189,6 +189,13 @@ * *----------------------------- Connector settings ---------------------------- * + * unique-id + * Values: <uint32_t>Ditto, perhaps an string instead?
Ditto ;)
String is way better, but we have to decide if we want to be consistent with sndif
Quoted 14 lines
Quoted 14 lines
xen/include/public/io/displif.h +6
-0+* +* After device instance initialization each connector is assigned a +* unique ID (within the front driver), so it can be identified by the +* backend by this ID. +* * resolution * Values: <width, uint32_t>x<height, uint32_t> * @@ -368,6 +375,7 @@#define XENDISPL_FIELD_EVT_CHANNEL "evt-event-channel"#define XENDISPL_FIELD_RESOLUTION "resolution"#define XENDISPL_FIELD_BE_ALLOC "be-alloc" +#define XENDISPL_FIELD_UNIQUE_ID "unique-id"
Quoted 9 lines
Quoted 5 lines
xen/include/public/io/displif.h +0
-0/* ****************************************************************************** Signature · 1 line
2.17.0_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 7 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
In current kbdif protocol definition multi-touch device parameters are described as a part of frontend's XenBus configuration nodes while they belong to backend's configuration. Fix this by moving the parameters to the proper section.
Quoted 5 lines
Fixes b7a3ce49d528 ("xen/kbdif: add multi-touch support")Signed-off-by Oleksandr Andrushchenko <[email protected]>Reported-by Oleksandr Grytsov <[email protected]>Reviewed-by Oleksandr Grytsov <[email protected]>
Juergen, you OK if I check this in?
Quoted 63 lines
--- xen/include/public/io/kbdif.h | 38 +++++++++++++++++------------------ 1 file changed, 19 insertions(+), 19 deletions(-)xen/include/public/io/kbdif.h +19
-19@@ -96,6 +96,25 @@* Maximum Y coordinate (height) to be used by the frontend * while reporting input events, pixels, [0; UINT32_MAX]. * +*----------------------- Multi-touch Device Parameters ---------------------- +* +* multi-touch-num-contacts +* Values: <uint> +* +* Number of simultaneous touches reported. +* +* multi-touch-width +* Values: <uint> +* +* Width of the touch area to be used by the frontend +* while reporting input events, pixels, [0; UINT32_MAX]. +* +* multi-touch-height +* Values: <uint> +* +* Height of the touch area to be used by the frontend +* while reporting input events, pixels, [0; UINT32_MAX]. +* ***************************************************************************** * Frontend XenBus Nodes ***************************************************************************** @@ -143,25 +162,6 @@* * OBSOLETE, not recommended for use. * PFN of the shared page. -* -*----------------------- Multi-touch Device Parameters ----------------------- -* -* multi-touch-num-contacts -* Values: <uint> -* -* Number of simultaneous touches reported. -* -* multi-touch-width -* Values: <uint> -* -* Width of the touch area to be used by the frontend -* while reporting input events, pixels, [0; UINT32_MAX]. -* -* multi-touch-height -* Values: <uint> -* -* Height of the touch area to be used by the frontend -* while reporting input events, pixels, [0; UINT32_MAX]. */ /* Signature · 1 line
2.17.0
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 10 lines · Konrad Rzeszutek Wilk
Quoted 9 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
In current kbdif protocol definition multi-touch device parameters are described as a part of frontend's XenBus configuration nodes while they belong to backend's configuration. Fix this by moving the parameters to the proper section.
Fixes b7a3ce49d528 ("xen/kbdif: add multi-touch support")
Quoted 7 lines
Quoted 3 lines
Signed-off-by Oleksandr Andrushchenko <[email protected]>Reported-by Oleksandr Grytsov <[email protected]>Reviewed-by Oleksandr Grytsov <[email protected]>Reviewed-by Konrad Rzeszutek Wilk <[email protected]>Juergen, you OK if I check this in?
Looking at the changes tehy seem to be low risk. ;-)
Juergen
Quoted 60 lines
Quoted 60 lines
--- xen/include/public/io/kbdif.h | 38 +++++++++++++++++------------------ 1 file changed, 19 insertions(+), 19 deletions(-)xen/include/public/io/kbdif.h +19
-19@@ -96,6 +96,25 @@* Maximum Y coordinate (height) to be used by the frontend * while reporting input events, pixels, [0; UINT32_MAX]. * +*----------------------- Multi-touch Device Parameters ---------------------- +* +* multi-touch-num-contacts +* Values: <uint> +* +* Number of simultaneous touches reported. +* +* multi-touch-width +* Values: <uint> +* +* Width of the touch area to be used by the frontend +* while reporting input events, pixels, [0; UINT32_MAX]. +* +* multi-touch-height +* Values: <uint> +* +* Height of the touch area to be used by the frontend +* while reporting input events, pixels, [0; UINT32_MAX]. +* ***************************************************************************** * Frontend XenBus Nodes ***************************************************************************** @@ -143,25 +162,6 @@* * OBSOLETE, not recommended for use. * PFN of the shared page. -* -*----------------------- Multi-touch Device Parameters ----------------------- -* -* multi-touch-num-contacts -* Values: <uint> -* -* Number of simultaneous touches reported. -* -* multi-touch-width -* Values: <uint> -* -* Width of the touch area to be used by the frontend -* while reporting input events, pixels, [0; UINT32_MAX]. -* -* multi-touch-height -* Values: <uint> -* -* Height of the touch area to be used by the frontend -* while reporting input events, pixels, [0; UINT32_MAX]. */
Quoted 5 lines
Quoted 4 lines
xen/include/public/io/kbdif.h +0
-0/* Signature · 1 line
2.17.0
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel