Skip to contentSkip to conversation

xfs: fix inobt magic number check

PATCH In review Darrick J. Wong 2 participants 2 messages May 24, 2018 XFS filesystem

lore
Share & tools
lore

Darrick J. Wong

author
#0 lore raw

PATCH 1/1 xfs: fix inobt magic number check

From: Darrick J. Wong <[email protected]>

In commit a6a781a58befcbd467c ("xfs: have buffer verifier functions report failing address") the bad magic number return was ported incorrectly.

Fixes a6a781a58befcbd467ce843af4eaca3906aa1f08
Reported-by [email protected]
Signed-off-by Darrick J. Wong <[email protected]>
---
 fs/xfs/libxfs/xfs_ialloc_btree.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/libxfs/xfs_ialloc_btree.c +1 -1
index ba053a4c124f..b04c55512159 100644
@@ -296,7 +296,7 @@ xfs_inobt_verify(
 	case cpu_to_be32(XFS_FIBT_MAGIC):
 		break;
 	default:
-		return NULL;
+		return __this_address;
 	}
 
 	/* level verification */
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Darrick J. Wong

From: Darrick J. Wong <[email protected]>

In commit a6a781a58befcbd467c ("xfs: have buffer verifier functions report failing address") the bad magic number return was ported incorrectly.

Fixes a6a781a58befcbd467ce843af4eaca3906aa1f08
Reported-by [email protected]
Signed-off-by Darrick J. Wong <[email protected]>
Reviewed-by Eric Sandeen <[email protected]>
Quoted 17 lines
---
  fs/xfs/libxfs/xfs_ialloc_btree.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/libxfs/xfs_ialloc_btree.c +1 -1
index ba053a4c124f..b04c55512159 100644
@@ -296,7 +296,7 @@ xfs_inobt_verify(
  	case cpu_to_be32(XFS_FIBT_MAGIC):
  		break;
  	default:
-		return NULL;
+		return __this_address;
  	}
 
  	/* level verification */