pwm: stm32: enforce dependency on CONFIG_MFD_STM32_TIMERS
PATCH 1/1 pwm: stm32: enforce dependency on CONFIG_MFD_STM32_TIMERS
When compile-testing the pwm driver without also enabling the stm32_timers MFD, we run into a link error:
drivers/pwm/pwm-stm32.o: In function `stm32_pwm_raw_capture.isra.6':
pwm-stm32.c:(.text+0xcb0): undefined reference to `stm32_timers_dma_burst_read'
We don't need the '|| COMPILE_TEST' here, since stm32_timers itself can be built with CONFIG_COMPILE_TEST on all architectures, so we do get the coverage through allmodconfig and randconfig builds even when we make it a hard dependency.
--- drivers/pwm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pwm/Kconfig +1 -1
@@ -401,7 +401,7 @@ config PWM_STI config PWM_STM32 tristate "STMicroelectronics STM32 PWM" - depends on MFD_STM32_TIMERS || COMPILE_TEST + depends on MFD_STM32_TIMERS help Generic PWM framework driver for STM32 SoCs.
Signature · 1 line
2.9.0
Thierry Reding
AppliedQuoted 11 lines · Arnd Bergmann
When compile-testing the pwm driver without also enabling the
stm32_timersMFD, we run into a link error:
drivers/pwm/pwm-stm32.o: In function `stm32_pwm_raw_capture.isra.6':
pwm-stm32.c:(.text+0xcb0): undefined reference to `stm32_timers_dma_burst_read'We don't need the '||
COMPILE_TEST' here, sincestm32_timersitself can be built withCONFIG_COMPILE_TESTon all architectures, so we do get the coverage through allmodconfig and randconfig builds even when we make it a hard dependency.
Quoted 5 lines
Fixes 7edf7369205b ("pwm: Add driver for STM32 plaftorm")Signed-off-by Arnd Bergmann <[email protected]>--- drivers/pwm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Thierry
Quoted 11 lines · Arnd Bergmann
When compile-testing the pwm driver without also enabling the
stm32_timersMFD, we run into a link error:
drivers/pwm/pwm-stm32.o: In function `stm32_pwm_raw_capture.isra.6':
pwm-stm32.c:(.text+0xcb0): undefined reference to `stm32_timers_dma_burst_read'We don't need the '||
COMPILE_TEST' here, sincestm32_timersitself can be built withCONFIG_COMPILE_TESTon all architectures, so we do get the coverage through allmodconfig and randconfig builds even when we make it a hard dependency.
Quoted 5 lines
Fixes 7edf7369205b ("pwm: Add driver for STM32 plaftorm")Signed-off-by Arnd Bergmann <[email protected]>--- drivers/pwm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
I think Lee already picked up a patch by Fabrice that fixes this by adding a dummy implementation, see:
http://patchwork.ozlabs.org/patch/916435/
I prefer your solution, though, because the dummy is pretty redundant if we can just make this a hard-dependency and still get the same coverage.
Thierry
Quoted 18 lines · Thierry Reding
Quoted 11 lines · Arnd Bergmann
When compile-testing the pwm driver without also enabling the
stm32_timersMFD, we run into a link error:
drivers/pwm/pwm-stm32.o: In function `stm32_pwm_raw_capture.isra.6':
pwm-stm32.c:(.text+0xcb0): undefined reference to `stm32_timers_dma_burst_read'We don't need the '||
COMPILE_TEST' here, sincestm32_timersitself can be built withCONFIG_COMPILE_TESTon all architectures, so we do get the coverage through allmodconfig and randconfig builds even when we make it a hard dependency.Quoted 5 lines
Fixes 7edf7369205b ("pwm: Add driver for STM32 plaftorm")Signed-off-by Arnd Bergmann <[email protected]>--- drivers/pwm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 7 lines
I think Lee already picked up a patch by Fabrice that fixes this by adding a dummy implementation, see:
http://patchwork.ozlabs.org/patch/916435/I prefer your solution, though, because the dummy is pretty redundant if we can just make this a hard-dependency and still get the same coverage.
The two patches aren't mutually exclusive. :)
Signature · 4 lines
Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog