Skip to contentSkip to conversation

ath6kl: mark expected switch fall-throughs

PATCH In review Gustavo A. R. Silva 3 participants 4 messages May 25, 2018 – Jun 13, 2018

Subsystems (3)
Networking Network drivers Atheros ATH6KL wireless driver
lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH v2 1/1 ath6kl: mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
Changes in v2:
- Place code comments on a line of their own.

 drivers/net/wireless/ath/ath6kl/cfg80211.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/net/wireless/ath/ath6kl/cfg80211.c +3 -0
index 2ba8cf3..a16ee5d 100644
@@ -3899,16 +3899,19 @@ int ath6kl_cfg80211_init(struct ath6kl *ar)
 	switch (ar->hw.cap) {
 	case WMI_11AN_CAP:
 		ht = true;
+		/* fall through */
 	case WMI_11A_CAP:
 		band_5gig = true;
 		break;
 	case WMI_11GN_CAP:
 		ht = true;
+		/* fall through */
 	case WMI_11G_CAP:
 		band_2gig = true;
 		break;
 	case WMI_11AGN_CAP:
 		ht = true;
+		/* fall through */
 	case WMI_11AG_CAP:
 		band_2gig = true;
 		band_5gig = true;
Signature · 1 line
2.7.4
Reviewed-by on v2 1/1
#1 lore raw
Quoted 4 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Signed-off-by Gustavo A. R. Silva <[email protected]>

Review

Quoted 8 lines

---
Changes in v2:
- Place code comments on a line of their own.

   drivers/net/wireless/ath/ath6kl/cfg80211.c | 3 +++
   1 file changed, 3 insertions(+)
(quoted diff) +0 -0

b/drivers/net/wireless/ath/ath6kl/cfg80211.c

Quoted 24 lines

index 2ba8cf3..a16ee5d 100644

drivers/net/wireless/ath/ath6kl/cfg80211.c +3 -1
@@ -3899,16 +3899,19 @@ int ath6kl_cfg80211_init(struct ath6kl *ar)
          switch (ar->hw.cap) {
          case WMI_11AN_CAP:
                  ht = true;
+               /* fall through */
          case WMI_11A_CAP:
                  band_5gig = true;
                  break;
          case WMI_11GN_CAP:
                  ht = true;
+               /* fall through */
          case WMI_11G_CAP:
                  band_2gig = true;
                  break;
          case WMI_11AGN_CAP:
                  ht = true;
+               /* fall through */
          case WMI_11AG_CAP:
                  band_2gig = true;
                  band_5gig = true;
--
Quoted 1 line

2.7.4

Gustavo,

Thanks for the adjustment. It now looks good to me.

Reviewed-by Steve deRosier <[email protected]>
author
#2 lore raw
Quoted 46 lines · Steve deRosier
Quoted 4 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Signed-off-by Gustavo A. R. Silva <[email protected]>

Review

Quoted 8 lines

---
Changes in v2:
- Place code comments on a line of their own.

drivers/net/wireless/ath/ath6kl/cfg80211.c | 3 +++ 1 file changed, 3 insertions(+)

(quoted diff) +0 -0

b/drivers/net/wireless/ath/ath6kl/cfg80211.c

Quoted 24 lines

index 2ba8cf3..a16ee5d 100644

drivers/net/wireless/ath/ath6kl/cfg80211.c +3 -1
@@ -3899,16 +3899,19 @@ int ath6kl_cfg80211_init(struct ath6kl *ar)
           switch (ar->hw.cap) {
           case WMI_11AN_CAP:
                   ht = true;
+               /* fall through */
           case WMI_11A_CAP:
                   band_5gig = true;
                   break;
           case WMI_11GN_CAP:
                   ht = true;
+               /* fall through */
           case WMI_11G_CAP:
                   band_2gig = true;
                   break;
           case WMI_11AGN_CAP:
                   ht = true;
+               /* fall through */
           case WMI_11AG_CAP:
                   band_2gig = true;
                   band_5gig = true;
--
Quoted 1 line

2.7.4

Gustavo,

Quoted 2 lines

Thanks for the adjustment. It now looks good to me.

Glad to help. :)

Quoted 2 lines
Reviewed-by Steve deRosier <[email protected]>

Thanks
--
Gustavo

#3 lore raw
In reply to Gustavo A. R. Silva
Quoted 6 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Signed-off-by Gustavo A. R. Silva <[email protected]>
Reviewed-by Steve deRosier <[email protected]>
Signed-off-by Kalle Valo <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

4de30c906ef0 ath6kl: mark expected switch fall-throughs

Signature · 3 lines
https://patchwork.kernel.org/patch/10428239/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches