ixgbe: fix possible race in reset subtask
Subsystems (2)
Tony Nguyen
maintainerPATCH 1/1 ixgbe: fix possible race in reset subtask
Similar to ixgbevf, the same possibility for race exists. Extend the RTNL lock in ixgbe_reset_subtask() to protect the state bits; this is to make sure that we get the most up-to-date values for the bits and avoid a possible race when going down.
--- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +4 -2
@@ -7576,17 +7576,19 @@ static void ixgbe_reset_subtask(struct ixgbe_adapter *adapter)if (!test_and_clear_bit (__IXGBE_RESET_REQUESTED, &adapter->state))return ; +rtnl_lock ();/* If we're already down, removing or resetting, just bail */ if (test_bit (__IXGBE_DOWN, &adapter->state) ||test_bit (__IXGBE_REMOVING, &adapter->state) || -test_bit (__IXGBE_RESETTING, &adapter->state)) +test_bit (__IXGBE_RESETTING, &adapter->state)) { +rtnl_unlock ();return ; + }ixgbe_dump (adapter);netdev_err (adapter->netdev,"Reset adapter\n" ); adapter->tx_timeout_count++; -rtnl_lock ();ixgbe_reinit_locked (adapter);rtnl_unlock (); }
Signature · 1 line
2.13.6
Bowers
PATCH 1/1 ixgbe: fix possible race in reset subtask
Quoted 12 lines
-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf Of Tony Nguyen
Sent: Wednesday, May 30, 2018 9:05 AM
To: intel-wired-lan at lists.osuosl.org
Subject: [Intel-wired-lan] [PATCH] ixgbe: fix possible race in reset subtaskSimilar to ixgbevf, the same possibility for race exists. Extend the RTNL lock in
ixgbe_reset_subtask()to protect the state bits; this is to make sure that we get the most up-to-date values for the bits and avoid a possible race when going down.
Quoted 4 lines
Signed-off-by Tony Nguyen <[email protected]>--- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)