Unclear patch origin ?

Dear Tom,

I wonder where

commit b5351a439088dfffd83bfaac81f604344ee2e3bd
Author: Tom Rini <[email protected]>
Date: Sun Jun 3 16:10:22 2018 -0400

SPDX: Fixup tags from latest EFI PR

(and maybe more) is/are coming from. I cannot see any trace of this on the U-Boot mailing list. Which means, the patch was probably checked in without any review taking place? What is the process here?

What I really wonder about is this part of the commit:

@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * (C) 2018 Google, Inc
  * Written by Simon Glass <[email protected]>

i. e. you change the C++ comment style into classic C style - which we discussed at length, and you told me that was deprecated at this place?

I can't understand what is going on here...

Best regards,

Wolfgang Denk

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"One thing they don't tell you about doing  experimental  physics  is
that sometimes you must work under adverse conditions... like a state
of sheer terror."                                    - W. K. Hartmann

Trivial checkpatch.pl fixes and correct-by-inspection warning fixes don't get posted (and if I can figure out and fix them quickly, that's less of a burden on me than rejecting a change). When it doesn't come in via signed tag I often amend and signed-off-by and briefly note that was changed in brackets. In this case it's following the documented style. I posted the patch to update Licenses/README to have the same relevant text as the kernel. In this case:
C source: // SPDX-License-Identifier: <SPDX License Expression> C header: /* SPDX-License-Identifier: <SPDX License Expression> */
...
If a specific tool cannot handle the standard comment style, then the appropriate comment mechanism which the tool accepts shall be used. This is the reason for having the "/\* \*/" style comment in C header files. There was build breakage observed with generated .lds files where 'ld' failed to parse the C++ comment. This has been fixed by now, but there are still older assembler tools which cannot handle C++ style comments.

One of the things on my mental TODO list for the -rc1 email today was to let everyone know that I expect people to make use of ./scripts/checkpatch.pl --git and make sure that if there are WARNING / ERROR / CHECK statements they know why they're showing up.

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180604/f6d9a4e4/attachment.sig>