x86/debug changes for v4.18
Subsystems (4)
Linus,
Please pull the latest x86-debug-for-linus git tree from:
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86-debug-for-linus
# HEAD: 4dba072cd097f35fa8f77c49d909ada2b079a4c4 x86/dumpstack: Explain the reasoning for the prologue and buffer size
This tree contains the x86 oops code printing reorganization and cleanups from Borislav Betkov, with a particular focus in enhancing opcode dumping all around.
Thanks,
Ingo
------------------>
Borislav Petkov (9):
x86/dumpstack: Remove code_bytes
x86/dumpstack: Unexport oops_begin()
x86/dumpstack: Carve out code-dumping into a function x86/dumpstack: Improve opcodes dumping in the code section x86/dumpstack: Add loglevel argument to show_opcodes() x86/fault: Dump user opcode bytes on fatal faults x86/dumpstack: Add a show_ip() function
x86/dumpstack: Save first regs set for the executive summary x86/dumpstack: Explain the reasoning for the prologue and buffer size
Documentation/admin-guide/kernel-parameters.txt | 5 - arch/x86/include/asm/stacktrace.h | 2 + arch/x86/kernel/dumpstack.c | 144 ++++++++++++------------ arch/x86/kernel/process_32.c | 8 +- arch/x86/mm/fault.c | 7 +- 5 files changed, 80 insertions(+), 86 deletions(-)
Documentation/admin-guide/kernel-parameters.txt +0 -5
@@ -587,11 +587,6 @@ Sets the size of memory pool for coherent, atomic dma allocations, by default set to 256K. - code_bytes [X86] How many bytes of object code to print - in an oops report. - Range: 0 - 8192 - Default: 64 - com20020= [HW,NET] ARCnet - COM20020 chipset Format: <io>[,<irq>[,<nodeID>[,<backplane>[,<ckp>[,<timeout>]]]]]
arch/x86/include/asm/stacktrace.h +2 -0
@@ -111,4 +111,6 @@ static inline unsigned long caller_frame_pointer(void) return (unsigned long)frame; } +void show_opcodes (u8 *rip,const char *loglvl); +void show_ip (struct pt_regs *regs,const char *loglvl);#endif /* _ASM_X86_STACKTRACE_H */
arch/x86/kernel/dumpstack.c +70 -74
205 lines not on this page · raw message
arch/x86/kernel/process_32.c +3 -5
@@ -76,16 +76,14 @@ void __show_regs(struct pt_regs *regs, int all)savesegment (gs, gs); } -printk (KERN_DEFAULT "EIP: %pS\n" , (void *)regs->ip); -printk (KERN_DEFAULT "EFLAGS: %08lx CPU: %d\n" , regs->flags, -raw_smp_processor_id ()); +show_ip (regs,KERN_DEFAULT );printk (KERN_DEFAULT "EAX: %08lx EBX: %08lx ECX: %08lx EDX: %08lx\n" , regs->ax, regs->bx, regs->cx, regs->dx);printk (KERN_DEFAULT "ESI: %08lx EDI: %08lx EBP: %08lx ESP: %08lx\n" , regs->si, regs->di, regs->bp, sp); -printk (KERN_DEFAULT " DS: %04x ES: %04x FS: %04x GS: %04x SS: %04x\n" , - (u16 )regs->ds, (u16 )regs->es, (u16 )regs->fs, gs, ss); +printk (KERN_DEFAULT "DS: %04x ES: %04x FS: %04x GS: %04x SS: %04x EFLAGS: %08lx\n" , + (u16 )regs->ds, (u16 )regs->es, (u16 )regs->fs, gs, ss, regs->flags);if (!all)return ;
arch/x86/mm/fault.c +5 -2
@@ -828,6 +828,8 @@ static inline void show_signal_msg(struct pt_regs *regs, unsigned long error_code, unsigned long address, struct task_struct *tsk) { + const char *loglvl = task_pid_nr(tsk) > 1 ? KERN_INFO : KERN_EMERG; +if (!unhandled_signal (tsk,SIGSEGV ))return ;
@@ -835,13 +837,14 @@ show_signal_msg(struct pt_regs *regs, unsigned long error_code,return ;printk ("%s%s[%d]: segfault at %lx ip %px sp %px error %lx" , -task_pid_nr (tsk) >1 ?KERN_INFO :KERN_EMERG , - tsk->comm,task_pid_nr (tsk), address, + loglvl, tsk->comm,task_pid_nr (tsk), address, (void *)regs->ip, (void *)regs->sp, error_code);print_vma_addr (KERN_CONT " in " , regs->ip);printk (KERN_CONT "\n" ); + +show_opcodes ((u8 *)regs->ip, loglvl); } static void