Skip to contentSkip to conversation

vfs, pile 4

GIT PULL Al Viro 2 participants 4 messages Jun 4, 2018 VFS

lore
Share & tools
lore

Al Viro

author maintainer
#0 lore raw
	Cleaning ->lookup() instances up - mostly d_splice_alias() conversions.

The following changes since commit baf10564fbb66ea222cae66fbff11c444590ffd9:

aio: fix io_destroy(2) vs. lookup_ioctx() race (2018-05-21 14:30:11 -0400)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.lookup

for you to fetch changes up to 888e2b03ef56694290e58bd9ac23f8033bf6369f:

switch the rest of procfs lookups to d_splice_alias() (2018-05-26 14:20:50 -0400)

----------------------------------------------------------------
Al Viro (30):
Merge branch 'work.misc' into work.lookup
bfs_lookup(): use d_splice_alias()
bfs_find_entry: pass name/len as qstr pointer
bfs_add_entry: pass name/len as qstr pointer
cramfs_lookup(): use d_splice_alias()
freevxfs_lookup(): use d_splice_alias()
minix_lookup: use d_splice_alias()
qnx4_lookup: use d_splice_alias()
sysv_lookup: use d_splice_alias()
ubifs_lookup: use d_splice_alias()
qnx6_lookup: switch to d_splice_alias()
romfs_lookup: switch to d_splice_alias()
adfs_lookup_byname: .. *is* taken care of in fs/namei.c
adfs_lookup: do not fail with ENOENT on negatives, use d_splice_alias()
xfs_vn_lookup: simplify a bit
openpromfs: switch to d_splice_alias()
orangefs_lookup: simplify
omfs_lookup(): report IO errors, use d_splice_alias()
hfs: use d_splice_alias()
hfs: don't allow mounting over .../rsrc
hfsplus: switch to d_splice_alias()
ncp_lookup(): use d_splice_alias()
9p: unify paths in v9fs_vfs_lookup()
cifs_lookup(): cifs_get_inode_...() never returns 0 with *inode left NULL cifs_lookup(): switch to d_splice_alias()
procfs: get rid of ancient BS in pid_revalidate() uses proc_lookupfd_common(): don't bother with instantiate unless the file is open don't bother with tid_fd_revalidate() in lookups
procfs: switch instantiate_t to d_splice_alias()
switch the rest of procfs lookups to d_splice_alias()

 drivers/staging/ncpfs/dir.c        |  42 ++++-------
 fs/9p/vfs_inode.c                  |  35 ++++------
 fs/adfs/dir.c                      |  24 ++-----
 fs/bfs/dir.c                       |  43 +++++-------
 fs/cifs/dir.c                      |  38 +++++-----
 fs/cramfs/inode.c                  |   5 +-
 fs/dcache.c                        |  83 +++++++++-------------
 fs/fat/namei_msdos.c               |   4 --
 fs/fat/namei_vfat.c                |  13 +---
 fs/freevxfs/vxfs_lookup.c          |   8 +--
 fs/hfs/dir.c                       |  20 ++----
 fs/hfs/inode.c                     |   4 +-
 fs/hfsplus/dir.c                   |   3 +-
 fs/minix/namei.c                   |   8 +--
 fs/namei.c                         |   4 +-
 fs/omfs/dir.c                      |   7 +-
 fs/openpromfs/inode.c              |   3 +-
 fs/orangefs/namei.c                |  64 +++--------------
 fs/proc/base.c                     | 136 ++++++++++++++++--------------------
 fs/proc/fd.c                       | 138 ++++++++++++++++++++-----------------
 fs/proc/generic.c                  |   3 +-
 fs/proc/internal.h                 |   4 +-
 fs/proc/namespaces.c               |  24 +++----
 fs/proc/proc_sysctl.c              |  15 +++-
 fs/qnx4/namei.c                    |   8 +--
 fs/qnx6/namei.c                    |   8 +--
 fs/read_write.c                    |   6 +-
 fs/romfs/super.c                   |  36 +++-------
 fs/super.c                         |   2 +-
 fs/sysv/namei.c                    |   9 +--
 fs/ubifs/dir.c                     |  43 ++++--------
 fs/xattr.c                         |   3 +-
 fs/xfs/xfs_iops.c                  |  16 ++---
 include/linux/fs.h                 |   2 +-
 include/linux/sunrpc/rpc_pipe_fs.h |   2 -
 include/linux/xattr.h              |   1 -
 net/sunrpc/rpc_pipe.c              |  16 -----
 security/selinux/hooks.c           |   7 +-
 38 files changed, 338 insertions(+), 549 deletions(-)
#1 lore raw

Trouble counting to five, Al?

I'm getting "one, two, many" vibes.

Linus

author maintainer
#2 lore raw
Quoted 3 lines · Linus Torvalds

Trouble counting to five, Al?

I'm getting "one, two, many" vibes.

*blink*

FWIW, originally I considered combining the first two (they are closely connected), but in the end decided to send them as two separate pull requests.

So consider today's pile 4 as #5 and 5 - as #6 (or, better yet, "->lookup() cleanups" and "most of aio stuff"). Sorry...

#3 lore raw
Quoted 3 lines · Al Viro

So consider today's pile 4 as #5 and 5 - as #6 (or, better yet, "->lookup() cleanups" and "most of aio stuff"). Sorry...

Heh. I do something like that anyway, ie the four first ones are marked as

Pull dcache updates from Al Viro:
Pull rmdir update from Al Viro:
Pull procfs updates from Al Viro:
Pull misc vfs updates from Al Viro:

rather than enumerated. Maybe you should just do that yourself, since counting is clearly a problem ;)

Linus