x86/iommu: Fix a typo in a macro parameter
PATCH 1/1 x86/iommu: Fix a typo in a macro parameter
--- arch/x86/include/asm/iommu_table.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/include/asm/iommu_table.h +1 -1
@@ -66,7 +66,7 @@ struct iommu_table_entry {#define IOMMU_INIT_POST (_detect) \ __IOMMU_INIT(_detect, pci_swiotlb_detect_4gb, NULL, NULL, 0) -#define IOMMU_INIT_POST_FINISH (detect) \ +#define IOMMU_INIT_POST_FINISH (_detect) \ __IOMMU_INIT(_detect, pci_swiotlb_detect_4gb, NULL, NULL, 1)/*
Signature · 1 line
2.17.0
On Wed, 6 Jun 2018, Masatake YAMATO wrote:
Can you please explain why 0 is the wrong value. That's not a typo, that's a functional change and both the subject line and the changelog itself should be explanatory.
Thanks,
tglx
Quoted 22 lines
Signed-off-by Masatake YAMATO <[email protected]>--- arch/x86/include/asm/iommu_table.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/x86/include/asm/iommu_table.h +1
-1@@ -66,7 +66,7 @@ struct iommu_table_entry {#define IOMMU_INIT_POST (_detect) \ __IOMMU_INIT(_detect, pci_swiotlb_detect_4gb, NULL, NULL, 0) -#define IOMMU_INIT_POST_FINISH (detect) \ +#define IOMMU_INIT_POST_FINISH (_detect) \ __IOMMU_INIT(_detect, pci_swiotlb_detect_4gb, NULL, NULL, 1)/* Signature · 1 line
2.17.0
Quoted 3 lines · Thomas Gleixner
On Wed, 6 Jun 2018, Masatake YAMATO wrote:
Can you please explain why 0 is the wrong value.
I don't know such constants, 0 and 1.
What I change is just the name of macro parameter as
s/detect/_detect/
I don't change the definition of macro.
Masatake YAMATO
Quoted 30 lines
That's not a typo, that's
a functional change and both the subject line and the changelog itself should be explanatory.Thanks,
tglx
Quoted 22 lines
Signed-off-by Masatake YAMATO <[email protected]>--- arch/x86/include/asm/iommu_table.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/x86/include/asm/iommu_table.h +1
-1@@ -66,7 +66,7 @@ struct iommu_table_entry {#define IOMMU_INIT_POST (_detect) \ __IOMMU_INIT(_detect, pci_swiotlb_detect_4gb, NULL, NULL, 0) -#define IOMMU_INIT_POST_FINISH (detect) \ +#define IOMMU_INIT_POST_FINISH (_detect) \ __IOMMU_INIT(_detect, pci_swiotlb_detect_4gb, NULL, NULL, 1)/* Signature · 1 line
2.17.0
Quoted 10 lines · Masatake YAMATO
Quoted 3 lines · Thomas Gleixner
On Wed, 6 Jun 2018, Masatake YAMATO wrote:
Can you please explain why 0 is the wrong value.
I don't know such constants, 0 and 1.
What I change is just the name of macro parameter as
s/detect/_detect/
OOps. Misread the patch. Sorry.
Quoted 6 lines · Thomas Gleixner
Quoted 5 lines · Masatake YAMATO
Quoted 3 lines · Thomas Gleixner
On Wed, 6 Jun 2018, Masatake YAMATO wrote:
Can you please explain why 0 is the wrong value.
Quoted 7 lines
Quoted 5 lines
I don't know such constants, 0 and 1.
What I change is just the name of macro parameter as
s/detect/_detect/
OOps. Misread the patch. Sorry.
But the fix is pretty pointless. IOMMU_INIT_POST_FINISH() is completely unused and should just be removed.
Thanks,
tglx
Quoted 9 lines · Thomas Gleixner
Quoted 8 lines · Thomas Gleixner
Quoted 7 lines · Masatake YAMATO
Quoted 3 lines · Thomas Gleixner
On Wed, 6 Jun 2018, Masatake YAMATO wrote:
Can you please explain why 0 is the wrong value.
I don't know such constants, 0 and 1.
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
What I change is just the name of macro parameter as
s/detect/_detect/
OOps. Misread the patch. Sorry.
But the fix is pretty pointless.
IOMMU_INIT_POST_FINISH()is completely unused and should just be removed.
Oh, I see. Thank you for taking your time.
Masatake YAMATO
Quoted 3 lines
Thanks,
tglx