Skip to contentSkip to conversation

content: enhance device requirements for feature bits

PATCH Superseded Tiwei Bie 3 participants 3 messages Jun 8, 2018 – Jun 11, 2018

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Tiwei Bie

author
#0 lore raw

PATCH v2 1/1 content: enhance device requirements for feature bits

---
v2:
- Refine the wording (Cornelia);

 content.tex | 7 +++++++
 1 file changed, 7 insertions(+)
content.tex +7 -0
index f996fad..41cba41 100644
@@ -125,6 +125,13 @@ which was not offered.  The device SHOULD accept any valid subset
 of features the driver accepts, otherwise it MUST fail to set the
 FEATURES_OK \field{device status} bit when the driver writes it.
 
+If a device has successfully negotiated a set of features
+at least once (by succeeding to set the FEATURES_OK
+\field{device status} bit when the driver writes it), then
+it SHOULD NOT fail re-negotiation of the same set of features
+after a device or system reset.  Failure to do so would
+interfere with resuming from suspend and error recovery.
+
 \subsection{Legacy Interface: A Note on Feature
 Bits}\label{sec:Basic Facilities of a Virtio Device / Feature
 Bits / Legacy Interface: A Note on Feature Bits}
Signature · 6 lines
2.17.0


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Reviewed-by on v2 1/1
#1 lore raw
Quoted 18 lines · On Fri, 8 Jun 2018 16:12:36 +0800 Tiwei Bie <[email protected]> wrote:

---
v2:
- Refine the wording (Cornelia);

 content.tex | 7 +++++++
 1 file changed, 7 insertions(+)
content.tex +0 -0
index f996fad..41cba41 100644
@@ -125,6 +125,13 @@ which was not offered.  The device SHOULD accept any valid subset
 of features the driver accepts, otherwise it MUST fail to set the
 FEATURES_OK \field{device status} bit when the driver writes it.
 

content.tex which was not offered. The device SHOULD accept any valid subset · line 137

Quoted 10 lines
content.tex +7 -0
+If a device has successfully negotiated a set of features
+at least once (by succeeding to set the FEATURES_OK
+\field{device status} bit when the driver writes it), then
+it SHOULD NOT fail re-negotiation of the same set of features
+after a device or system reset.  Failure to do so would
+interfere with resuming from suspend and error recovery.
+
 \subsection{Legacy Interface: A Note on Feature
 Bits}\label{sec:Basic Facilities of a Virtio Device / Feature
 Bits / Legacy Interface: A Note on Feature Bits}

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]