Skip to contentSkip to conversation

cc5b114dcf bpf, i40e: add meta data support

BUG Keith Busch 4 participants 4 messages Jun 12, 2018 – Jun 25, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

My server's i40e no longer obtains an IP address on linux mainline. Bisected to the following:

commit cc5b114dcf986bfd8e4c37bf65d1b7b1e5290ac6

Author: Daniel Borkmann <[email protected]>
Date:   Mon May 28 11:07:20 2018 +0200

bpf, i40e: add meta data support

Reverting on mainline resolves the issue.

Is there something wrong with my i40e adapter, or is the patch possibly doing something wrong? Or any other information I can get to help understand why it's stopped working with this feature?

An excert from "journalctl -xe" on on the failing network adapter is below.

Thanks,
Keith

---

Jun 12 10:04:35 localhost.localdomain dhclient[2632]: DHCPDISCOVER on eno1 to 255.255.255.255 port 67 interval 7 (xid=0x3b301712)
Jun 12 10:04:42 localhost.localdomain dhclient[2632]: DHCPDISCOVER on eno1 to 255.255.255.255 port 67 interval 14 (xid=0x3b301712)
Jun 12 10:04:56 localhost.localdomain dhclient[2632]: DHCPDISCOVER on eno1 to 255.255.255.255 port 67 interval 21 (xid=0x3b301712)
Jun 12 10:05:03 localhost.localdomain NetworkManager[2215]: <warn>  [1528819503.2274] dhcp4 (eno1): request timed out
Jun 12 10:05:03 localhost.localdomain NetworkManager[2215]: <info>  [1528819503.2275] dhcp4 (eno1): state changed unknown -> timeout
Jun 12 10:05:03 localhost.localdomain NetworkManager[2215]: <info>  [1528819503.2440] dhcp4 (eno1): canceled DHCP transaction, DHCP client pid 2632
Jun 12 10:05:03 localhost.localdomain NetworkManager[2215]: <info>  [1528819503.2441] dhcp4 (eno1): state changed timeout -> done
Jun 12 10:05:03 localhost.localdomain NetworkManager[2215]: <info>  [1528819503.2445] device (eno1): state change: ip-config -> failed (reason 'ip-config-unavailable', internal state 'managed')
Jun 12 10:05:03 localhost.localdomain NetworkManager[2215]: <info>  [1528819503.2448] manager: NetworkManager state is now DISCONNECTED
Jun 12 10:05:03 localhost.localdomain NetworkManager[2215]: <warn>  [1528819503.2452] device (eno1): Activation: failed for connection 'Wired connection 1'
Jun 12 10:05:03 localhost.localdomain NetworkManager[2215]: <info>  [1528819503.2460] device (eno1): state change: failed -> disconnected (reason 'none', internal state 'managed')
Jun 12 10:05:03 localhost.localdomain NetworkManager[2215]: <info>  [1528819503.2498] policy: auto-activating connection 'Wired connection 1'
Jun 12 10:05:03 localhost.localdomain NetworkManager[2215]: <info>  [1528819503.2517] device (eno1): Activation: starting connection 'Wired connection 1' (16a13ab5-c51e-361b-90bc-b6fc6f84cbe9)
Jun 12 10:05:03 localhost.localdomain NetworkManager[2215]: <info>  [1528819503.2520] device (eno1): state change: disconnected -> prepare (reason 'none', internal state 'managed')
Jun 12 10:05:03 localhost.localdomain NetworkManager[2215]: <info>  [1528819503.2523] manager: NetworkManager state is now CONNECTING
Jun 12 10:05:03 localhost.localdomain NetworkManager[2215]: <info>  [1528819503.2529] device (eno1): state change: prepare -> config (reason 'none', internal state 'managed')

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#1 lore raw
Quoted 9 lines · Keith Busch

My server's i40e no longer obtains an IP address on linux mainline. Bisected to the following:

commit cc5b114dcf986bfd8e4c37bf65d1b7b1e5290ac6

Author: Daniel Borkmann <[email protected]>
Date:   Mon May 28 11:07:20 2018 +0200

bpf, i40e: add meta data support

Quoted 8 lines

Reverting on mainline resolves the issue.

Is there something wrong with my i40e adapter, or is the patch possibly doing something wrong? Or any other information I can get to help understand why it's stopped working with this feature?

An excert from "journalctl -xe" on on the failing network adapter is below.

Thanks for the report & sorry for the issue, Keith! Instead of revert, could you give the below fix a try?

drivers/net/ethernet/intel/i40e/i40e_txrx.c +3 -4
index 8ffb745..ed6dbcf 100644
@@ -2103,9 +2103,8 @@ static struct sk_buff *i40e_build_skb(struct i40e_ring *rx_ring,
 	unsigned int truesize = i40e_rx_pg_size(rx_ring) / 2;
 #else
 	unsigned int truesize = SKB_DATA_ALIGN(sizeof(struct skb_shared_info)) +
-				SKB_DATA_ALIGN(I40E_SKB_PAD +
-					       (xdp->data_end -
-						xdp->data_hard_start));
+				SKB_DATA_ALIGN(xdp->data_end -
+					       xdp->data_hard_start);
 #endif
 	struct sk_buff *skb;
 
@@ -2124,7 +2123,7 @@ static struct sk_buff *i40e_build_skb(struct i40e_ring *rx_ring,
 		return NULL;
 
 	/* update pointers within the skb to store the data */
-	skb_reserve(skb, I40E_SKB_PAD + (xdp->data - xdp->data_hard_start));
+	skb_reserve(skb, xdp->data - xdp->data_hard_start);
 	__skb_put(skb, xdp->data_end - xdp->data);
 	if (metasize)
 		skb_metadata_set(skb, metasize);

Thanks,
Daniel

#2 lore raw

FYI, the list you're looking for is likely intel-wired-lan (added), not intel-gfx (removed).

BR,
Jani.

Quoted 54 lines · Daniel Borkmann
Quoted 9 lines · Keith Busch

My server's i40e no longer obtains an IP address on linux mainline. Bisected to the following:

commit cc5b114dcf986bfd8e4c37bf65d1b7b1e5290ac6

Author: Daniel Borkmann <[email protected]>
Date:   Mon May 28 11:07:20 2018 +0200

bpf, i40e: add meta data support

Quoted 8 lines

Reverting on mainline resolves the issue.

Is there something wrong with my i40e adapter, or is the patch possibly doing something wrong? Or any other information I can get to help understand why it's stopped working with this feature?

An excert from "journalctl -xe" on on the failing network adapter is below.

Thanks for the report & sorry for the issue, Keith! Instead of revert, could you give the below fix a try?

drivers/net/ethernet/intel/i40e/i40e_txrx.c +3 -4
index 8ffb745..ed6dbcf 100644
@@ -2103,9 +2103,8 @@ static struct sk_buff *i40e_build_skb(struct i40e_ring *rx_ring,
 	unsigned int truesize = i40e_rx_pg_size(rx_ring) / 2;
 #else
 	unsigned int truesize = SKB_DATA_ALIGN(sizeof(struct skb_shared_info)) +
-				SKB_DATA_ALIGN(I40E_SKB_PAD +
-					       (xdp->data_end -
-						xdp->data_hard_start));
+				SKB_DATA_ALIGN(xdp->data_end -
+					       xdp->data_hard_start);
 #endif
 	struct sk_buff *skb;
 
@@ -2124,7 +2123,7 @@ static struct sk_buff *i40e_build_skb(struct i40e_ring *rx_ring,
 		return NULL;
 
 	/* update pointers within the skb to store the data */
-	skb_reserve(skb, I40E_SKB_PAD + (xdp->data - xdp->data_hard_start));
+	skb_reserve(skb, xdp->data - xdp->data_hard_start);
 	__skb_put(skb, xdp->data_end - xdp->data);
 	if (metasize)
 		skb_metadata_set(skb, metasize);

Thanks,
Daniel
_______________________________________________
Intel-gfx mailing list
Intel-gfx at lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
#3 lore raw

✗ Fi.CI.BAT: failure for cc5b114dcf bpf, i40e: add meta data support

In reply to Keith Busch
== Series Details ==

== Series Details ==

Series: cc5b114dcf bpf, i40e: add meta data support
URL : https://patchwork.freedesktop.org/series/44753/
State : failure

== Summary ==

Applying: cc5b114dcf bpf, i40e: add meta data support
error: sha1 information is lacking or useless (drivers/net/ethernet/intel/i40e/i40e_txrx.c).
error: could not build fake ancestor
Patch failed at 0001 cc5b114dcf bpf, i40e: add meta data support
Use 'git am --show-current-patch' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx