Skip to contentSkip to conversation

xen: don't use privcmd_call() from xen_mc_flush()

PATCH Applied Juergen Gross 3 participants 16 messages Jun 13, 2018 – Aug 7, 2018 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

Juergen Gross

author maintainer
#0 lore raw

PATCH 1/1 xen: don't use privcmd_call() from xen_mc_flush()

Using privcmd_call() for a singleton multicall seems to be wrong, as privcmd_call() is using stac()/clac() to enable hypervisor access to Linux user space.

Add a new xen_single_call() function to be use for that purpose.

---
 arch/x86/include/asm/xen/hypercall.h | 25 +++++++++++++++++++------
 arch/x86/xen/multicalls.c            |  6 +++---
 2 files changed, 22 insertions(+), 9 deletions(-)
arch/x86/include/asm/xen/hypercall.h +19 -6
index bfd882617613..6b2f90a0b149 100644
@@ -209,24 +209,37 @@ extern struct { char _entry[32]; } hypercall_page[];
 })
 
 static inline long
-privcmd_call(unsigned call,
-	     unsigned long a1, unsigned long a2,
-	     unsigned long a3, unsigned long a4,
-	     unsigned long a5)
+xen_single_call(unsigned int call,
+		unsigned long a1, unsigned long a2,
+		unsigned long a3, unsigned long a4,
+		unsigned long a5)
 {
 	__HYPERCALL_DECLS;
 	__HYPERCALL_5ARG(a1, a2, a3, a4, a5);
 
-	stac();
 	asm volatile(CALL_NOSPEC
 		     : __HYPERCALL_5PARAM
 		     : [thunk_target] "a" (&hypercall_page[call])
 		     : __HYPERCALL_CLOBBER5);
-	clac();
 
 	return (long)__res;
 }
 
+static inline long
+privcmd_call(unsigned int call,
+	     unsigned long a1, unsigned long a2,
+	     unsigned long a3, unsigned long a4,
+	     unsigned long a5)
+{
+	long res;
+
+	stac();
+	res = xen_single_call(call, a1, a2, a3, a4, a5);
+	clac();
+
+	return res;
+}
+
 static inline int
 HYPERVISOR_set_trap_table(struct trap_info *table)
 {
arch/x86/xen/multicalls.c +3 -3
index dc502ca8263e..2bce7958ce8b 100644
@@ -80,9 +80,9 @@ void xen_mc_flush(void)
 		   and just do the call directly. */
 		mc = &b->entries[0];
 
-		mc->result = privcmd_call(mc->op,
-					  mc->args[0], mc->args[1], mc->args[2], 
-					  mc->args[3], mc->args[4]);
+		mc->result = xen_single_call(mc->op, mc->args[0], mc->args[1],
+					     mc->args[2], mc->args[3],
+					     mc->args[4]);
 		ret = mc->result < 0;
 		break;
 
Signature · 1 line
2.13.7
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines
Quoted 1 line
Quoted 1 line · On 13.06.18 at 11:58, <[email protected]> wrote:

Using privcmd_call() for a singleton multicall seems to be wrong, as privcmd_call() is using stac()/clac() to enable hypervisor access to Linux user space.

Add a new xen_single_call() function to be use for that purpose.

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

Reviewed-by on v1 1/1
#2 lore raw
In reply to Juergen Gross
Quoted 9 lines
Quoted 1 line
Quoted 1 line · On 13.06.18 at 11:58, <[email protected]> wrote:

Using privcmd_call() for a singleton multicall seems to be wrong, as privcmd_call() is using stac()/clac() to enable hypervisor access to Linux user space.

Add a new xen_single_call() function to be use for that purpose.

#3 lore raw
Quoted 6 lines
Quoted 6 lines
Quoted 2 lines · On 13.06.18 at 12:05, <[email protected]> wrote:
Quoted 1 line · On 13.06.18 at 11:58, <[email protected]> wrote:

Using privcmd_call() for a singleton multicall seems to be wrong, as privcmd_call() is using stac()/clac() to enable hypervisor access to Linux user space.

Quoted 6 lines
Quoted 4 lines

Add a new xen_single_call() function to be use for that purpose.

Actually I've only now realized that this isn't a real problem right now:
PV can't use SMAP (we don't provide a virtualized version of it), and HVM/PVH can't use multicalls (which may have to change for PVH Dom0, so having the change in place is helpful anyway), so the whole in-kernel logic to collect and issue batches should be unreachable there.

But perhaps the commit message would benefit from a little bit of re-wording.

Jan

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#4 lore raw
In reply to Jan Beulich
Quoted 6 lines
Quoted 6 lines
Quoted 2 lines · On 13.06.18 at 12:05, <[email protected]> wrote:
Quoted 1 line · On 13.06.18 at 11:58, <[email protected]> wrote:

Using privcmd_call() for a singleton multicall seems to be wrong, as privcmd_call() is using stac()/clac() to enable hypervisor access to Linux user space.

Quoted 6 lines
Quoted 4 lines

Add a new xen_single_call() function to be use for that purpose.

Actually I've only now realized that this isn't a real problem right now:
PV can't use SMAP (we don't provide a virtualized version of it), and HVM/PVH can't use multicalls (which may have to change for PVH Dom0, so having the change in place is helpful anyway), so the whole in-kernel logic to collect and issue batches should be unreachable there.

But perhaps the commit message would benefit from a little bit of re-wording.

Jan

A message that is not in the archive (sent off-list or not yet received): [email protected]

author maintainer
#6 lore raw
Quoted 13 lines · Jan Beulich
Quoted 6 lines
Quoted 6 lines
Quoted 2 lines · On 13.06.18 at 12:05, <[email protected]> wrote:
Quoted 1 line · On 13.06.18 at 11:58, <[email protected]> wrote:

Using privcmd_call() for a singleton multicall seems to be wrong, as privcmd_call() is using stac()/clac() to enable hypervisor access to Linux user space.

Quoted 6 lines
Quoted 4 lines

Add a new xen_single_call() function to be use for that purpose.

Quoted 8 lines

Actually I've only now realized that this isn't a real problem right now:
PV can't use SMAP (we don't provide a virtualized version of it), and HVM/PVH can't use multicalls (which may have to change for PVH Dom0, so having the change in place is helpful anyway), so the whole in-kernel logic to collect and issue batches should be unreachable there.

But perhaps the commit message would benefit from a little bit of re-wording.

Hmm, right.

What about:

"Using privcmd_call() for a singleton multicall seems to be wrong, as
privcmd_call() is using stac()/clac() to enable hypervisor access to Linux user space.

Even if currently not a problem (pv domains can't use SMAP while HVM and PVH domains can't use multicalls) things might change when PVH dom0 support is added to the kernel."

Juergen

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

author maintainer
#7 lore raw
In reply to a message not in the archive
Quoted 13 lines · Jan Beulich
Quoted 6 lines
Quoted 6 lines
Quoted 2 lines · On 13.06.18 at 12:05, <[email protected]> wrote:
Quoted 1 line · On 13.06.18 at 11:58, <[email protected]> wrote:

Using privcmd_call() for a singleton multicall seems to be wrong, as privcmd_call() is using stac()/clac() to enable hypervisor access to Linux user space.

Quoted 6 lines
Quoted 4 lines

Add a new xen_single_call() function to be use for that purpose.

Quoted 8 lines

Actually I've only now realized that this isn't a real problem right now:
PV can't use SMAP (we don't provide a virtualized version of it), and HVM/PVH can't use multicalls (which may have to change for PVH Dom0, so having the change in place is helpful anyway), so the whole in-kernel logic to collect and issue batches should be unreachable there.

But perhaps the commit message would benefit from a little bit of re-wording.

Hmm, right.

What about:

"Using privcmd_call() for a singleton multicall seems to be wrong, as
privcmd_call() is using stac()/clac() to enable hypervisor access to Linux user space.

Even if currently not a problem (pv domains can't use SMAP while HVM and PVH domains can't use multicalls) things might change when PVH dom0 support is added to the kernel."

Juergen

#8 lore raw
Quoted 28 lines
Quoted 1 line
Quoted 1 line · On 13.06.18 at 13:12, <[email protected]> wrote:
Quoted 13 lines · Jan Beulich
Quoted 6 lines
Quoted 6 lines
Quoted 2 lines · On 13.06.18 at 12:05, <[email protected]> wrote:
Quoted 1 line · On 13.06.18 at 11:58, <[email protected]> wrote:

Using privcmd_call() for a singleton multicall seems to be wrong, as privcmd_call() is using stac()/clac() to enable hypervisor access to Linux user space.

Quoted 6 lines
Quoted 4 lines

Add a new xen_single_call() function to be use for that purpose.

Quoted 8 lines

Actually I've only now realized that this isn't a real problem right now:
PV can't use SMAP (we don't provide a virtualized version of it), and HVM/PVH can't use multicalls (which may have to change for PVH Dom0, so having the change in place is helpful anyway), so the whole in-kernel logic to collect and issue batches should be unreachable there.

But perhaps the commit message would benefit from a little bit of re-wording.

Hmm, right.

What about:

Quoted 7 lines

"Using privcmd_call() for a singleton multicall seems to be wrong, as
privcmd_call() is using stac()/clac() to enable hypervisor access to Linux user space.

Even if currently not a problem (pv domains can't use SMAP while HVM and PVH domains can't use multicalls) things might change when PVH dom0 support is added to the kernel."

SGTM

Jan

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

author maintainer
#9 lore raw
In reply to Juergen Gross
Quoted 8 lines · Juergen Gross

Using privcmd_call() for a singleton multicall seems to be wrong, as privcmd_call() is using stac()/clac() to enable hypervisor access to Linux user space.

Add a new xen_single_call() function to be use for that purpose.

Boris, any objections?

Juergen

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#11 lore raw
Quoted 10 lines · Juergen Gross
Quoted 8 lines · Juergen Gross

Using privcmd_call() for a singleton multicall seems to be wrong, as privcmd_call() is using stac()/clac() to enable hypervisor access to Linux user space.

Add a new xen_single_call() function to be use for that purpose.

Boris, any objections?

I think Jan wanted a change in commit message. I can commit with this:

"Using privcmd_call() for a singleton multicall seems to be wrong, as
privcmd_call() is using stac()/clac() to enable hypervisor access to Linux user space.

Even if currently not a problem (pv domains can't use SMAP while HVM and PVH domains can't use multicalls) things might change when PVH dom0 support is added to the kernel."

-boris

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#12 lore raw
In reply to Juergen Gross
Quoted 10 lines · Juergen Gross
Quoted 8 lines · Juergen Gross

Using privcmd_call() for a singleton multicall seems to be wrong, as privcmd_call() is using stac()/clac() to enable hypervisor access to Linux user space.

Add a new xen_single_call() function to be use for that purpose.

Boris, any objections?

I think Jan wanted a change in commit message. I can commit with this:

"Using privcmd_call() for a singleton multicall seems to be wrong, as
privcmd_call() is using stac()/clac() to enable hypervisor access to Linux user space.

Even if currently not a problem (pv domains can't use SMAP while HVM and PVH domains can't use multicalls) things might change when PVH dom0 support is added to the kernel."

-boris

author maintainer
#13 lore raw
Quoted 15 lines · Boris Ostrovsky
Quoted 10 lines · Juergen Gross
Quoted 8 lines · Juergen Gross

Using privcmd_call() for a singleton multicall seems to be wrong, as privcmd_call() is using stac()/clac() to enable hypervisor access to Linux user space.

Add a new xen_single_call() function to be use for that purpose.

Boris, any objections?

I think Jan wanted a change in commit message. I can commit with this:

Quoted 7 lines

"Using privcmd_call() for a singleton multicall seems to be wrong, as
privcmd_call() is using stac()/clac() to enable hypervisor access to Linux user space.

Even if currently not a problem (pv domains can't use SMAP while HVM and PVH domains can't use multicalls) things might change when PVH dom0 support is added to the kernel."

This would be fine, thanks.

Juergen

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

author maintainer
#14 lore raw
In reply to Boris Ostrovsky
Quoted 15 lines · Boris Ostrovsky
Quoted 10 lines · Juergen Gross
Quoted 8 lines · Juergen Gross

Using privcmd_call() for a singleton multicall seems to be wrong, as privcmd_call() is using stac()/clac() to enable hypervisor access to Linux user space.

Add a new xen_single_call() function to be use for that purpose.

Boris, any objections?

I think Jan wanted a change in commit message. I can commit with this:

Quoted 7 lines

"Using privcmd_call() for a singleton multicall seems to be wrong, as
privcmd_call() is using stac()/clac() to enable hypervisor access to Linux user space.

Even if currently not a problem (pv domains can't use SMAP while HVM and PVH domains can't use multicalls) things might change when PVH dom0 support is added to the kernel."

This would be fine, thanks.

Juergen

reviewer Applied
#15 lore raw
Quoted 15 lines · Juergen Gross
Quoted 14 lines · Boris Ostrovsky
Quoted 10 lines · Juergen Gross
Quoted 8 lines · Juergen Gross

Using privcmd_call() for a singleton multicall seems to be wrong, as privcmd_call() is using stac()/clac() to enable hypervisor access to Linux user space.

Add a new xen_single_call() function to be use for that purpose.

Boris, any objections?

I think Jan wanted a change in commit message. I can commit with this:

Quoted 8 lines
Quoted 7 lines

"Using privcmd_call() for a singleton multicall seems to be wrong, as
privcmd_call() is using stac()/clac() to enable hypervisor access to Linux user space.

Even if currently not a problem (pv domains can't use SMAP while HVM and PVH domains can't use multicalls) things might change when PVH dom0 support is added to the kernel."

This would be fine, thanks.

Applied to for-linus-4.19

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

reviewer Applied
#16 lore raw
In reply to Juergen Gross
Quoted 15 lines · Juergen Gross
Quoted 14 lines · Boris Ostrovsky
Quoted 10 lines · Juergen Gross
Quoted 8 lines · Juergen Gross

Using privcmd_call() for a singleton multicall seems to be wrong, as privcmd_call() is using stac()/clac() to enable hypervisor access to Linux user space.

Add a new xen_single_call() function to be use for that purpose.

Boris, any objections?

I think Jan wanted a change in commit message. I can commit with this:

Quoted 8 lines
Quoted 7 lines

"Using privcmd_call() for a singleton multicall seems to be wrong, as
privcmd_call() is using stac()/clac() to enable hypervisor access to Linux user space.

Even if currently not a problem (pv domains can't use SMAP while HVM and PVH domains can't use multicalls) things might change when PVH dom0 support is added to the kernel."

This would be fine, thanks.

Applied to for-linus-4.19