drm/i915/perf: make oa format tables const
Subsystems (2)
PATCH 1/1 drm/i915/perf: make oa format tables const
No reason not to be const.
--- drivers/gpu/drm/i915/i915_perf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/i915_perf.c +2 -2
@@ -315,7 +315,7 @@ static u32 i915_oa_max_sample_rate = 100000;* code assumes all reports have a power-of-two size and ~(size - 1) can * be used as a mask to align the OA tail pointer. */ -static struct i915_oa_format hsw_oa_formats[I915_OA_FORMAT_MAX ] = { +static const struct i915_oa_format hsw_oa_formats[I915_OA_FORMAT_MAX ] = { [I915_OA_FORMAT_A13 ] = {0 ,64 }, [I915_OA_FORMAT_A29 ] = {1 ,128 }, [I915_OA_FORMAT_A13_B8_C8 ] = {2 ,128 },
@@ -326,7 +326,7 @@ static struct i915_oa_format hsw_oa_formats[I915_OA_FORMAT_MAX] = { [I915_OA_FORMAT_C4_B8] = { 7, 64 }, }; -static struct i915_oa_format gen8_plus_oa_formats[I915_OA_FORMAT_MAX ] = { +static const struct i915_oa_format gen8_plus_oa_formats[I915_OA_FORMAT_MAX ] = { [I915_OA_FORMAT_A12 ] = {0 ,64 }, [I915_OA_FORMAT_A12_B8_C8 ] = {2 ,128 }, [I915_OA_FORMAT_A32u40_A4u32_B8_C8] = {5 ,256 },
Signature · 6 lines
2.11.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 3 lines · Jani Nikula
No reason not to be const.
Signed-off-by Jani Nikula <[email protected]>
Quoted 18 lines
--- drivers/gpu/drm/i915/i915_perf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/i915_perf.c +1
-1@@ -315,7 +315,7 @@ static u32 i915_oa_max_sample_rate = 100000;* code assumes all reports have a power-of-two size and ~(size - 1) can * be used as a mask to align the OA tail pointer. */ -static struct i915_oa_format hsw_oa_formats[I915_OA_FORMAT_MAX ] = { +static const struct i915_oa_format hsw_oa_formats[I915_OA_FORMAT_MAX ] = { [I915_OA_FORMAT_A13 ] = {0 ,64 }, [I915_OA_FORMAT_A29 ] = {1 ,128 }, [I915_OA_FORMAT_A13_B8_C8 ] = {2 ,128 },
drivers/gpu/drm/i915/i915_perf.c static struct i915_oa_format hsw_oa_formats[I915_OA_FORMAT_MAX] = { · line 332
Quoted 8 lines
drivers/gpu/drm/i915/i915_perf.c +1
-1@@ -326,7 +326,7 @@ static struct i915_oa_format hsw_oa_formats[I915_OA_FORMAT_MAX] = { [I915_OA_FORMAT_C4_B8] = { 7, 64 }, }; -static struct i915_oa_format gen8_plus_oa_formats[I915_OA_FORMAT_MAX ] = { +static const struct i915_oa_format gen8_plus_oa_formats[I915_OA_FORMAT_MAX ] = { [I915_OA_FORMAT_A12 ] = {0 ,64 }, [I915_OA_FORMAT_A12_B8_C8 ] = {2 ,128 }, [I915_OA_FORMAT_A32u40_A4u32_B8_C8] = {5 ,256 },
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Jani Nikula
AppliedQuoted 6 lines · Lionel Landwerlin
Quoted 3 lines · Jani Nikula
No reason not to be const.
Signed-off-by Jani Nikula <[email protected]>Reviewed-by Lionel Landwerlin <[email protected]>
Pushed to dinq, thanks for the review.
BR,
Jani.
Quoted 29 lines
Quoted 27 lines
--- drivers/gpu/drm/i915/i915_perf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/i915_perf.c +2
-2@@ -315,7 +315,7 @@ static u32 i915_oa_max_sample_rate = 100000;* code assumes all reports have a power-of-two size and ~(size - 1) can * be used as a mask to align the OA tail pointer. */ -static struct i915_oa_format hsw_oa_formats[I915_OA_FORMAT_MAX ] = { +static const struct i915_oa_format hsw_oa_formats[I915_OA_FORMAT_MAX ] = { [I915_OA_FORMAT_A13 ] = {0 ,64 }, [I915_OA_FORMAT_A29 ] = {1 ,128 }, [I915_OA_FORMAT_A13_B8_C8 ] = {2 ,128 },@@ -326,7 +326,7 @@ static struct i915_oa_format hsw_oa_formats[I915_OA_FORMAT_MAX] = { [I915_OA_FORMAT_C4_B8] = { 7, 64 }, }; -static struct i915_oa_format gen8_plus_oa_formats[I915_OA_FORMAT_MAX ] = { +static const struct i915_oa_format gen8_plus_oa_formats[I915_OA_FORMAT_MAX ] = { [I915_OA_FORMAT_A12 ] = {0 ,64 }, [I915_OA_FORMAT_A12_B8_C8 ] = {2 ,128 }, [I915_OA_FORMAT_A32u40_A4u32_B8_C8] = {5 ,256 },
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915/perf: make oa format tables const
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm/i915/perf: make oa format tables const
URL : https://patchwork.freedesktop.org/series/44697/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4309 -> Patchwork_9286 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/44697/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_9286 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_ringfill@basic-default-hang:
fi-glk-j4005: PASS -> DMESG-WARN (fdo#105719)
igt@kms_flip@basic-flip-vs-dpms:
fi-glk-j4005: PASS -> DMESG-WARN (fdo#106000)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-snb-2520m: PASS -> INCOMPLETE (fdo#103713)
==== Possible fixes ====
igt@gem_exec_suspend@basic-s4-devices:
fi-kbl-7500u: DMESG-WARN (fdo#105128) -> PASS
igt@kms_pipe_crc_basic@read-crc-pipe-c:
fi-glk-j4005: DMESG-WARN (fdo#106097) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
fi-cnl-psr: DMESG-WARN (fdo#104951) -> PASS fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#104951 https://bugs.freedesktop.org/show_bug.cgi?id=104951
fdo#105128 https://bugs.freedesktop.org/show_bug.cgi?id=105128
fdo#105719 https://bugs.freedesktop.org/show_bug.cgi?id=105719
fdo#106000 https://bugs.freedesktop.org/show_bug.cgi?id=106000
fdo#106097 https://bugs.freedesktop.org/show_bug.cgi?id=106097
== Participating hosts (43 -> 38) ==
Missing (5): fi-ctg-p8600 fi-byt-squawks fi-ilk-m540 fi-bxt-dsi fi-bsw-cyan
== Build changes ==
* Linux: CI_DRM_4309 -> Patchwork_9286
CI_DRM_4309: 2740c5b0d0f40092355b329a62ede8cced7f64b9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4517: e94ce40798e35d2e3c4494f50b617908066bbf8b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9286: e9e26f1ea6e7cbad5132e9fcbc61672fb06172a5 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
e9e26f1ea6e7 drm/i915/perf: make oa format tables const
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9286/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for drm/i915/perf: make oa format tables const
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm/i915/perf: make oa format tables const
URL : https://patchwork.freedesktop.org/series/44697/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4309_full -> Patchwork_9286_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_9286_full need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_9286_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_9286_full:
=== IGT changes ===
==== Warnings ====
igt@gem_exec_schedule@deep-bsd1:
shard-kbl: PASS -> SKIP +1== Known issues ==
Here are the changes found in Patchwork_9286_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@mock_scatterlist:
shard-glk: NOTRUN -> DMESG-WARN (fdo#103667)
igt@gem_exec_big:
shard-hsw: PASS -> INCOMPLETE (fdo#103540)
igt@gem_exec_schedule@pi-ringfull-bsd:
shard-glk: NOTRUN -> FAIL (fdo#103158)
igt@gem_mmap_gtt@coherency:
shard-glk: NOTRUN -> FAIL (fdo#100587)
igt@gem_ppgtt@blt-vs-render-ctxn:
shard-kbl: PASS -> INCOMPLETE (fdo#106023, fdo#103665)
igt@kms_cursor_legacy@cursor-vs-flip-toggle:
shard-hsw: PASS -> FAIL (fdo#103355)
igt@kms_flip@2x-plain-flip-ts-check-interruptible:
shard-hsw: PASS -> FAIL (fdo#100368)
igt@kms_flip@flip-vs-expired-vblank-interruptible:
shard-glk: PASS -> FAIL (fdo#105363)
igt@kms_flip@plain-flip-fb-recreate-interruptible:
shard-glk: PASS -> FAIL (fdo#100368)
igt@kms_flip_tiling@flip-to-y-tiled:
shard-glk: NOTRUN -> FAIL (fdo#104724)
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-mmap-wc:
shard-glk: NOTRUN -> FAIL (fdo#103167, fdo#104724)
igt@kms_setmode@basic:
shard-glk: NOTRUN -> FAIL (fdo#99912)
igt@kms_sysfs_edid_timing:
shard-glk: NOTRUN -> WARN (fdo#100047)
igt@perf_pmu@busy-accuracy-50-vcs1:
shard-snb: SKIP -> INCOMPLETE (fdo#105411)
==== Possible fixes ====
igt@kms_atomic_transition@1x-modeset-transitions-nonblocking-fencing:
shard-glk: FAIL (fdo#105703) -> PASS
igt@kms_flip@2x-flip-vs-expired-vblank:
shard-glk: FAIL (fdo#105363) -> PASS
igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
shard-hsw: FAIL (fdo#102887) -> PASS
igt@kms_flip@flip-vs-expired-vblank-interruptible:
shard-hsw: FAIL (fdo#102887, fdo#105363) -> PASS
igt@kms_flip_tiling@flip-to-x-tiled:
shard-glk: FAIL (fdo#103822, fdo#104724) -> PASS
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-plflip-blt:
shard-glk: FAIL (fdo#103167, fdo#104724) -> PASS
igt@kms_rotation_crc@primary-rotation-180:
shard-snb: FAIL (fdo#103925, fdo#104724) -> SKIP fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#100587 https://bugs.freedesktop.org/show_bug.cgi?id=100587
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#103158 https://bugs.freedesktop.org/show_bug.cgi?id=103158
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103355 https://bugs.freedesktop.org/show_bug.cgi?id=103355
fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103667 https://bugs.freedesktop.org/show_bug.cgi?id=103667
fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822
fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#105703 https://bugs.freedesktop.org/show_bug.cgi?id=105703
fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4309 -> Patchwork_9286
CI_DRM_4309: 2740c5b0d0f40092355b329a62ede8cced7f64b9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4517: e94ce40798e35d2e3c4494f50b617908066bbf8b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9286: e9e26f1ea6e7cbad5132e9fcbc61672fb06172a5 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9286/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx