Skip to contentSkip to conversation

firmware: Update Kconfig help text for Google firmware

PATCH Superseded Ben Hutchings 2 participants 3 messages Jun 16, 2018 – Jun 18, 2018

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 firmware: Update Kconfig help text for Google firmware

The help text for GOOGLE_FIRMWARE states that it should only be enabled when building a kernel for Google's own servers. However, it is now also a dependency for various Chromebook firmware drivers.

Update the help text to reflect this double duty. Add the qualifier "server" to the help text for GOOGLE_SMI, which doesn't appear to be useful on Chromebooks.

Fixes d384d6f43d1e ("firmware: google memconsole: Add coreboot support")
---
 drivers/firmware/google/Kconfig | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)
drivers/firmware/google/Kconfig +4 -5
index f16b381a569c..6fda2c5c69e4 100644
@@ -2,9 +2,8 @@ menuconfig GOOGLE_FIRMWARE
 	bool "Google Firmware Drivers"
 	default n
 	help
-	  These firmware drivers are used by Google's servers.  They are
-	  only useful if you are working directly on one of their
-	  proprietary servers.  If in doubt, say "N".
+	  These firmware drivers are used by Google servers and
+	  Chromebooks.  If in doubt, say "N".
 
 if GOOGLE_FIRMWARE
 
@@ -14,8 +13,8 @@ config GOOGLE_SMI
 	select EFI_VARS
 	help
 	  Say Y here if you want to enable SMI callbacks for Google
-	  platforms.  This provides an interface for writing to and
-	  clearing the EFI event log and reading and writing NVRAM
+	  server platforms.  This provides an interface for writing to
+	  and clearing the EFI event log and reading and writing NVRAM
 	  variables.
 
 config GOOGLE_COREBOOT_TABLE
#1 lore raw
Quoted 20 lines · Ben Hutchings

The help text for GOOGLE_FIRMWARE states that it should only be enabled when building a kernel for Google's own servers. However, it is now also a dependency for various Chromebook firmware drivers.

Update the help text to reflect this double duty. Add the qualifier "server" to the help text for GOOGLE_SMI, which doesn't appear to be useful on Chromebooks.

Fixes d384d6f43d1e ("firmware: google memconsole: Add coreboot support")
---
 drivers/firmware/google/Kconfig | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)
drivers/firmware/google/Kconfig +0 -0
index f16b381a569c..6fda2c5c69e4 100644

drivers/firmware/google/Kconfig menuconfig GOOGLE_FIRMWARE · line 6

Quoted 8 lines
drivers/firmware/google/Kconfig +2 -3
@@ -2,9 +2,8 @@ menuconfig GOOGLE_FIRMWARE
        bool "Google Firmware Drivers"
        default n
        help
-         These firmware drivers are used by Google's servers.  They are
-         only useful if you are working directly on one of their
-         proprietary servers.  If in doubt, say "N".
+         These firmware drivers are used by Google servers and
+         Chromebooks.  If in doubt, say "N".

nit: Technically, most of the stuff is useful on all coreboot devices, not just Chromebooks. (Ideally we'd want to factor that out into a separate drivers/firmware/coreboot, but it's a bit tricky because the same memconsole frontend is used for both coreboot and a proprietary Google server BIOS, so it's a little tricky to decide where everything should go. Nobody had the time to go untangle it yet.)

drivers/firmware/google/Kconfig config GOOGLE_SMI · line 18

Quoted 11 lines
drivers/firmware/google/Kconfig +2 -2
 if GOOGLE_FIRMWARE
 
@@ -14,8 +13,8 @@ config GOOGLE_SMI
        select EFI_VARS
        help
          Say Y here if you want to enable SMI callbacks for Google
-         platforms.  This provides an interface for writing to and
-         clearing the EFI event log and reading and writing NVRAM
+         server platforms.  This provides an interface for writing to
+         and clearing the EFI event log and reading and writing NVRAM
          variables.

GSMI is also used by Chromebooks AFAIK. (I think it's sort of become a general coreboot interface by now as well, although the name still says Google.)

#2 lore raw

On Mon, 2018-06-18 at 13:04 -0700, Julius Werner wrote:
[...]

Quoted 6 lines

nit: Technically, most of the stuff is useful on all coreboot devices, not just Chromebooks. (Ideally we'd want to factor that out into a separate drivers/firmware/coreboot, but it's a bit tricky because the same memconsole frontend is used for both coreboot and a proprietary Google server BIOS, so it's a little tricky to decide where everything should go. Nobody had the time to go untangle it yet.)

[...]

Quoted 3 lines

GSMI is also used by Chromebooks AFAIK. (I think it's sort of become a general coreboot interface by now as well, although the name still says Google.)

OK, I'll send a v2 to fix these.

Ben.

Signature · 3 lines
Ben Hutchings
I'm not a reverse psychological virus.
Please don't copy me into your signature.