thunderbolt: Notify userspace when boot_acl is changed
PATCH 1/1 thunderbolt: Notify userspace when boot_acl is changed
The commit 9aaa3b8b4c56 ("thunderbolt: Add support for preboot ACL") introduced boot_acl attribute but missed the fact that now userspace needs to poll the attribute constantly to find out whether it has changed or not. Fix this by sending notification to the userspace whenever the boot_acl attribute is changed.
--- drivers/thunderbolt/domain.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/thunderbolt/domain.c +4 -0
@@ -213,6 +213,10 @@ static ssize_t boot_acl_store(struct device *dev, struct device_attribute *attr, goto err_free_acl; } ret = tb->cm_ops->set_boot_acl (tb, acl, tb->nboot_acl); +if (!ret) { +/* Notify userspace about the change */ +kobject_uevent (&tb->dev.kobj,KOBJ_CHANGE ); + }mutex_unlock (&tb->lock); err_free_acl:
Signature · 1 line
2.17.1
Quoted 30 lines · Mika Westerberg
The commit
9aaa3b8b4c56("thunderbolt: Add support for preboot ACL") introducedboot_aclattribute but missed the fact that now userspace needs to poll the attribute constantly to find out whether it has changed or not. Fix this by sending notification to the userspace whenever theboot_aclattribute is changed.Fixes 9aaa3b8b4c56 ("thunderbolt: Add support for preboot ACL")Reported-by Christian Kellner <[email protected]>Signed-off-by Mika Westerberg <[email protected]>--- drivers/thunderbolt/domain.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/thunderbolt/domain.c +4
-1@@ -213,6 +213,10 @@ static ssize_t boot_acl_store(struct device *dev, struct device_attribute *attr, goto err_free_acl; } ret = tb->cm_ops->set_boot_acl (tb, acl, tb->nboot_acl); +if (!ret) { +/* Notify userspace about the change */ +kobject_uevent (&tb->dev.kobj,KOBJ_CHANGE ); + }mutex_unlock (&tb->lock); err_free_acl: --
Quoted 2 lines
2.17.1
Mika Westerberg
AppliedQuoted 9 lines · Mika Westerberg
The commit
9aaa3b8b4c56("thunderbolt: Add support for preboot ACL") introducedboot_aclattribute but missed the fact that now userspace needs to poll the attribute constantly to find out whether it has changed or not. Fix this by sending notification to the userspace whenever theboot_aclattribute is changed.Fixes 9aaa3b8b4c56 ("thunderbolt: Add support for preboot ACL")Reported-by Christian Kellner <[email protected]>Signed-off-by Mika Westerberg <[email protected]>
Applied to thunderbolt.git/fixes.