nvme_fc: release io queues to allow fast fail
Subsystems (2)
PATCH 1/1 nvme_fc: release io queues to allow fast fail
Rather than leaving io queues quiesced after tearing down an association, restart them. This allows ios to be replayed, with fastfail ios terminating and non-fastfail getting into loops of retry.
This follows rdma's lead.
Signed-off-by James Smart <james.smart at broadcom.com>
--- drivers/nvme/host/fc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/nvme/host/fc.c +3 -3
@@ -2790,6 +2790,9 @@ nvme_fc_delete_association(struct nvme_fc_ctrl *ctrl)/* re-enable the admin_q so anything new can fast fail */ blk_mq_unquiesce_queue (ctrl->ctrl.admin_q); +/* resume the io queues so that things will fast fail */ +nvme_start_queues (&ctrl->ctrl); +nvme_fc_ctlr_inactive_on_rport (ctrl); }
@@ -2804,9 +2807,6 @@ nvme_fc_delete_ctrl(struct nvme_ctrl *nctrl)* waiting for io to terminate */ nvme_fc_delete_association (ctrl); - -/* resume the io queues so that things will fast fail */ -nvme_start_queues (nctrl); } static void
Signature · 1 line
2.13.1
Sagi Grimberg
maintainerPATCH 1/1 nvme_fc: release io queues to allow fast fail
Reviewed-by Sagi Grimberg <sagi at grimber.me>
Christoph Hellwig
AppliedPATCH 1/1 nvme_fc: release io queues to allow fast fail
In reply to James SmartThanks,
applied to nvme-4.18.