drm/i915: Remove pointless if-else from sdvo code
Subsystems (2)
PATCH 1/1 drm/i915: Remove pointless if-else from sdvo code
From: Ville Syrjälä <[email protected]>
The return value is a bool so we can just return the result of the biwise AND. The compiler will take care of the rest.
--- drivers/gpu/drm/i915/intel_sdvo.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/gpu/drm/i915/intel_sdvo.c +1 -4
@@ -1400,10 +1400,7 @@ static bool intel_sdvo_connector_get_hw_state(struct intel_connector *connector)intel_sdvo_get_active_outputs (intel_sdvo, &active_outputs); -if (active_outputs & intel_sdvo_connector->output_flag) -return true; -else -return false; +return active_outputs & intel_sdvo_connector->output_flag; } bool intel_sdvo_port_enabled(struct drm_i915_private *dev_priv,
Signature · 6 lines
2.16.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Remove pointless if-else from sdvo code
== Series Details ==
== Series Details ==
Series: drm/i915: Remove pointless if-else from sdvo code
URL : https://patchwork.freedesktop.org/series/45189/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4362 -> Patchwork_9387 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/45189/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_9387 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_gttfill@basic:
fi-byt-n2820: PASS -> FAIL (fdo#106744)
==== Possible fixes ====
igt@gem_ctx_create@basic-files:
fi-skl-6700k2: INCOMPLETE (fdo#106988) -> PASS
igt@prime_vgem@basic-fence-flip:
fi-ilk-650: FAIL (fdo#104008) -> PASS fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fdo#106744 https://bugs.freedesktop.org/show_bug.cgi?id=106744
fdo#106988 https://bugs.freedesktop.org/show_bug.cgi?id=106988
== Participating hosts (42 -> 37) ==
Additional (1): fi-bxt-dsi
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-glk-dsi fi-bsw-cyan fi-ctg-p8600 fi-kbl-x1275
== Build changes ==
* Linux: CI_DRM_4362 -> Patchwork_9387
CI_DRM_4362: 7159c27349b070831dfb3512ca055c8dbcf9e1fc @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4528: 6be300d405de5974b262e8b93a445be4ac618e6a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9387: 4f50b56b76e1d57ecedeb6325f6cf3cbdb98ea46 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
4f50b56b76e1 drm/i915: Remove pointless if-else from sdvo code
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9387/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Ville Syrjala (2018-06-21 18:46:58)
Quoted 6 lines
From: Ville Syrjälä <[email protected]>
The return value is a bool so we can just return the result of the biwise AND. The compiler will take care of the rest.
Signed-off-by Ville Syrjälä <[email protected]>
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for drm/i915: Remove pointless if-else from sdvo code
In reply to Ville Syrjala== Series Details ==
== Series Details ==
Series: drm/i915: Remove pointless if-else from sdvo code
URL : https://patchwork.freedesktop.org/series/45189/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4362_full -> Patchwork_9387_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_9387_full need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_9387_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_9387_full:
=== IGT changes ===
==== Warnings ====
igt@pm_rc6_residency@rc6-accuracy:
shard-kbl: SKIP -> PASS +1== Known issues ==
Here are the changes found in Patchwork_9387_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_hangcheck:
shard-kbl: PASS -> DMESG-FAIL (fdo#106560, fdo#106947)
shard-apl: PASS -> DMESG-FAIL (fdo#106560, fdo#106947)
igt@gem_workarounds@suspend-resume-context:
shard-apl: PASS -> FAIL (fdo#103375)
igt@kms_flip_tiling@flip-x-tiled:
shard-glk: PASS -> FAIL (fdo#104724)
==== Possible fixes ====
igt@drv_selftest@live_gtt:
shard-glk: FAIL (fdo#105347) -> PASS
igt@kms_flip@dpms-vs-vblank-race:
shard-kbl: FAIL (fdo#103060) -> PASS
igt@kms_setmode@basic:
shard-apl: FAIL (fdo#99912) -> PASS fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
fdo#105347 https://bugs.freedesktop.org/show_bug.cgi?id=105347
fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
fdo#106947 https://bugs.freedesktop.org/show_bug.cgi?id=106947
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4362 -> Patchwork_9387
CI_DRM_4362: 7159c27349b070831dfb3512ca055c8dbcf9e1fc @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4528: 6be300d405de5974b262e8b93a445be4ac618e6a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9387: 4f50b56b76e1d57ecedeb6325f6cf3cbdb98ea46 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9387/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx