Skip to contentSkip to conversation

arm, imx6: fix NOR/OneNAND boot mode mix-up

PATCH New Jay Carlson 2 participants 2 messages Jun 22, 2018 – Jul 23, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 arm, imx6: fix NOR/OneNAND boot mode mix-up

This patch fixes the ordering of the EMI enum to match Table 8-8 in the i.MX6ULL Reference Manual, and has been spot-checked in two other i.MX reference manuals for accuracy.

---
 arch/arm/include/asm/mach-imx/sys_proto.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/include/asm/mach-imx/sys_proto.h +1 -1
index d1d6cbc462..0acc3640f9 100644
@@ -63,8 +63,8 @@ enum imx6_bmode_serial_rom {
 };
 
 enum imx6_bmode_emi {
-	IMX6_BMODE_ONENAND,
 	IMX6_BMODE_NOR,
+	IMX6_BMODE_ONENAND
 };
 
 enum imx6_bmode {
Signature · 1 line
2.16.1.windows.4
#1 lore raw

PATCH v2 1/1 arm, imx6: fix NOR/OneNAND boot mode mix-up

Hi Jay,

Quoted 14 lines · Jay Carlson

This patch fixes the ordering of the EMI enum to match Table 8-8 in the i.MX6ULL Reference Manual, and has been spot-checked in two other i.MX reference manuals for accuracy.

---
 arch/arm/include/asm/mach-imx/sys_proto.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/include/asm/mach-imx/sys_proto.h +0 -0
index d1d6cbc462..0acc3640f9 100644

arch/arm/include/asm/mach-imx/sys_proto.h enum imx6_bmode_serial_rom { · line 69

Quoted 8 lines
arch/arm/include/asm/mach-imx/sys_proto.h +1 -1
@@ -63,8 +63,8 @@ enum imx6_bmode_serial_rom {
 };
 
 enum imx6_bmode_emi {
-	IMX6_BMODE_ONENAND,
 	IMX6_BMODE_NOR,
+	IMX6_BMODE_ONENAND
 };
 

I am not understanding which is the issue. The enum are just used in switch() section as far as I know, and then the order is not so important. Which is the issue / error you found ?

Best regards,
Stefano babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================