Skip to contentSkip to conversation

reiserfs: change j_timestamp type to time64_t

PATCH New Arnd Bergmann 1 participant 1 message Jun 22, 2018

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 reiserfs: change j_timestamp type to time64_t

This uses the deprecated time_t type but is write-only, and could be removed, but as Jeff explains, having a timestamp can be usefule for post-mortem analysis in crash dumps.

In order to remove one of the last instances of time_t, this changes the type to time64_t, same as j_trans_start_time.

---
This could replace "reiserfs: remove unused j_timestamp" if we decide that we want to keep that variable.

Posting this patch as an alternative now, while waiting for Jeff to reply on how important this really is.

---
 fs/reiserfs/reiserfs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/reiserfs/reiserfs.h +1 -1
index 621b9a07080a..e5ca9ed79e54 100644
@@ -271,7 +271,7 @@ struct reiserfs_journal_list {
 
 	struct mutex j_commit_mutex;
 	unsigned int j_trans_id;
-	time_t j_timestamp;
+	time64_t j_timestamp; /* write-only but useful for crash dump analysis */
 	struct reiserfs_list_bitmap *j_list_bitmap;
 	struct buffer_head *j_commit_bh;	/* commit buffer head */
 	struct reiserfs_journal_cnode *j_realblock;
Signature · 1 line
2.9.0