btrfs/149: don't run if PAGE_SIZE > 4096
PATCH 1/1 btrfs/149: don't run if PAGE_SIZE > 4096
The test assumes a 4K block size and fails on larger block sizes - the extent layout will not match and the reflink command will fail.
Signed-off-by Mark Fasheh <[email protected]>
--- tests/btrfs/149 | 6 ++++++ 1 file changed, 6 insertions(+)
tests/btrfs/149 +6 -0
@@ -37,6 +37,12 @@ _require_scratch _require_scratch_reflink _require_odirect +# Test output will not match results if page size > 4096 +PAGE_SIZE=`getconf PAGE_SIZE` +if [ $PAGE_SIZE -gt 4096 ]; then + _notrun "Not supported with page size > 4096" +fi + send_files_dir=$TEST_DIR/btrfs-test-$seq rm -f $seqres.full
Signature · 1 line
2.15.1
Quoted 2 lines · Mark Fasheh
The test assumes a 4K block size and fails on larger block sizes - the extent layout will not match and the reflink command will fail.
The usual way of fixing this is it use 64k sizes and offsets for IO rather than 4k, and change the output to match. That way the test should behave the same across all supported block and page sizes.
Quoted 11 lines
Signed-off-by Mark Fasheh <[email protected]>--- tests/btrfs/149 | 6 ++++++ 1 file changed, 6 insertions(+)tests/btrfs/149 +0
-0
tests/btrfs/149 _require_scratch · line 44
Quoted 8 lines
tests/btrfs/149 +5
-0@@ -37,6 +37,12 @@ _require_scratch _require_scratch_reflink _require_odirect +# Test output will not match results if page size > 4096 +PAGE_SIZE=`getconf PAGE_SIZE` +if [ $PAGE_SIZE -gt 4096 ]; then + _notrun "Not supported with page size > 4096" +fi
FWIW, the commi description talks about block sizes - this tests the machien page size, not the filesystem block size....
Cheers,
Dave.
Signature · 2 lines
Dave Chinner [email protected]