Skip to contentSkip to conversation

tracing: Use swap macro in update_max_tr

PATCH New Steven Rostedt 1 participant 1 message Jun 23, 2018 Tracing

lore
Share & tools
lore

Steven Rostedt

author maintainer
#0 lore raw

PATCH 3/5 tracing: Use swap macro in update_max_tr

From: "Gustavo A. R. Silva" <[email protected]>

Make use of the swap macro and remove unnecessary variable _buf_. This makes the code easier to read and maintain. Also, reduces the stack usage.

This code was detected with the help of Coccinelle.

Link http://lkml.kernel.org/r/20180209175316.GA18720@embeddedgus open here
Signed-off-by Gustavo A. R. Silva <[email protected]>
Signed-off-by Steven Rostedt (VMware) <[email protected]>
---
 kernel/trace/trace.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
kernel/trace/trace.c +1 -5
index c9336e98ac59..a0079b4c7a49 100644
@@ -1360,8 +1360,6 @@ __update_max_tr(struct trace_array *tr, struct task_struct *tsk, int cpu)
 void
 update_max_tr(struct trace_array *tr, struct task_struct *tsk, int cpu)
 {
-	struct ring_buffer *buf;
-
 	if (tr->stop_count)
 		return;
 

@@ -1375,9 +1373,7 @@ update_max_tr(struct trace_array *tr, struct task_struct *tsk, int cpu)
 
 	arch_spin_lock(&tr->max_lock);
 
-	buf = tr->trace_buffer.buffer;
-	tr->trace_buffer.buffer = tr->max_buffer.buffer;
-	tr->max_buffer.buffer = buf;
+	swap(tr->trace_buffer.buffer, tr->max_buffer.buffer);
 
 	__update_max_tr(tr, tsk, cpu);
 	arch_spin_unlock(&tr->max_lock);
Signature · 1 line
2.17.1