Skip to contentSkip to conversation

USB: serial: ftdi_sio: Add MTP NVM support

PATCH Superseded Johan Hovold 1 participant 1 message Jun 25, 2018 USB

v3 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 USB: serial: ftdi_sio: Add MTP NVM support

Quoted 15 lines · Loic Poulain

Hi Andy,

Quoted 7 lines · Andy Shevchenko

Review

Quoted 2 lines · Loic Poulain
(quoted diff) +2 -0
+#define EEPROM_SZ_FTX 2048 /* cf FTDI AN_201 */
+#define EEPROM_SZ_FT232RL 128  /* cf FTDI AN_121 */

These defines looks too particular, shouldn't be this a part of driver data / platform data / device properties?

I'm not sure where to move this since it depends on chip type which is detected at runtime. I don't think ftdi_sio_quirk is the right place. So maybe I could just skip the defines for now and come back to:

Quoted 5 lines
switch (priv->chip_type) {
    case FTX:
        nvmconf.size = SZ_2K;
        break;

...

Yes, please do that. The EEPROM_SZ_ defines you added in this (?) revision add no value.

Thanks,
Johan
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html