Skip to contentSkip to conversation

drm/gma500: Fix compile warning

PATCH In review Gustavo A. R. Silva 2 participants 3 messages Jun 25, 2018 – Jun 26, 2018

Subsystems (3)
DRM drivers DRM misc DRM drivers for GMA500 (Poulsbo, Moorestown and derivative chipsets)
lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 drm/gma500: Fix compile warning

Fix the following compile warning:

warning: unused variable ‘psbfb’ [-Wunused-variable]
struct psb_framebuffer *psbfb = to_psb_fb(fb);

Fixes c7cbed560ce2 ("drm/gma500: Fix Medfield for drm_framebuffer move")
Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/gpu/drm/gma500/mdfld_intel_display.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/gma500/mdfld_intel_display.c +0 -1
index 881d613..2b9fa01 100644
@@ -167,7 +167,6 @@ static int mdfld__intel_pipe_set_base(struct drm_crtc *crtc, int x, int y,
 	struct drm_psb_private *dev_priv = dev->dev_private;
 	struct drm_framebuffer *fb = crtc->primary->fb;
 	struct gma_crtc *gma_crtc = to_gma_crtc(crtc);
-	struct psb_framebuffer *psbfb = to_psb_fb(fb);
 	int pipe = gma_crtc->pipe;
 	const struct psb_offset *map = &dev_priv->regmap[pipe];
 	unsigned long start, offset;
Signature · 1 line
2.7.4
#1 lore raw
Quoted 7 lines · Gustavo A. R. Silva

Fix the following compile warning:

warning: unused variable ‘psbfb’ [-Wunused-variable]
struct psb_framebuffer *psbfb = to_psb_fb(fb);

Fixes c7cbed560ce2 ("drm/gma500: Fix Medfield for drm_framebuffer move")
Signed-off-by Gustavo A. R. Silva <[email protected]>

I sent the same patch a few days ago. Instead of hunting for an r-b I just went ahead and pushed your version. Thanks for the patch.

Quoted 23 lines
---
 drivers/gpu/drm/gma500/mdfld_intel_display.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/gma500/mdfld_intel_display.c +0 -1
index 881d613..2b9fa01 100644
@@ -167,7 +167,6 @@ static int mdfld__intel_pipe_set_base(struct drm_crtc *crtc, int x, int y,
 	struct drm_psb_private *dev_priv = dev->dev_private;
 	struct drm_framebuffer *fb = crtc->primary->fb;
 	struct gma_crtc *gma_crtc = to_gma_crtc(crtc);
-	struct psb_framebuffer *psbfb = to_psb_fb(fb);
 	int pipe = gma_crtc->pipe;
 	const struct psb_offset *map = &dev_priv->regmap[pipe];
 	unsigned long start, offset;
Signature · 6 lines
2.7.4

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 6 lines
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
author
#2 lore raw
Quoted 12 lines · Ville Syrjälä
Quoted 7 lines · Gustavo A. R. Silva

Fix the following compile warning:

warning: unused variable ‘psbfb’ [-Wunused-variable]
struct psb_framebuffer *psbfb = to_psb_fb(fb);

Fixes c7cbed560ce2 ("drm/gma500: Fix Medfield for drm_framebuffer move")
Signed-off-by Gustavo A. R. Silva <[email protected]>

I sent the same patch a few days ago. Instead of hunting for an r-b I just went ahead and pushed your version. Thanks for the patch.

Glad to help :)

Thanks
--
Gustavo