potential bufferovflows in drivers/s390/crypto/
Quoted 10 lines · Heiko Carstens
Quoted 6 lines · Georgi Guninski
Quoted 3 lines · Heiko Carstens
This is actually already the third time that somebody reports a potential buffer overflow for this function. Could you please add a comment in the code to avoid future confusion?
This also confuses static analyzers and they don't read comments. In one of the functions (alive in kernel 3.20) adding check is possible.
Adding an extra, but superfluous, check would be fine with me as well. Given that it is obviously non-trivial to tell that this code isn't broken.
I'll add checks and comments. However, I will not do any backports for older kernels.