wlcore: Fix memory leak in wlcore_cmd_wait_for_event_or_timeout

In case memory resources for *events_vector* were allocated, release them before return.

Addresses-Coverity-ID: 1470194 ("Resource leak")

Fixes 4ec7cece87b3 ("wlcore: Add missing PM call for wlcore_cmd_wait_for_event_or_timeout()")

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
 drivers/net/wireless/ti/wlcore/cmd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/net/wireless/ti/wlcore/cmd.c +2 -2

index 836c616..9039687 100644
@@ -195,8 +195,7 @@ int wlcore_cmd_wait_for_event_or_timeout(struct wl1271 *wl,
 	ret = pm_runtime_get_sync(wl->dev);
 	if (ret < 0) {
 		pm_runtime_put_noidle(wl->dev);
-
-		return ret;
+		goto free_vector;
 	}
 
 	do {

@@ -232,6 +231,7 @@ int wlcore_cmd_wait_for_event_or_timeout(struct wl1271 *wl,
 out:
 	pm_runtime_mark_last_busy(wl->dev);
 	pm_runtime_put_autosuspend(wl->dev);
+free_vector:
 	kfree(events_vector);
 	return ret;
 }

Signature · 1 line

2.7.4

Quoted 3 lines · Gustavo A. R. Silva

In case memory resources for *events_vector* were allocated, release them before return.

Quoted 3 lines

Addresses-Coverity-ID: 1470194 ("Resource leak")

Fixes 4ec7cece87b3 ("wlcore: Add missing PM call for wlcore_cmd_wait_for_event_or_timeout()")

Signed-off-by Gustavo A. R. Silva <[email protected]>

Thanks for catching this one:

Acked-by Tony Lindgren <[email protected]>

In case memory resources for *events_vector* were allocated, release them before return.

Addresses-Coverity-ID: 1470194 ("Resource leak")

Fixes 4ec7cece87b3 ("wlcore: Add missing PM call for wlcore_cmd_wait_for_event_or_timeout()")

Signed-off-by Gustavo A. R. Silva <[email protected]>

Acked-by Tony Lindgren <[email protected]>