Skip to contentSkip to conversation

USB: musb: mark expected switch fall-throughs

PATCH New Gustavo A. R. Silva 1 participant 1 message Jun 28, 2018

Subsystems (2)
USB MUSB multipoint high speed dual-role controller
lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 USB: musb: mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/usb/musb/musb_dsps.c | 2 +-
 drivers/usb/musb/musb_host.c | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
drivers/usb/musb/musb_dsps.c +1 -1
index fb871ea..df827ff 100644
@@ -237,7 +237,7 @@ static int dsps_check_status(struct musb *musb, void *unused)
 		}
 		musb_writeb(musb->mregs, MUSB_DEVCTL, 0);
 		skip_session = 1;
-		/* fall */
+		/* fall through */
 
 	case OTG_STATE_A_IDLE:
 	case OTG_STATE_B_IDLE:
drivers/usb/musb/musb_host.c +1 -0
index 8000c7c..b59ce9a 100644
@@ -378,6 +378,7 @@ static void musb_advance_schedule(struct musb *musb, struct urb *urb,
 				qh = first_qh(head);
 				break;
 			}
+			/* else: fall through */
 
 		case USB_ENDPOINT_XFER_ISOC:
 		case USB_ENDPOINT_XFER_INT: