tests/migration: Skip tests for ppc tcg
PATCH 1/1 tests/migration: Skip tests for ppc tcg
From: "Dr. David Alan Gilbert" <[email protected]>
PPC tcg seems to be failing migration tests quite regularly; we believe this is TCG bugs in dirty bit updating; it's not clear why PPC fails more but lets skip for the moment.
$ ./tests/migration-test /ppc64/migration/deprecated: OK /ppc64/migration/bad_dest: SKIP /ppc64/migration/postcopy/unix: SKIP /ppc64/migration/precopy/unix: SKIP
--- tests/migration-test.c | 23 +++++++++++++++++------ 1 file changed, 17 insertions(+), 6 deletions(-)
tests/migration-test.c +17 -6
@@ -360,7 +360,7 @@ static void migrate_start_postcopy(QTestState *who)qobject_unref (rsp); } -static void test_migrate_start (QTestState **from,QTestState **to, +static int test_migrate_start (QTestState **from,QTestState **to,const char *uri,bool hide_stderr) {gchar *cmd_src, *cmd_dst;
@@ -385,9 +385,13 @@ static void test_migrate_start(QTestState **from, QTestState **to, accel, tmpfs, bootpath, uri); }else if (strcmp (arch,"ppc64" ) ==0 ) { -/* On ppc64, the test only works with kvm-hv, but not with kvm-pr */ +/* On ppc64, the test only works with kvm-hv, but not with kvm-pr +* and TCG is touchy due to race conditions on dirty bits +* (especially on PPC for some reason) +*/ if (access ("/sys/module/kvm_hv" ,F_OK )) { - accel ="tcg" ; +g_test_skip ("kvm_hv not available" ); +return -1 ; } cmd_src =g_strdup_printf ("-machine accel=%s -m 256M" " -name source,debug-threads=on"
@@ -424,6 +428,7 @@ static void test_migrate_start(QTestState **from, QTestState **to, *to =qtest_init (cmd_dst);g_free (cmd_dst); +return 0 ; }static void test_migrate_end (QTestState *from,QTestState *to,bool test_dest)
@@ -510,7 +515,9 @@ static void test_postcopy(void)char *uri =g_strdup_printf ("unix:%s/migsocket" , tmpfs);QTestState *from, *to; -test_migrate_start (&from, &to, uri, false); +if (test_migrate_start (&from, &to, uri, false)) { +return ; + }migrate_set_capability (from,"postcopy-ram" ,"true" );migrate_set_capability (to,"postcopy-ram" ,"true" );
@@ -556,7 +563,9 @@ static void test_baddest(void)const char *status;bool failed; -test_migrate_start (&from, &to,"tcp:0:0" , true); +if (test_migrate_start (&from, &to,"tcp:0:0" , true)) { +return ; + }migrate (from,"tcp:0:0" ); do { rsp = wait_command(from, "{ 'execute': 'query-migrate' }");
@@ -585,7 +594,9 @@ static void test_precopy_unix(void)char *uri =g_strdup_printf ("unix:%s/migsocket" , tmpfs);QTestState *from, *to; -test_migrate_start (&from, &to, uri, false); +if (test_migrate_start (&from, &to, uri, false)) { +return ; + }/* We want to pick a speed slow enough that the test completes * quickly, but that it doesn't complete precopy even on a slow
Signature · 1 line
2.17.1
Quoted 11 lines · Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" <[email protected]>
PPC tcg seems to be failing migration tests quite regularly; we believe this is TCG bugs in dirty bit updating; it's not clear why PPC fails more but lets skip for the moment.
$ ./tests/migration-test /ppc64/migration/deprecated: OK /ppc64/migration/bad_dest: SKIP /ppc64/migration/postcopy/unix: SKIP /ppc64/migration/precopy/unix: SKIP
This patch seems to make the test fail in some setups:
TEST: tests/migration-test... (pid=58969)
/ppc64/migration/deprecated: OK
/ppc64/migration/bad_dest: FAIL
GTester: last random seed: R02S608df80fbcf1f18882138d397082bb59
/ppc64/migration/postcopy/unix: FAIL
GTester: last random seed: R02S608df80fbcf1f18882138d397082bb59
/ppc64/migration/precopy/unix: FAIL
GTester: last random seed: R02S608df80fbcf1f18882138d397082bb59
PASS: tests/migration-test
(and eventually make exits with an error).
Failed for me on ppc64, s390x, x86-64, aarch32. I don't think any of my build systems printed "SKIP" for these tests -- they either FAIL or just don't print anything.
thanks
-- PMM
Quoted 8 lines · Peter Maydell
Quoted 6 lines · Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" <[email protected]>
PPC tcg seems to be failing migration tests quite regularly; we believe this is TCG bugs in dirty bit updating; it's not clear why PPC fails more but lets skip for the moment.
Quoted 7 lines
Quoted 5 lines
$ ./tests/migration-test /ppc64/migration/deprecated: OK /ppc64/migration/bad_dest: SKIP /ppc64/migration/postcopy/unix: SKIP /ppc64/migration/precopy/unix: SKIPThis patch seems to make the test fail in some setups:
Specifically, it's the 'gtester' command in 'make check' that makes the difference:
e104462:xenial:ppc$ QTEST_QEMU_BINARY=ppc64-softmmu/qemu-system-ppc64 tests/migration-test
/ppc64/migration/deprecated: OK
/ppc64/migration/bad_dest: SKIP /ppc64/migration/postcopy/unix: SKIP /ppc64/migration/precopy/unix: SKIP
e104462:xenial:ppc$ QTEST_QEMU_BINARY=ppc64-softmmu/qemu-system-ppc64 gtester -k --verbose -m=quick tests/migration-test
TEST: tests/migration-test... (pid=23304)
/ppc64/migration/deprecated: OK
/ppc64/migration/bad_dest: FAIL
GTester: last random seed: R02Sa45f28859314d31ea4e89aeee4851d87
/ppc64/migration/postcopy/unix: FAIL
GTester: last random seed: R02Sa45f28859314d31ea4e89aeee4851d87
/ppc64/migration/precopy/unix: FAIL
GTester: last random seed: R02Sa45f28859314d31ea4e89aeee4851d87
PASS: tests/migration-test
This seems to be a bug in gtester:
https://bugzilla.gnome.org/show_bug.cgi?id=790934
which I guess we need to work around -- the easy approach would be to just call this a pass rather than a skip, I suppose.
I also note that in that bug report the glib folks say "don't use gtester, it's not maintained", and recommend that we switch to something else (a 'TAP harness', whatever that is)...
thanks
-- PMM
Quoted 38 lines · * Peter Maydell ([email protected]) wrote:
Quoted 8 lines · Peter Maydell
Quoted 6 lines · Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" <[email protected]>
PPC tcg seems to be failing migration tests quite regularly; we believe this is TCG bugs in dirty bit updating; it's not clear why PPC fails more but lets skip for the moment.
Quoted 7 lines
Quoted 5 lines
$ ./tests/migration-test /ppc64/migration/deprecated: OK /ppc64/migration/bad_dest: SKIP /ppc64/migration/postcopy/unix: SKIP /ppc64/migration/precopy/unix: SKIPThis patch seems to make the test fail in some setups:
Specifically, it's the 'gtester' command in 'make check' that makes the difference:
e104462:xenial:ppc$ QTEST_QEMU_BINARY=ppc64-softmmu/qemu-system-ppc64 tests/migration-test
/ppc64/migration/deprecated: OK
/ppc64/migration/bad_dest: SKIP /ppc64/migration/postcopy/unix: SKIP /ppc64/migration/precopy/unix: SKIP
e104462:xenial:ppc$ QTEST_QEMU_BINARY=ppc64-softmmu/qemu-system-ppc64 gtester -k --verbose -m=quick tests/migration-test
TEST: tests/migration-test... (pid=23304)
/ppc64/migration/deprecated: OK
/ppc64/migration/bad_dest: FAIL
GTester: last random seed: R02Sa45f28859314d31ea4e89aeee4851d87
/ppc64/migration/postcopy/unix: FAIL
GTester: last random seed: R02Sa45f28859314d31ea4e89aeee4851d87
/ppc64/migration/precopy/unix: FAIL
GTester: last random seed: R02Sa45f28859314d31ea4e89aeee4851d87
PASS: tests/migration-test
Quoted 2 lines
This seems to be a bug in gtester:
https://bugzilla.gnome.org/show_bug.cgi?id=790934
Bah, and I liked that I was using a nice new gtk feature.
Quoted 2 lines
which I guess we need to work around -- the easy approach would be to just call this a pass rather than a skip, I suppose.
Yeh, I'll rework it. I'll include a printf saying we skipped it though just to remove any false feeling of warmth and reassurance of an OK.
Quoted 3 lines
I also note that in that bug report the glib folks say "don't use gtester, it's not maintained", and recommend that we switch to something else (a 'TAP harness', whatever that is)...
https://testanything.org/ I think, but I don't know anything about it.
Dave
Quoted 3 lines
thanks
-- PMM
--
Dr. David Alan Gilbert / [email protected] / Manchester, UK