drbd: mark expected switch fall-throughs
Subsystems (2)
PATCH 1/1 drbd: mark expected switch fall-throughs
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Warning level 2 was used in this case: -Wimplicit-fallthrough=2
Signed-off-by Gustavo A. R. Silva <[email protected]>
--- drivers/block/drbd/drbd_receiver.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/block/drbd/drbd_receiver.c +3 -0
@@ -2790,6 +2790,7 @@ static int receive_DataRequest(struct drbd_connection *connection, struct packetthen we would do something smarter here than reading the block... */ peer_req->flags |=EE_RS_THIN_REQ ; +/* fall through */ case P_RS_DATA_REQUEST : peer_req->w.cb = w_e_end_rsdata_req; fault_type =DRBD_FAULT_RS_RD ;
@@ -2968,6 +2969,7 @@ static int drbd_asb_recover_0p(struct drbd_peer_device *peer_device) __must_hold/* Else fall through to one of the other strategies... */ drbd_warn (device,"Discard younger/older primary did not find a decision\n" "Using discard-least-changes instead\n" ); +/* fall through */ case ASB_DISCARD_ZERO_CHG :if (ch_peer ==0 && ch_self ==0 ) { rv =test_bit (RESOLVE_CONFLICTS , &peer_device->connection->flags)
@@ -2979,6 +2981,7 @@ static int drbd_asb_recover_0p(struct drbd_peer_device *peer_device) __must_hold }if (after_sb_0p ==ASB_DISCARD_ZERO_CHG )break ; +/* else: fall through */ case ASB_DISCARD_LEAST_CHG :if (ch_self < ch_peer) rv =-1 ;
Signature · 1 line
2.7.4
Quoted 4 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Warning level 2 was used in this case: -Wimplicit-fallthrough=2
Applied, thanks.
Signature · 1 line
Jens Axboe