parport: ieee1284: mark expected switch fall-throughs

PATCH New Gustavo A. R. Silva 1 participant 1 message Jul 5, 2018 Parallel port

lore

Share & tools

lore

Gustavo A. R. Silva

author

2018-07-05 13:47 UTC #0 lore raw

PATCH 1/1 parport: ieee1284: mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
 drivers/parport/ieee1284.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

drivers/parport/ieee1284.c +2 -1

index 2d1a5c7..f12b9da 100644
@@ -267,7 +267,7 @@ static void parport_ieee1284_terminate (struct parport *port)
 			port->ieee1284.phase = IEEE1284_PH_FWD_IDLE;
 		}
 
-		/* fall-though.. */
+		/* fall through */
 
 	default:
 		/* Terminate from all other modes. */

@@ -615,6 +615,7 @@ ssize_t parport_write (struct parport *port, const void *buffer, size_t len)
 	case IEEE1284_MODE_NIBBLE:
 	case IEEE1284_MODE_BYTE:
 		parport_negotiate (port, IEEE1284_MODE_COMPAT);
+		/* fall through */
 	case IEEE1284_MODE_COMPAT:
 		DPRINTK (KERN_DEBUG "%s: Using compatibility mode\n",
 			 port->name);

Signature · 1 line

2.7.4