iio: sca3000: Fix missing return in switch
PATCH 1/1 iio: sca3000: Fix missing return in switch
The IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY case is missing a return and will fall through to the default case and errorenously return -EINVAL.
Fix this by adding in missing *return ret*.
Fixes 626f971b5b07 ("staging:iio:accel:sca3000 Add write support to the low pass filter control")
Reported-by Jonathan Cameron <[email protected]>
Signed-off-by Gustavo A. R. Silva <[email protected]>
--- drivers/iio/accel/sca3000.c | 1 + 1 file changed, 1 insertion(+)
drivers/iio/accel/sca3000.c +1 -0
@@ -797,6 +797,7 @@ static int sca3000_write_raw(struct iio_dev *indio_dev,mutex_lock (&st->lock); ret =sca3000_write_3db_freq (st, val);mutex_unlock (&st->lock); +return ret;default :return -EINVAL ; }
Signature · 1 line
2.7.4
Quoted 9 lines · On Sat, 7 Jul 2018 12:44:01 -0500 "Gustavo A. R. Silva"…
The
IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCYcase is missing a return and will fall through to the default case and errorenously return-EINVAL.Fix this by adding in missing *return ret*.
Fixes 626f971b5b07 ("staging:iio:accel:sca3000 Add write support to the low pass filter control")Reported-by Jonathan Cameron <[email protected]>Signed-off-by Gustavo A. R. Silva <[email protected]>
Thanks, Applied to the fixes-togreg branch of iio.git, marked for stable.
Jonathan
Quoted 16 lines
--- drivers/iio/accel/sca3000.c | 1 + 1 file changed, 1 insertion(+)drivers/iio/accel/sca3000.c +1
-0@@ -797,6 +797,7 @@ static int sca3000_write_raw(struct iio_dev *indio_dev,mutex_lock (&st->lock); ret =sca3000_write_3db_freq (st, val);mutex_unlock (&st->lock); +return ret;default :return -EINVAL ; }