net: sched: act_ife: fix memory leak

PATCH New Gustavo A. R. Silva 1 participant 1 message Jul 10, 2018

Subsystems (3)

Networking Network drivers Traffic control (tc)

lore

Share & tools

lore

Gustavo A. R. Silva

author

2018-07-10 14:19 UTC #0 lore raw

PATCH 1/1 net: sched: act_ife: fix memory leak

In case memory resources for *p* are allocated, release them before return.

Addresses-Coverity-ID: 1471714 ("Resource leak")

Fixes 0190c1d452a9 ("net: sched: atomically check-allocate action")

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
 net/sched/act_ife.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

net/sched/act_ife.c +3 -1

index a3eef00..3d6e265 100644
@@ -485,8 +485,10 @@ static int tcf_ife_init(struct net *net, struct nlattr *nla,
 		return -ENOMEM;
 
 	err = tcf_idr_check_alloc(tn, &parm->index, a, bind);
-	if (err < 0)
+	if (err < 0) {
+		kfree(p);
 		return err;
+	}
 	exists = err;
 	if (exists && bind) {
 		kfree(p);

Signature · 1 line

2.7.4