Skip to contentSkip to conversation

libkcapi: Add new recipe for v1.1.1

PATCH Superseded Krzysztof Kozlowski 2 participants 3 messages Jul 10, 2018 – Jul 12, 2018

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libkcapi: Add new recipe for v1.1.1

Add new recipe with libkcapi v1.1.1, Linux Kernel Crypto API User Space Interface Library.

---
 meta-oe/recipes-crypto/libkcapi/libkcapi_git.bb | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 meta-oe/recipes-crypto/libkcapi/libkcapi_git.bb
meta-oe/recipes-crypto/libkcapi/libkcapi_git.bb new file +24 -0
new file mode 100644
index 000000000000..be25d6e390ea
@@ -0,0 +1,24 @@
+SUMMARY = "Linux Kernel Crypto API User Space Interface Library"
+HOMEPAGE = "http://www.chronox.de/libkcapi.html"
+LICENSE = "BSD | GPL-2.0"
+LIC_FILES_CHKSUM = "file://COPYING;md5=d0421cf231423bda10cea691b613e866"
+
+DEPENDS = "libtool"
+
+S = "${WORKDIR}/git"
+# Use v1.1.1 with changes on top for building in OE
+SRCREV = "342b50fc9225a991c224126c13c188ad9f1ef9f9"
+PV = "1.1.1+git${SRCPV}"
+SRC_URI = "git://github.com/smuellerDD/libkcapi.git"
+
+inherit autotools
+
+PACKAGECONFIG ??= ""
+PACKAGECONFIG[testapp] = "--enable-kcapi-test,,,"
+PACKAGECONFIG[apps] = "--enable-kcapi-speed --enable-kcapi-hasher --enable-kcapi-rngapp --enable-kcapi-encapp --enable-kcapi-dgstapp,,,"
+
+do_install_append() {
+    # bindir contains testapp and apps.  However it is always created, even
+    # when no binaries are installed (empty bin_PROGRAMS in Makefile.am),
+    rmdir --ignore-fail-on-non-empty ${D}${bindir}
+}
Signature · 1 line
2.14.1
#1 lore raw

This fails for mips/musl builds

| ../git/lib/kcapi-kernel-if.c: In function '__kcapi_common_getinfo.isra.2':
| ../git/lib/kcapi-kernel-if.c:632:3: error: 'strncpy' output truncated before terminating nul copying as many bytes from a string as its length [-Werror=stringop-truncation]

|    strncpy(req.cru.cru_name, ciphername, strlen(ciphername));
|    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| ../git/lib/kcapi-kernel-if.c:629:3: error: 'strncpy' output
truncated before terminating nul copying as many bytes from a string
as its length [-Werror=stringop-truncation]
|    strncpy(req.cru.cru_driver_name, ciphername,
|    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|     strlen(ciphername));
|     ~~~~~~~~~~~~~~~~~~~
| cc1: all warnings being treated as errors
| make: *** [lib/libkcapi_la-kcapi-kernel-if.lo] Error 1
Quoted 48 lines · Krzysztof Kozlowski

Add new recipe with libkcapi v1.1.1, Linux Kernel Crypto API User Space Interface Library.

---
 meta-oe/recipes-crypto/libkcapi/libkcapi_git.bb | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 meta-oe/recipes-crypto/libkcapi/libkcapi_git.bb
meta-oe/recipes-crypto/libkcapi/libkcapi_git.bb new file +24 -1
new file mode 100644
index 000000000000..be25d6e390ea
@@ -0,0 +1,24 @@
+SUMMARY = "Linux Kernel Crypto API User Space Interface Library"
+HOMEPAGE = "http://www.chronox.de/libkcapi.html"
+LICENSE = "BSD | GPL-2.0"
+LIC_FILES_CHKSUM = "file://COPYING;md5=d0421cf231423bda10cea691b613e866"
+
+DEPENDS = "libtool"
+
+S = "${WORKDIR}/git"
+# Use v1.1.1 with changes on top for building in OE
+SRCREV = "342b50fc9225a991c224126c13c188ad9f1ef9f9"
+PV = "1.1.1+git${SRCPV}"
+SRC_URI = "git://github.com/smuellerDD/libkcapi.git"
+
+inherit autotools
+
+PACKAGECONFIG ??= ""
+PACKAGECONFIG[testapp] = "--enable-kcapi-test,,,"
+PACKAGECONFIG[apps] = "--enable-kcapi-speed --enable-kcapi-hasher --enable-kcapi-rngapp --enable-kcapi-encapp --enable-kcapi-dgstapp,,,"
+
+do_install_append() {
+    # bindir contains testapp and apps.  However it is always created, even
+    # when no binaries are installed (empty bin_PROGRAMS in Makefile.am),
+    rmdir --ignore-fail-on-non-empty ${D}${bindir}
+}
--

2.14.1

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#2 lore raw
Quoted 6 lines · Khem Raj

This fails for mips/musl builds

| ../git/lib/kcapi-kernel-if.c: In function '__kcapi_common_getinfo.isra.2':
| ../git/lib/kcapi-kernel-if.c:632:3: error: 'strncpy' output truncated before terminating nul copying as many bytes from a string as its length [-Werror=stringop-truncation]

Quoted 11 lines
|    strncpy(req.cru.cru_name, ciphername, strlen(ciphername));
|    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| ../git/lib/kcapi-kernel-if.c:629:3: error: 'strncpy' output
truncated before terminating nul copying as many bytes from a string
as its length [-Werror=stringop-truncation]
|    strncpy(req.cru.cru_driver_name, ciphername,
|    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|     strlen(ciphername));
|     ~~~~~~~~~~~~~~~~~~~
| cc1: all warnings being treated as errors
| make: *** [lib/libkcapi_la-kcapi-kernel-if.lo] Error 1

Thanks for letting me know. I'll take a look and fix it.

Best regards,
Krzysztof