Skip to contentSkip to conversation

drm/i915/psr: Remove useless function calls.

PATCH In review Rodrigo Vivi 3 participants 4 messages Jul 11, 2018 – Jul 13, 2018

Subsystems (2)
lore
Share & tools
lore

Rodrigo Vivi

author maintainer
#0 lore raw

PATCH 1/1 drm/i915/psr: Remove useless function calls.

PSR is no longer supported on VLV/CHV so this is just dead code.

Cc Dhinakaran Pandiyan <[email protected]>
---
 drivers/gpu/drm/i915/intel_dp.c | 7 -------
 1 file changed, 7 deletions(-)
drivers/gpu/drm/i915/intel_dp.c +0 -7
index 5be07e1d816d..7d40bfcb1bbb 100644
@@ -2830,10 +2830,6 @@ static void vlv_disable_dp(struct intel_encoder *encoder,
 			   const struct intel_crtc_state *old_crtc_state,
 			   const struct drm_connector_state *old_conn_state)
 {
-	struct intel_dp *intel_dp = enc_to_intel_dp(&encoder->base);
-
-	intel_psr_disable(intel_dp, old_crtc_state);
-
 	intel_disable_dp(encoder, old_crtc_state, old_conn_state);
 }
 
@@ -3046,10 +3042,7 @@ static void vlv_enable_dp(struct intel_encoder *encoder,
 			  const struct intel_crtc_state *pipe_config,
 			  const struct drm_connector_state *conn_state)
 {
-	struct intel_dp *intel_dp = enc_to_intel_dp(&encoder->base);
-
 	intel_edp_backlight_on(pipe_config, conn_state);
-	intel_psr_enable(intel_dp, pipe_config);
 }
 
 static void g4x_pre_enable_dp(struct intel_encoder *encoder,
Signature · 6 lines
2.17.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v1 1/1
#1 lore raw
Quoted 2 lines · Rodrigo Vivi

PSR is no longer supported on VLV/CHV so this is just dead code.

Quoted 38 lines
Cc Dhinakaran Pandiyan <[email protected]>
---
 drivers/gpu/drm/i915/intel_dp.c | 7 -------
 1 file changed, 7 deletions(-)
drivers/gpu/drm/i915/intel_dp.c +0 -4
index 5be07e1d816d..7d40bfcb1bbb 100644
@@ -2830,10 +2830,6 @@ static void vlv_disable_dp(struct
 intel_encoder *encoder,
 			   const struct intel_crtc_state
 *old_crtc_state,
 			   const struct drm_connector_state
 *old_conn_state)
 {
-	struct intel_dp *intel_dp = enc_to_intel_dp(&encoder->base);
-
-	intel_psr_disable(intel_dp, old_crtc_state);
-
drivers/gpu/drm/i915/intel_dp.c +0 -3
 	intel_disable_dp(encoder, old_crtc_state, old_conn_state);
 }
@@ -3046,10 +3042,7 @@ static void vlv_enable_dp(struct intel_encoder
 *encoder,
 			  const struct intel_crtc_state
 *pipe_config,
 			  const struct drm_connector_state
 *conn_state)
 {
-	struct intel_dp *intel_dp = enc_to_intel_dp(&encoder->base);
-
 	intel_edp_backlight_on(pipe_config, conn_state);
-	intel_psr_enable(intel_dp, pipe_config);

}

Quoted 1 line

static void g4x_pre_enable_dp(struct intel_encoder *encoder,

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

author maintainer Applied
#2 lore raw
Quoted 5 lines · Jose
Quoted 2 lines · Rodrigo Vivi

PSR is no longer supported on VLV/CHV so this is just dead code.

pushed to dinq, thanks

Quoted 38 lines
Quoted 38 lines
Cc Dhinakaran Pandiyan <[email protected]>
---
 drivers/gpu/drm/i915/intel_dp.c | 7 -------
 1 file changed, 7 deletions(-)
drivers/gpu/drm/i915/intel_dp.c +0 -4
index 5be07e1d816d..7d40bfcb1bbb 100644
@@ -2830,10 +2830,6 @@ static void vlv_disable_dp(struct
 intel_encoder *encoder,
 			   const struct intel_crtc_state
 *old_crtc_state,
 			   const struct drm_connector_state
 *old_conn_state)
 {
-	struct intel_dp *intel_dp = enc_to_intel_dp(&encoder->base);
-
-	intel_psr_disable(intel_dp, old_crtc_state);
-
drivers/gpu/drm/i915/intel_dp.c +0 -3
 	intel_disable_dp(encoder, old_crtc_state, old_conn_state);
 }
@@ -3046,10 +3042,7 @@ static void vlv_enable_dp(struct intel_encoder
 *encoder,
 			  const struct intel_crtc_state
 *pipe_config,
 			  const struct drm_connector_state
 *conn_state)
 {
-	struct intel_dp *intel_dp = enc_to_intel_dp(&encoder->base);
-
 	intel_edp_backlight_on(pipe_config, conn_state);
-	intel_psr_enable(intel_dp, pipe_config);

}

Quoted 5 lines
Quoted 1 line

static void g4x_pre_enable_dp(struct intel_encoder *encoder,

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

✓ Fi.CI.BAT: success for drm/i915/psr: Remove useless function calls.

In reply to Rodrigo Vivi
== Series Details ==

== Series Details ==

Series: drm/i915/psr: Remove useless function calls.
URL : https://patchwork.freedesktop.org/series/46339/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4473 -> Patchwork_9619 =

== Summary - SUCCESS ==

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/46339/revisions/1/mbox/

== Known issues ==

Here are the changes found in Patchwork_9619 that come from known issues:

=== IGT changes ===

    ==== Possible fixes ====

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      fi-skl-6700k2:      FAIL (fdo#103191) -> PASS

    
    ==== Warnings ====

    igt@gem_exec_suspend@basic-s4-devices:
      {fi-kbl-8809g}:     INCOMPLETE (fdo#107139) -> DMESG-WARN (fdo#107139)

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#107139 https://bugs.freedesktop.org/show_bug.cgi?id=107139

== Participating hosts (46 -> 42) ==

Additional (1): fi-skl-guc
Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u

== Build changes ==

* Linux: CI_DRM_4473 -> Patchwork_9619

CI_DRM_4473: 17c95b123220c6896ac9cf99c78be4709da704d4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4549: e19fd5549e9cf603251704117fc64f4068be5016 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9619: ed4d3ec314fce5f057ee3af26a55bbd2d52dd8c0 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

ed4d3ec314fc drm/i915/psr: Remove useless function calls.

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9619/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx