drm/i915/execlists: Check reset_in_progress()
Subsystems (2)
PATCH 1/4 drm/i915/execlists: Check reset_in_progress()
Check that reset_in_progress() is true when we process the reset.
--- drivers/gpu/drm/i915/intel_lrc.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/i915/intel_lrc.c +1 -0
@@ -1962,6 +1962,7 @@ static void execlists_reset(struct intel_engine_cs *engine,GEM_TRACE ("%s request global=%x, current=%d\n" , engine->name, request ? request->global_seqno :0 ,intel_engine_get_seqno (engine)); +GEM_BUG_ON (!reset_in_progress (execlists));spin_lock_irqsave (&engine->timeline.lock, flags);
Signature · 6 lines
2.18.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/4 drm/i915/selftests: Include the start of each subtest in the GEM trace
Knowing the boundary of each subtest can be instrumental in digesting the voluminous trace output and finding the critical piece of information.
--- drivers/gpu/drm/i915/selftests/i915_selftest.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/gpu/drm/i915/selftests/i915_selftest.c +2 -0
@@ -210,6 +210,8 @@ int __i915_subtests(const char *caller,return -EINTR ;pr_debug (DRIVER_NAME ": Running %s/%s\n" , caller, st->name); +GEM_TRACE ("Running %s/%s\n" , caller, st->name); + err = st->func (data);if (err && err != -EINTR ) { pr_err(DRIVER_NAME "/%s: %s failed with error %d\n",
Signature · 6 lines
2.18.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 2/4] drm/i915/selftests: Include the start of each subtest in the GEM trace
Quoted 5 lines · Chris Wilson
Knowing the boundary of each subtest can be instrumental in digesting the voluminous trace output and finding the critical piece of information.
Signed-off-by Chris Wilson <[email protected]>
Quoted 10 lines
--- drivers/gpu/drm/i915/selftests/i915_selftest.c | 2 ++ 1 file changed, 2 insertions(+)drivers/gpu/drm/i915/selftests/i915_selftest.c +0
-0
drivers/gpu/drm/i915/selftests/i915_selftest.c int __i915_subtests(const char *caller, · line 217
Quoted 8 lines
drivers/gpu/drm/i915/selftests/i915_selftest.c +2
-0@@ -210,6 +210,8 @@ int __i915_subtests(const char *caller,return -EINTR ;pr_debug (DRIVER_NAME ": Running %s/%s\n" , caller, st->name); +GEM_TRACE ("Running %s/%s\n" , caller, st->name); + err = st->func (data);if (err && err != -EINTR ) { pr_err(DRIVER_NAME "/%s: %s failed with error %d\n",
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 3/4 drm/i915: Do not short-circuit tasklets during reset
In reply to Chris WilsonInside intel_engine_is_idle(), we flush the tasklet to ensure that is being run in a timely fashion (ksoftirqd has taught us to expect the worst). However, if we are in the middle of reset, the HW may not yet be ready to execute the submission tasklet and so we must respect the disable flag.
Testcase: igt/drv_selftest/live_hangcheck
--- drivers/gpu/drm/i915/intel_engine_cs.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/intel_engine_cs.c +6 -5
@@ -989,16 +989,17 @@ bool intel_engine_is_idle(struct intel_engine_cs *engine)/* Waiting to drain ELSP? */ if (READ_ONCE (engine->execlists.active)) { -struct intel_engine_execlists *execlists = &engine->execlists; +struct tasklet_struct *t = &engine->execlists.tasklet;local_bh_disable (); -if (tasklet_trylock (&execlists->tasklet)) { - execlists->tasklet.func (execlists->tasklet.data); -tasklet_unlock (&execlists->tasklet); +if (tasklet_trylock (t)) { +if (__tasklet_is_enabled (t)) + t->func (t->data); +tasklet_unlock (t); }local_bh_enable (); -if (READ_ONCE (execlists->active)) +if (READ_ONCE (engine->execlists.active))return false; }
Signature · 6 lines
2.18.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 4/4 drm/i915/execlists: Drop clear_gtiir() on GPU reset
In reply to Chris WilsonWith the new CSB processing code, we are not vulnerable to delayed delivery of a pre-reset interrupt as we use the CSB status pointers in the HWSP to decide if we need to parse any CSB events and no longer need to wait for the first post-reset interrupt to be assured that the CSB mmio registers are valid.
The new icl code to clear registers has a nasty lock inversion:
[ 57.409776] ======================================================
[ 57.409779] WARNING: possible circular locking dependency detected
[ 57.409783] 4.18.0-rc4-CI-CI_DII_1137+ #1 Tainted: G U W
[ 57.409785] ------------------------------------------------------
[ 57.409788] swapper/6/0 is trying to acquire lock:
[ 57.409790] 000000004f304ee5 (&engine->timeline.lock/1){-.-.}, at: execlists_submit_request+0x2b/0x1a0 [i915]
[ 57.409841]
but task is already holding lock:
[ 57.409844] 00000000aad89594 (&(&rq->lock)->rlock#2){-.-.}, at: notify_ring+0x2b2/0x480 [i915]
[ 57.409869]
which lock already depends on the new lock.[ 57.409872]
the existing dependency chain (in reverse order) is:
[ 57.409876]
-> #2 (&(&rq->lock)->rlock#2){-.-.}:
[ 57.409900] notify_ring+0x2b2/0x480 [i915]
[ 57.409922] gen8_cs_irq_handler+0x39/0xa0 [i915]
[ 57.409943] gen11_irq_handler+0x2f0/0x420 [i915]
[ 57.409949] __handle_irq_event_percpu+0x42/0x370
[ 57.409952] handle_irq_event_percpu+0x2b/0x70
[ 57.409956] handle_irq_event+0x2f/0x50
[ 57.409959] handle_edge_irq+0xe7/0x190
[ 57.409964] handle_irq+0x67/0x160
[ 57.409967] do_IRQ+0x5e/0x120
[ 57.409971] ret_from_intr+0x0/0x1d
[ 57.409974] _raw_spin_unlock_irqrestore+0x4e/0x60
[ 57.409979] tasklet_action_common.isra.5+0x47/0xb0
[ 57.409982] __do_softirq+0xd9/0x505
[ 57.409985] irq_exit+0xa9/0xc0
[ 57.409988] do_IRQ+0x9a/0x120
[ 57.409991] ret_from_intr+0x0/0x1d
[ 57.409995] cpuidle_enter_state+0xac/0x360
[ 57.409999] do_idle+0x1f3/0x250
[ 57.410004] cpu_startup_entry+0x6a/0x70
[ 57.410010] start_secondary+0x19d/0x1f0
[ 57.410015] secondary_startup_64+0xa5/0xb0
[ 57.410018]
-> #1 (&(&dev_priv->irq_lock)->rlock){-.-.}:
[ 57.410081] clear_gtiir+0x30/0x200 [i915]
[ 57.410116] execlists_reset+0x6e/0x2b0 [i915]
[ 57.410140] i915_reset_engine+0x111/0x190 [i915]
[ 57.410165] i915_handle_error+0x11a/0x4a0 [i915]
[ 57.410198] i915_hangcheck_elapsed+0x378/0x530 [i915]
[ 57.410204] process_one_work+0x248/0x6c0
[ 57.410207] worker_thread+0x37/0x380
[ 57.410211] kthread+0x119/0x130
[ 57.410215] ret_from_fork+0x3a/0x50
[ 57.410217]
-> #0 (&engine->timeline.lock/1){-.-.}:
[ 57.410224] _raw_spin_lock_irqsave+0x33/0x50
[ 57.410256] execlists_submit_request+0x2b/0x1a0 [i915]
[ 57.410289] submit_notify+0x8d/0x124 [i915]
[ 57.410314] __i915_sw_fence_complete+0x81/0x250 [i915]
[ 57.410339] dma_i915_sw_fence_wake+0xd/0x20 [i915]
[ 57.410344] dma_fence_signal_locked+0x79/0x200
[ 57.410368] notify_ring+0x2ba/0x480 [i915]
[ 57.410392] gen8_cs_irq_handler+0x39/0xa0 [i915]
[ 57.410416] gen11_irq_handler+0x2f0/0x420 [i915]
[ 57.410421] __handle_irq_event_percpu+0x42/0x370
[ 57.410425] handle_irq_event_percpu+0x2b/0x70
[ 57.410428] handle_irq_event+0x2f/0x50
[ 57.410432] handle_edge_irq+0xe7/0x190
[ 57.410436] handle_irq+0x67/0x160
[ 57.410439] do_IRQ+0x5e/0x120
[ 57.410445] ret_from_intr+0x0/0x1d
[ 57.410449] cpuidle_enter_state+0xac/0x360
[ 57.410453] do_idle+0x1f3/0x250
[ 57.410456] cpu_startup_entry+0x6a/0x70
[ 57.410460] start_secondary+0x19d/0x1f0
[ 57.410464] secondary_startup_64+0xa5/0xb0
[ 57.410466]
other info that might help us debug this:[ 57.410471] Chain exists of:
&engine->timeline.lock/1 --> &(&dev_priv->irq_lock)->rlock --> &(&rq->lock)->rlock#2[ 57.410481] Possible unsafe locking scenario:
[ 57.410485] CPU0 CPU1
[ 57.410487] ---- ----
[ 57.410490] lock(&(&rq->lock)->rlock#2);
[ 57.410494] lock(&(&dev_priv->irq_lock)->rlock);
[ 57.410498] lock(&(&rq->lock)->rlock#2);
[ 57.410503] lock(&engine->timeline.lock/1);
[ 57.410506]
*** DEADLOCK ***[ 57.410511] 4 locks held by swapper/6/0:
[ 57.410514] #0: 0000000074575789 (&(&dev_priv->irq_lock)->rlock){-.-.}, at: gen11_irq_handler+0x8a/0x420 [i915]
[ 57.410542] #1: 000000009b29b30e (rcu_read_lock){....}, at: notify_ring+0x1a/0x480 [i915]
[ 57.410573] #2: 00000000aad89594 (&(&rq->lock)->rlock#2){-.-.}, at: notify_ring+0x2b2/0x480 [i915]
[ 57.410601] #3: 000000009b29b30e (rcu_read_lock){....}, at: submit_notify+0x35/0x124 [i915]
[ 57.410635]
stack backtrace:
[ 57.410640] CPU: 6 PID: 0 Comm: swapper/6 Tainted: G U W 4.18.0-rc4-CI-CI_DII_1137+ #1
[ 57.410644] Hardware name: Intel Corporation Ice Lake Client Platform/IceLake U DDR4 SODIMM PD RVP, BIOS ICLSFWR1.R00.2222.A01.1805300339 05/30/2018
[ 57.410650] Call Trace:
[ 57.410652] <IRQ>
[ 57.410657] dump_stack+0x67/0x9b
[ 57.410662] print_circular_bug.isra.16+0x1c8/0x2b0
[ 57.410666] __lock_acquire+0x1897/0x1b50
[ 57.410671] ? lock_acquire+0xa6/0x210
[ 57.410674] lock_acquire+0xa6/0x210
[ 57.410706] ? execlists_submit_request+0x2b/0x1a0 [i915]
[ 57.410711] _raw_spin_lock_irqsave+0x33/0x50
[ 57.410741] ? execlists_submit_request+0x2b/0x1a0 [i915]
[ 57.410769] execlists_submit_request+0x2b/0x1a0 [i915]
[ 57.410774] ? _raw_spin_unlock_irqrestore+0x39/0x60
[ 57.410804] submit_notify+0x8d/0x124 [i915]
[ 57.410828] __i915_sw_fence_complete+0x81/0x250 [i915]
[ 57.410854] dma_i915_sw_fence_wake+0xd/0x20 [i915]
[ 57.410858] dma_fence_signal_locked+0x79/0x200
[ 57.410882] notify_ring+0x2ba/0x480 [i915]
[ 57.410907] gen8_cs_irq_handler+0x39/0xa0 [i915]
[ 57.410933] gen11_irq_handler+0x2f0/0x420 [i915]
[ 57.410938] __handle_irq_event_percpu+0x42/0x370
[ 57.410943] handle_irq_event_percpu+0x2b/0x70
[ 57.410947] handle_irq_event+0x2f/0x50
[ 57.410951] handle_edge_irq+0xe7/0x190
[ 57.410955] handle_irq+0x67/0x160
[ 57.410958] do_IRQ+0x5e/0x120
[ 57.410962] common_interrupt+0xf/0xf
[ 57.410965] </IRQ>
[ 57.410969] RIP: 0010:cpuidle_enter_state+0xac/0x360
[ 57.410972] Code: 44 00 00 31 ff e8 84 93 91 ff 45 84 f6 74 12 9c 58 f6 c4 02 0f 85 31 02 00 00 31 ff e8 7d 30 98 ff e8 e8 0e 94 ff fb 4c 29 fb <48> ba cf f7 53 e3 a5 9b c4 20 48 89 d8 48 c1 fb 3f 48 f7 ea b8 ff
[ 57.411015] RSP: 0018:ffffc90000133e90 EFLAGS: 00000216 ORIG_RAX: ffffffffffffffdd
[ 57.411023] RAX: ffff8804ae748040 RBX: 000000000002a97d RCX: 0000000000000000
[ 57.411029] RDX: 0000000000000046 RSI: ffffffff82141263 RDI: ffffffff820f05a7
[ 57.411035] RBP: 0000000000000001 R08: 0000000000000001 R09: 0000000000000000
[ 57.411041] R10: 0000000000000000 R11: 0000000000000000 R12: ffffffff8229f078
[ 57.411045] R13: ffff8804ab2adfa8 R14: 0000000000000000 R15: 0000000d5de092e3
[ 57.411052] do_idle+0x1f3/0x250
[ 57.411055] cpu_startup_entry+0x6a/0x70
[ 57.411059] start_secondary+0x19d/0x1f0
[ 57.411064] secondary_startup_64+0xa5/0xb0The easiest remedy is to remove the defunct code.
References: fd8526e50902 ("drm/i915/execlists: Trust the CSB")
--- drivers/gpu/drm/i915/i915_irq.c | 6 +-- drivers/gpu/drm/i915/intel_drv.h | 3 -- drivers/gpu/drm/i915/intel_lrc.c | 68 -------------------------------- 3 files changed, 3 insertions(+), 74 deletions(-)
drivers/gpu/drm/i915/i915_irq.c +3 -3
@@ -263,9 +263,9 @@ static u32 gen11_gt_engine_identity(struct drm_i915_private * const i915, const unsigned int bank, const unsigned int bit); -bool gen11_reset_one_iir (struct drm_i915_private *const i915, -const unsigned int bank, -const unsigned int bit) +static bool gen11_reset_one_iir (struct drm_i915_private *const i915, +const unsigned int bank, +const unsigned int bit) {void __iomem *const regs = i915->regs;u32 dw;
drivers/gpu/drm/i915/intel_drv.h +0 -3
@@ -1354,9 +1354,6 @@ void intel_check_cpu_fifo_underruns(struct drm_i915_private *dev_priv);void intel_check_pch_fifo_underruns (struct drm_i915_private *dev_priv);/* i915_irq.c */ -bool gen11_reset_one_iir (struct drm_i915_private *const i915, -const unsigned int bank, -const unsigned int bit);void gen5_enable_gt_irq (struct drm_i915_private *dev_priv,uint32_t mask);void gen5_disable_gt_irq (struct drm_i915_private *dev_priv,uint32_t mask);void gen6_mask_pm_irq (struct drm_i915_private *dev_priv,u32 mask);
drivers/gpu/drm/i915/intel_lrc.c +0 -68
86 lines not on this page · raw message
Signature · 6 lines
2.18.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 3 lines · Chris Wilson
Check that
reset_in_progress()is true when we process the reset.Signed-off-by Chris Wilson <[email protected]>
Quoted 19 lines
--- drivers/gpu/drm/i915/intel_lrc.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/i915/intel_lrc.c +1
-1@@ -1962,6 +1962,7 @@ static void execlists_reset(struct intel_engine_cs *engine,GEM_TRACE ("%s request global=%x, current=%d\n" , engine->name, request ? request->global_seqno :0 ,intel_engine_get_seqno (engine)); +GEM_BUG_ON (!reset_in_progress (execlists));spin_lock_irqsave (&engine->timeline.lock, flags); --2.18.0
Quoted 5 lines
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Chris Wilson (2018-07-13 21:18:45)
Quoted 1 line
Check that
reset_in_progress()is true when we process the reset.
Grr called from sanitize, so this is fatal across suspend. -Chris
_______________________________________________
Intel-gfx mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915/execlists: Check reset_in_progress()
In reply to Chris Wilson== Series Details ==
== Series Details ==
Series: series starting with [1/4] drm/i915/execlists: Check reset_in_progress()
URL : https://patchwork.freedesktop.org/series/46513/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
05763b37e58a drm/i915/execlists: Check reset_in_progress()
6ca6d5421808 drm/i915/selftests: Include the start of each subtest in the GEM trace
49f92d22de3e drm/i915: Do not short-circuit tasklets during reset
6f9dc8805150 drm/i915/execlists: Drop clear_gtiir() on GPU reset
-:153: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit fd8526e50902 ("drm/i915/execlists: Trust the CSB")'
#153:
References: fd8526e50902 ("drm/i915/execlists: Trust the CSB")total: 1 errors, 0 warnings, 0 checks, 107 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915/execlists: Check reset_in_progress()
In reply to Chris Wilson== Series Details ==
== Series Details ==
Series: series starting with [1/4] drm/i915/execlists: Check reset_in_progress()
URL : https://patchwork.freedesktop.org/series/46513/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4488 -> Patchwork_9653 =
== Summary - FAILURE ==
Serious unknown changes coming with Patchwork_9653 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_9653, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/46513/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_9653:
=== IGT changes ===
==== Possible regressions ====
igt@core_auth@basic-auth:
{fi-skl-iommu}: PASS -> INCOMPLETE
igt@gem_exec_suspend@basic-s3:
fi-bdw-5557u: PASS -> INCOMPLETE
fi-kbl-r: PASS -> INCOMPLETE
fi-whl-u: PASS -> INCOMPLETE
fi-glk-dsi: PASS -> INCOMPLETE
fi-kbl-x1275: PASS -> INCOMPLETE
fi-cfl-8700k: PASS -> INCOMPLETE
{fi-kbl-8809g}: PASS -> INCOMPLETE
fi-bsw-n3050: PASS -> INCOMPLETE
fi-kbl-7560u: PASS -> INCOMPLETE== Known issues ==
Here are the changes found in Patchwork_9653 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_suspend@basic-s3:
fi-skl-6770hq: PASS -> INCOMPLETE (fdo#104108)
{fi-cfl-8109u}: PASS -> INCOMPLETE (fdo#107187)
fi-cfl-s3: PASS -> INCOMPLETE (fdo#105524, k.org#199541)
fi-skl-6260u: PASS -> INCOMPLETE (fdo#104108)
fi-bdw-gvtdvm: PASS -> INCOMPLETE (fdo#105600)
fi-cfl-guc: PASS -> INCOMPLETE (fdo#106693)
fi-kbl-7567u: PASS -> INCOMPLETE (fdo#103665)
fi-skl-guc: PASS -> INCOMPLETE (fdo#106693, fdo#104108)
fi-glk-j4005: PASS -> INCOMPLETE (fdo#103359, k.org#198133)
fi-kbl-7500u: PASS -> INCOMPLETE (fdo#105524, k.org#199541)
fi-kbl-guc: PASS -> INCOMPLETE (fdo#106693)
fi-bxt-dsi: PASS -> INCOMPLETE (fdo#103927)
fi-skl-gvtdvm: PASS -> INCOMPLETE (fdo#105600, fdo#104108)
fi-bxt-j4205: PASS -> INCOMPLETE (fdo#103927)
fi-skl-6700hq: PASS -> INCOMPLETE (fdo#104108)
fi-skl-6700k2: PASS -> INCOMPLETE (fdo#105524, k.org#199541, fdo#104108)
fi-skl-6600u: PASS -> INCOMPLETE (fdo#104108)
==== Possible fixes ====
igt@debugfs_test@read_all_entries:
fi-snb-2520m: INCOMPLETE (fdo#103713) -> PASS {name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
fdo#105524 https://bugs.freedesktop.org/show_bug.cgi?id=105524
fdo#105600 https://bugs.freedesktop.org/show_bug.cgi?id=105600
fdo#106693 https://bugs.freedesktop.org/show_bug.cgi?id=106693
fdo#107187 https://bugs.freedesktop.org/show_bug.cgi?id=107187
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
k.org#199541 https://bugzilla.kernel.org/show_bug.cgi?id=199541
== Participating hosts (46 -> 42) ==
Missing (4): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u
== Build changes ==
* Linux: CI_DRM_4488 -> Patchwork_9653
CI_DRM_4488: a3a527faf129e7901fdff5309a7e6df8abd72d13 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4557: 140a67c13aad2595ee6c72e41d14d35a793158b5 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9653: 6f9dc880515091b1ec4fde213dd2e70d8f7e1322 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
6f9dc8805150 drm/i915/execlists: Drop clear_gtiir() on GPU reset 49f92d22de3e drm/i915: Do not short-circuit tasklets during reset 6ca6d5421808 drm/i915/selftests: Include the start of each subtest in the GEM trace 05763b37e58a drm/i915/execlists: Check reset_in_progress()
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9653/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx