Skip to contentSkip to conversation

fs: f2fs: Insert a space

PATCH In review youngjun yoo 2 participants 2 messages Jul 14, 2018 – Jul 15, 2018 F2FS file system

lore
Share & tools
lore

youngjun yoo

author
#0 lore raw

PATCH 1/1 fs: f2fs: Insert a space

clean up checkpatch error:
ERROR:
space required before the open parenthesis (
space required around that :

Signed-off-by willow72 <[email protected]>
---
 fs/f2fs/node.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
fs/f2fs/node.c +2 -2
index 51388cf..14ed45c 100644
@@ -1225,7 +1225,7 @@ static struct page *__get_node_page(struct f2fs_sb_info *sbi, pgoff_t nid,
 		goto out_err;
 	}
 page_hit:
-	if(unlikely(nid != nid_of_node(page))) {
+	if (unlikely (nid != nid_of_node (page))) {
 		f2fs_msg(sbi->sb, KERN_WARNING, "inconsistent node block, "
 			"nid:%lu, node_footer[nid:%u,ino:%u,ofs:%u,cpver:%llu,blkaddr:%u]",
 			nid, nid_of_node(page), ino_of_node(page),

@@ -1589,7 +1589,7 @@ int f2fs_fsync_node_pages(struct f2fs_sb_info *sbi, struct inode *inode,
 out:
 	if (last_idx != ULONG_MAX)
 		f2fs_submit_merged_write_cond(sbi, NULL, ino, last_idx, NODE);
-	return ret ? -EIO: 0;
+	return ret ? -EIO : 0;
 }
 
 int f2fs_sync_node_pages(struct f2fs_sb_info *sbi,
Signature · 6 lines
2.7.4


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
maintainer
#1 lore raw

Hi Youngjun,

Look like you sent several patches to fix checkpatch error.
Could you please write single patch saying "f2fs: clean up coding style", which contains all the changes that you want to fix?

Thanks,

Quoted 42 lines · youngjun yoo

clean up checkpatch error:
ERROR:
space required before the open parenthesis (
space required around that :

Signed-off-by willow72 <[email protected]>
---
 fs/f2fs/node.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
fs/f2fs/node.c +2 -2
index 51388cf..14ed45c 100644
@@ -1225,7 +1225,7 @@ static struct page *__get_node_page(struct f2fs_sb_info *sbi, pgoff_t nid,
 		goto out_err;
 	}
 page_hit:
-	if(unlikely(nid != nid_of_node(page))) {
+	if (unlikely (nid != nid_of_node (page))) {
 		f2fs_msg(sbi->sb, KERN_WARNING, "inconsistent node block, "
 			"nid:%lu, node_footer[nid:%u,ino:%u,ofs:%u,cpver:%llu,blkaddr:%u]",
 			nid, nid_of_node(page), ino_of_node(page),

@@ -1589,7 +1589,7 @@ int f2fs_fsync_node_pages(struct f2fs_sb_info *sbi, struct inode *inode,
 out:
 	if (last_idx != ULONG_MAX)
 		f2fs_submit_merged_write_cond(sbi, NULL, ino, last_idx, NODE);
-	return ret ? -EIO: 0;
+	return ret ? -EIO : 0;
 }
 
 int f2fs_sync_node_pages(struct f2fs_sb_info *sbi,
Signature · 10 lines
2.7.4


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot