Fix typo in IPv6 address in comment.
PATCH 1/1 Fix typo in IPv6 address in comment.
Comment talks about ff02::1::ff00:8, correct address is ff02::1:ff00:8.
--- src/txpath.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
src/txpath.c +1 -1
@@ -108,7 +108,7 @@ HandleIPv6NeighborDiscovery(// - it's either a multicast MAC, or the userland destination MAC // but since the TAP driver is point-to-point, all packets are "for us" -// IPv6 target address must be ff02::1::ff00:8 (multicast for +// IPv6 target address must be ff02::1:ff00:8 (multicast for // initial NS) or fe80::1 (unicast for recurrent NUD) if ( memcmp( ipv6->daddr, IPV6_NS_TARGET_MCAST, sizeof(IPV6ADDR) ) != 0 &&
Signature · 1 line
2.18.0
PATCH v2 1/1 Fix typo in IPv6 address in comment.
Comment talks about ff02::1::ff00:8, correct address is ff02::1:ff00:8, and about fe80::1 where fe80::8 is the proper magic number.
--- src/txpath.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
src/txpath.c +2 -2
@@ -108,8 +108,8 @@ HandleIPv6NeighborDiscovery(// - it's either a multicast MAC, or the userland destination MAC // but since the TAP driver is point-to-point, all packets are "for us" -// IPv6 target address must be ff02::1::ff00:8 (multicast for -// initial NS) or fe80::1 (unicast for recurrent NUD) +// IPv6 target address must be ff02::1:ff00:8 (multicast for +// initial NS) or fe80::8 (unicast for recurrent NUD) if (memcmp ( ipv6->daddr,IPV6_NS_TARGET_MCAST ,sizeof (IPV6ADDR ) ) !=0 && memcmp( ipv6->daddr, IPV6_NS_TARGET_UNICAST,
Signature · 1 line
2.18.0
Hi Gert,
Quoted 2 lines · Gert Doering
Comment talks about ff02::1::ff00:8, correct address is ff02::1:ff00:8, and about fe80::1 where fe80::8 is the proper magic number.
thanks for this patch!
What the CVE for this ? when do we get an emergency patch? will this change be backported to OpenVPN 2.3?
;)
JJK
Quoted 20 lines
Signed-off-by Gert Doering <[email protected]...>--- src/txpath.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)src/txpath.c +2
-2@@ -108,8 +108,8 @@ HandleIPv6NeighborDiscovery(// - it's either a multicast MAC, or the userland destination MAC // but since the TAP driver is point-to-point, all packets are "for us" -// IPv6 target address must be ff02::1::ff00:8 (multicast for -// initial NS) or fe80::1 (unicast for recurrent NUD) +// IPv6 target address must be ff02::1:ff00:8 (multicast for +// initial NS) or fe80::8 (unicast for recurrent NUD) if (memcmp ( ipv6->daddr,IPV6_NS_TARGET_MCAST ,sizeof (IPV6ADDR ) ) !=0 && memcmp( ipv6->daddr, IPV6_NS_TARGET_UNICAST,
Hi,
should have tagged this better - quite obviously this is for tap-windows6, and since nobody complained about fixing bugs in comments, I've applied lazy ACK rules, merge & and pushed it.
commit c8bea201a8975e247cfc910131f6539f5add9277
(tap-windows6 has a slightly weird process with "development taking place in github PRs or not at all", so the whole openvpn-devel bit is actually the exception here)
gert
Quoted 35 lines · Gert Doering
Comment talks about ff02::1::ff00:8, correct address is ff02::1:ff00:8, and about fe80::1 where fe80::8 is the proper magic number.
Signed-off-by Gert Doering <[email protected]...>--- src/txpath.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)src/txpath.c +2
-2@@ -108,8 +108,8 @@ HandleIPv6NeighborDiscovery(// - it's either a multicast MAC, or the userland destination MAC // but since the TAP driver is point-to-point, all packets are "for us" -// IPv6 target address must be ff02::1::ff00:8 (multicast for -// initial NS) or fe80::1 (unicast for recurrent NUD) +// IPv6 target address must be ff02::1:ff00:8 (multicast for +// initial NS) or fe80::8 (unicast for recurrent NUD) if (memcmp ( ipv6->daddr,IPV6_NS_TARGET_MCAST ,sizeof (IPV6ADDR ) ) !=0 && memcmp( ipv6->daddr, IPV6_NS_TARGET_UNICAST,Signature · 10 lines
2.18.0 ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Signature · 6 lines
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany [email protected]...