Skip to contentSkip to conversation

drm/i915/selftests: Remove redundant code

PATCH In review Gustavo A. R. Silva 3 participants 4 messages Jul 16, 2018

Subsystems (2)
DRM drivers Intel i915
lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 drm/i915/selftests: Remove redundant code

err is assigned to -EIO, but this value is never actually used and *err* is updated later on.

Remove such reduntant code.

Addresses-Coverity-ID: 1471816 ("Unused value")

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/gpu/drm/i915/selftests/intel_guc.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/i915/selftests/intel_guc.c +0 -1
index 407c98f..c10e75c 100644
@@ -206,7 +206,6 @@ static int igt_guc_clients(void *args)
 
 	if (!available_dbs(guc, guc->execbuf_client->priority)) {
 		pr_err("doorbell not available when it should\n");
-		err = -EIO;
 		goto out_db;
 	}
Signature · 1 line
2.7.4
#1 lore raw

Quoting Gustavo A. R. Silva (2018-07-16 13:39:33)

Quoted 4 lines

err is assigned to -EIO, but this value is never actually used and *err* is updated later on.

Remove such reduntant code.

The mistake is that err is lost, possible masking the test failure. Looks like the unwind needs to be refactored?
-Chris

CI
#2 lore raw

✓ Fi.CI.BAT: success for drm/i915/selftests: Remove redundant code

In reply to Gustavo A. R. Silva
== Series Details ==

== Series Details ==

Series: drm/i915/selftests: Remove redundant code
URL : https://patchwork.freedesktop.org/series/46599/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4493 -> Patchwork_9675 =

== Summary - WARNING ==

Minor unknown changes coming with Patchwork_9675 need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_9675, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/46599/revisions/1/mbox/

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_9675:

=== IGT changes ===

    ==== Warnings ====

    igt@drv_selftest@live_execlists:
      fi-bdw-5557u:       PASS -> SKIP +1

== Known issues ==

Here are the changes found in Patchwork_9675 that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@drv_selftest@live_hangcheck:
      {fi-cfl-8109u}:     PASS -> DMESG-FAIL (fdo#106560)

    
    ==== Possible fixes ====

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-snb-2520m:       INCOMPLETE (fdo#103713) -> PASS

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560

== Participating hosts (44 -> 41) ==

Additional (1): fi-skl-6700hq
Missing (4): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-hsw-4200u

== Build changes ==

* Linux: CI_DRM_4493 -> Patchwork_9675

CI_DRM_4493: c69b4c1274cccaa270c1e4daa68228724c80603a @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4558: d8e97e1710b27a3931a1c53d1dd88c0e709c085b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9675: e5390334ad7571e68a64aef76bd327434de298cb @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

e5390334ad75 drm/i915/selftests: Remove redundant code

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9675/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

CI
#3 lore raw

✗ Fi.CI.IGT: failure for drm/i915/selftests: Remove redundant code

In reply to Gustavo A. R. Silva
== Series Details ==

== Series Details ==

Series: drm/i915/selftests: Remove redundant code
URL : https://patchwork.freedesktop.org/series/46599/
State : failure

== Summary ==

= CI Bug Log - changes from CI_DRM_4493_full -> Patchwork_9675_full =

== Summary - FAILURE ==

Serious unknown changes coming with Patchwork_9675_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_9675_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_9675_full:

=== IGT changes ===

    ==== Possible regressions ====

    igt@gem_exec_schedule@preempt-hang-render:
      shard-glk:          NOTRUN -> DMESG-FAIL

== Known issues ==

Here are the changes found in Patchwork_9675_full that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@drv_missed_irq:
      shard-glk:          NOTRUN -> INCOMPLETE (k.org#198133, fdo#103359)

    igt@drv_selftest@live_hangcheck:
      shard-kbl:          PASS -> DMESG-FAIL (fdo#106560, fdo#106947)

    igt@drv_suspend@shrink:
      shard-snb:          NOTRUN -> INCOMPLETE (fdo#105411, fdo#106886)

    igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
      shard-hsw:          PASS -> FAIL (fdo#102887)

    igt@kms_flip@dpms-vs-vblank-race:
      shard-glk:          PASS -> FAIL (fdo#103060)

    igt@kms_flip@plain-flip-fb-recreate:
      shard-glk:          PASS -> FAIL (fdo#100368)

    igt@kms_setmode@basic:
      shard-apl:          PASS -> FAIL (fdo#99912)

    
    ==== Possible fixes ====

    igt@gem_ctx_isolation@vcs0-s3:
      shard-kbl:          INCOMPLETE (fdo#103665) -> PASS

    igt@kms_cursor_legacy@cursor-vs-flip-toggle:
      shard-hsw:          FAIL (fdo#103355) -> PASS

    igt@kms_flip@2x-dpms-vs-vblank-race:
      shard-hsw:          FAIL (fdo#103060) -> PASS

    igt@kms_flip@dpms-vs-vblank-race:
      shard-kbl:          FAIL (fdo#103060) -> PASS

    igt@kms_flip@dpms-vs-vblank-race-interruptible:
      shard-glk:          FAIL (fdo#103060) -> PASS

    igt@kms_flip@flip-vs-expired-vblank:
      shard-glk:          FAIL (fdo#105363, fdo#102887) -> PASS

fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103355 https://bugs.freedesktop.org/show_bug.cgi?id=103355
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
fdo#106947 https://bugs.freedesktop.org/show_bug.cgi?id=106947
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133

== Participating hosts (5 -> 5) ==

No changes in participating hosts

== Build changes ==

* Linux: CI_DRM_4493 -> Patchwork_9675

CI_DRM_4493: c69b4c1274cccaa270c1e4daa68228724c80603a @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4558: d8e97e1710b27a3931a1c53d1dd88c0e709c085b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9675: e5390334ad7571e68a64aef76bd327434de298cb @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9675/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx