Skip to contentSkip to conversation

glamor: Invalidate cached GEM handle in radeon_set_pixmap_bo

PATCH In review Michel Dänzer 2 participants 2 messages Jul 17, 2018 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 glamor: Invalidate cached GEM handle in radeon_set_pixmap_bo

From: Michel Dänzer <[email protected]>

We continued using the stale cached handle, causing issues e.g. when resizing the screen via RandR.

Reported-by iive on IRC
---
 src/radeon.h | 1 +
 1 file changed, 1 insertion(+)
src/radeon.h +1 -0
index 450c69aa8..1a1edb1ba 100644
@@ -735,6 +735,7 @@ static inline Bool radeon_set_pixmap_bo(PixmapPtr pPix, struct radeon_buffer *bo
 		    return TRUE;
 
 		radeon_buffer_unref(&priv->bo);
+		priv->handle_valid = FALSE;
 	    }
 
 	    drmmode_fb_reference(pRADEONEnt->fd, &priv->fb, NULL);
Signature · 6 lines
2.18.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 20180717094346.14109-1-michel-otUistvHUpPR7s880joybQ@public.gmane.org

Acked-by
#2 lore raw
Quoted 7 lines · Michel Dänzer

From: Michel Dänzer <[email protected]>

We continued using the stale cached handle, causing issues e.g. when resizing the screen via RandR.

Reported-by iive on IRC
Quoted 19 lines
---
 src/radeon.h | 1 +
 1 file changed, 1 insertion(+)
src/radeon.h +1 -1
index 450c69aa8..1a1edb1ba 100644
@@ -735,6 +735,7 @@ static inline Bool radeon_set_pixmap_bo(PixmapPtr pPix, struct radeon_buffer *bo
                    return TRUE;
 
                radeon_buffer_unref(&priv->bo);
+               priv->handle_valid = FALSE;
            }
 
            drmmode_fb_reference(pRADEONEnt->fd, &priv->fb, NULL);
--

2.18.0

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx