Skip to contentSkip to conversation

tls: Fix copy-paste error in tls_device_reencrypt

PATCH Applied Gustavo A. R. Silva 2 participants 2 messages Jul 18, 2018 – Jul 20, 2018

Subsystems (3)
Networking Network drivers Networking TLS
lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 tls: Fix copy-paste error in tls_device_reencrypt

It seems that the proper structure to use in this particular case is *skb_iter* instead of skb.

Addresses-Coverity-ID: 1471906 ("Copy-paste error")

Fixes 4799ac81e52a ("tls: Add rx inline crypto offload")
Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 net/tls/tls_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/tls/tls_device.c +1 -1
index 4995d84..1e968d2 100644
@@ -615,7 +615,7 @@ static int tls_device_reencrypt(struct sock *sk, struct sk_buff *skb)
 			     TLS_CIPHER_AES_GCM_128_TAG_SIZE);
 
 		if (skb_iter->decrypted)
-			skb_store_bits(skb, offset, buf, copy);
+			skb_store_bits(skb_iter, offset, buf, copy);
 
 		offset += copy;
 		buf += copy;
Signature · 1 line
2.7.4
maintainer Applied
#1 lore raw

From: "Gustavo A. R. Silva" <[email protected]>
Date: Wed, 18 Jul 2018 08:27:41 -0500

Quoted 6 lines

It seems that the proper structure to use in this particular case is *skb_iter* instead of skb.

Addresses-Coverity-ID: 1471906 ("Copy-paste error")

Fixes 4799ac81e52a ("tls: Add rx inline crypto offload")
Signed-off-by Gustavo A. R. Silva <[email protected]>

Applied, thank you.