your mail
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 4 lines · On Thu, Jul 19, 2018 at 01:55:12AM +0800, [email protected] wrote:
From
14bd57ea5c5fc385bd36b5a3ea5c805337bbc8dbMon Sep 17 00:00:00 2001
From: Movie Song <[email protected]>
Date: Thu, 19 Jul 2018 02:20:48 +0800
Subject: [PATCH] USB:serial:pl2303:add a new device id for ATEN
Add spaces after the colons (':') in the Subject above, and place a short commit message here before your SoB.
Quoted 1 line
Signed-off-by MovieSong<[email protected]>
Missing spaces in you SoB as well.
Quoted 23 lines
--- drivers/usb/serial/pl2303.c | 2 ++ drivers/usb/serial/pl2303.h | 1 + 2 files changed, 3 insertions(+)drivers/usb/serial/pl2303.c +2
-0@@ -52,6 +52,8 @@ .driver_info = PL2303_QUIRK_ENDPOINT_HACK }, { USB_DEVICE(ATEN_VENDOR_ID, ATEN_PRODUCT_UC485), .driver_info = PL2303_QUIRK_ENDPOINT_HACK }, + { USB_DEVICE(ATEN_VENDOR_ID, ATEN_PRODUCT_UC232B), + .driver_info = PL2303_QUIRK_ENDPOINT_HACK }, { USB_DEVICE(ATEN_VENDOR_ID, ATEN_PRODUCT_ID2) }, { USB_DEVICE(ATEN_VENDOR_ID2, ATEN_PRODUCT_ID) }, { USB_DEVICE(ELCOM_VENDOR_ID, ELCOM_PRODUCT_ID) },drivers/usb/serial/pl2303.h +0
-0
drivers/usb/serial/pl2303.h line 30
Quoted 7 lines
drivers/usb/serial/pl2303.h +1
-0@@ -24,6 +24,7 @@#define ATEN_VENDOR_ID2 0x0547#define ATEN_PRODUCT_ID 0x2008#define ATEN_PRODUCT_UC485 0x2021 +#define ATEN_PRODUCT_UC232B 0x2022#define ATEN_PRODUCT_ID2 0x2118#define IODATA_VENDOR_ID 0x04bb
As I suggested earlier, try sending the patch to yourself first and run scripts/checkpatch.pl on it. The patch is still whitespace corrupted (probably by your mail client) as checkpatch would have let you know:
WARNING: Use a single space after Signed-off-by:
#13:
WARNING: email address 'MovieSong<[email protected]>' might be better as 'MovieSong <[email protected]>' #13:
WARNING: please, no spaces at the start of a line #27: FILE: drivers/usb/serial/pl2303.c:55:
+ { USB_DEVICE(ATEN_VENDOR_ID, ATEN_PRODUCT_UC232B),$
WARNING: please, no spaces at the start of a line
#28: FILE: drivers/usb/serial/pl2303.c:56:
+ .driver_info = PL2303_QUIRK_ENDPOINT_HACK },$
total: 1 errors, 4 warnings, 15 lines checked
git-send-email is convenient for sending patches (e.g. generated with git-format-patch). Perhaps you can set that up.
One more try?
Thanks,
Johan