Skip to contentSkip to conversation

mailbox: xgene-slimpro: Fix potential NULL pointer dereference

PATCH Superseded Gustavo A. R. Silva 1 participant 1 message Jul 19, 2018 Mailbox API

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mailbox: xgene-slimpro: Fix potential NULL pointer dereference

There is a potential execution path in which function platform_get_resource() returns NULL. If this happens, we will end up having a NULL pointer dereference.

Fix this by adding a sanity check in order to avoid a NULL pointer dereference.

This code was detected with the help of Coccinelle.

Fixes f700e84f417b ("mailbox: Add support for APM X-Gene platform mailbox driver")
---
 drivers/mailbox/mailbox-xgene-slimpro.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/mailbox/mailbox-xgene-slimpro.c +3 -0
index a704016..d2c02b7 100644
@@ -195,6 +195,9 @@ static int slimpro_mbox_probe(struct platform_device *pdev)
 	platform_set_drvdata(pdev, ctx);
 
 	regs = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+	if (!regs)
+		return -EINVAL;
+
 	mb_base = devm_ioremap(&pdev->dev, regs->start, resource_size(regs));
 	if (!mb_base)
 		return -ENOMEM;
Signature · 1 line
2.7.4