Skip to contentSkip to conversation

drm/i915: Fix psr sink status report.

PATCH New Rodrigo Vivi 3 participants 10 messages Jul 19, 2018 – Jul 21, 2018

Subsystems (2)
lore
Share & tools
lore

Rodrigo Vivi

author maintainer
#0 lore raw

PATCH 1/1 drm/i915: Fix psr sink status report.

First of all don't try to read dpcd if PSR is not even supported.

But also, if read failed return -EIO instead of reporting via a backchannel.

Fixes 5b7b30864d1d ("drm/i915/psr: Split sink status into a separate debugfs node")
Cc Chris Wilson <[email protected]>
Cc Dhinakaran Pandiyan <[email protected]>
Cc José Roberto de Souza <[email protected]>
---
 drivers/gpu/drm/i915/i915_debugfs.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_debugfs.c +7 -1
index b3aefd623557..401aca53169d 100644
@@ -2594,6 +2594,7 @@ static const struct file_operations i915_guc_log_relay_fops = {
 
 static int i915_psr_sink_status_show(struct seq_file *m, void *data)
 {
+	struct drm_i915_private *dev_priv = node_to_i915(m->private);
 	u8 val;
 	static const char * const sink_status[] = {
 		"inactive",
@@ -2609,6 +2610,11 @@ static int i915_psr_sink_status_show(struct seq_file *m, void *data)
 	struct intel_dp *intel_dp =
 		enc_to_intel_dp(&intel_attached_encoder(connector)->base);
 
+	if (!CAN_PSR(dev_priv)) {
+		seq_puts(m, "PSR Unsupported\n");
+		return -ENODEV;
+	}
+
 	if (connector->status != connector_status_connected)
 		return -ENODEV;
 
@@ -2620,7 +2626,7 @@ static int i915_psr_sink_status_show(struct seq_file *m, void *data)
 			str = sink_status[val];
 		seq_printf(m, "Sink PSR status: 0x%x [%s]\n", val, str);
 	} else {
-		DRM_ERROR("dpcd read (at %u) failed\n", DP_PSR_STATUS);
+		return -EIO;
 	}
 
 	return 0;
Signature · 6 lines
2.17.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✗ Fi.CI.BAT: failure for drm/i915: Fix psr sink status report. (rev2)

== Series Details ==

== Series Details ==

Series: drm/i915: Fix psr sink status report. (rev2)
URL : https://patchwork.freedesktop.org/series/46831/
State : failure

== Summary ==

= CI Bug Log - changes from CI_DRM_4507 -> Patchwork_9711 =

== Summary - FAILURE ==

Serious unknown changes coming with Patchwork_9711 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_9711, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/46831/revisions/2/mbox/

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_9711:

=== IGT changes ===

    ==== Possible regressions ====

    igt@debugfs_test@read_all_entries:
      fi-cfl-s3:          PASS -> DMESG-FAIL
      fi-hsw-peppy:       PASS -> DMESG-FAIL
      fi-skl-6700hq:      PASS -> DMESG-FAIL
      fi-kbl-r:           PASS -> DMESG-FAIL
      fi-skl-6600u:       PASS -> DMESG-FAIL
      fi-kbl-7560u:       PASS -> DMESG-FAIL
      fi-whl-u:           PASS -> DMESG-FAIL

    igt@drv_module_reload@basic-reload:
      fi-kbl-r:           PASS -> INCOMPLETE
      fi-cfl-s3:          PASS -> INCOMPLETE
      fi-skl-6700hq:      PASS -> INCOMPLETE
      fi-whl-u:           PASS -> INCOMPLETE
      fi-hsw-peppy:       PASS -> INCOMPLETE

    igt@drv_selftest@live_workarounds:
      {fi-cfl-8109u}:     NOTRUN -> DMESG-FAIL

    
    ==== Warnings ====

    igt@gem_exec_gttfill@basic:
      fi-pnv-d510:        SKIP -> PASS

== Known issues ==

Here are the changes found in Patchwork_9711 that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@drv_module_reload@basic-reload:
      fi-skl-6600u:       PASS -> INCOMPLETE (fdo#104108)
      fi-kbl-7560u:       PASS -> INCOMPLETE (fdo#103665)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      fi-bxt-dsi:         PASS -> INCOMPLETE (fdo#103927)

    
    ==== Possible fixes ====

    igt@debugfs_test@read_all_entries:
      fi-snb-2520m:       INCOMPLETE (fdo#103713) -> PASS

    igt@drv_selftest@live_hangcheck:
      fi-skl-6700k2:      DMESG-FAIL (fdo#106560, fdo#107174) -> PASS

    igt@gem_exec_suspend@basic-s3:
      {fi-cfl-8109u}:     INCOMPLETE (fdo#107187) -> PASS

    
    ==== Warnings ====

    igt@gem_exec_suspend@basic-s4-devices:
      {fi-kbl-8809g}:     INCOMPLETE (fdo#103665, fdo#107139) -> DMESG-WARN (fdo#107139, fdo#107222)

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
fdo#107139 https://bugs.freedesktop.org/show_bug.cgi?id=107139
fdo#107174 https://bugs.freedesktop.org/show_bug.cgi?id=107174
fdo#107187 https://bugs.freedesktop.org/show_bug.cgi?id=107187
fdo#107222 https://bugs.freedesktop.org/show_bug.cgi?id=107222

== Participating hosts (46 -> 41) ==

Additional (1): fi-bdw-gvtdvm
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-j1900 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600

== Build changes ==

* Linux: CI_DRM_4507 -> Patchwork_9711

CI_DRM_4507: 3bbfaebaf3ba21d866c7823d9e4febf47b4b7b39 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4566: 7270e39a0e6238804827ea7f8db433ad743ed745 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9711: ea5b0912f598ddf8655d595cb6a04b5625f50235 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

ea5b0912f598 drm/i915: Fix psr sink status report.

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9711/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

author maintainer
#2 lore raw

PATCH 1/1 drm/i915: Fix psr sink status report.

In reply to Rodrigo Vivi

First of all don't try to read dpcd if PSR is not even supported.

But also, if read failed return -EIO instead of reporting via a backchannel.

v2: fix dev_priv: At this level m->private is the connector. (CI/DK)
don't convert dpcd read errors to EIO. (DK)

Fixes 5b7b30864d1d ("drm/i915/psr: Split sink status into a separate debugfs node")
Cc Chris Wilson <[email protected]>
Cc Dhinakaran Pandiyan <[email protected]>
Cc José Roberto de Souza <[email protected]>
---
 drivers/gpu/drm/i915/i915_debugfs.c | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/i915_debugfs.c +11 -2
index b3aefd623557..59dc0610ea44 100644
@@ -2606,13 +2606,22 @@ static int i915_psr_sink_status_show(struct seq_file *m, void *data)
 		"sink internal error",
 	};
 	struct drm_connector *connector = m->private;
+	struct drm_i915_private *dev_priv = to_i915(connector->dev);
 	struct intel_dp *intel_dp =
 		enc_to_intel_dp(&intel_attached_encoder(connector)->base);
+	int ret;
+
+	if (!CAN_PSR(dev_priv)) {
+		seq_puts(m, "PSR Unsupported\n");
+		return -ENODEV;
+	}
 
 	if (connector->status != connector_status_connected)
 		return -ENODEV;
 
-	if (drm_dp_dpcd_readb(&intel_dp->aux, DP_PSR_STATUS, &val) == 1) {
+	ret = drm_dp_dpcd_readb(&intel_dp->aux, DP_PSR_STATUS, &val);
+
+	if (ret == 1) {
 		const char *str = "unknown";
 
 		val &= DP_PSR_SINK_STATE_MASK;
@@ -2620,7 +2629,7 @@ static int i915_psr_sink_status_show(struct seq_file *m, void *data)
 			str = sink_status[val];
 		seq_printf(m, "Sink PSR status: 0x%x [%s]\n", val, str);
 	} else {
-		DRM_ERROR("dpcd read (at %u) failed\n", DP_PSR_STATUS);
+		return ret;
 	}
 
 	return 0;
Signature · 6 lines
2.17.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v1 1/1
#3 lore raw
Quoted 52 lines · Rodrigo Vivi

First of all don't try to read dpcd if PSR is not even supported.

But also, if read failed return -EIO instead of reporting via a backchannel.

v2: fix dev_priv: At this level m->private is the connector. (CI/DK) don't convert dpcd read errors to EIO. (DK)

Fixes 5b7b30864d1d ("drm/i915/psr: Split sink status into a separate

debugfs node")

Cc Chris Wilson <[email protected]>
Cc Dhinakaran Pandiyan <[email protected]>
Cc José Roberto de Souza <[email protected]>

---
 drivers/gpu/drm/i915/i915_debugfs.c | 13 +++++++++++--

 1 file changed, 11 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/i915_debugfs.c +1 -0
index b3aefd623557..59dc0610ea44 100644
@@ -2606,13 +2606,22 @@ static int i915_psr_sink_status_show(struct
 seq_file *m, void *data)
  		"sink internal error",
  	};
  	struct drm_connector *connector = m->private;
+	struct drm_i915_private *dev_priv = to_i915(connector->dev);

  struct intel_dp *intel_dp = enc_to_intel_dp(&intel_attached_encoder(connector)-

Quoted 1 line

base);

drivers/gpu/drm/i915/i915_debugfs.c +6 -0
+	int ret;
+
+	if (!CAN_PSR(dev_priv)) {
+		seq_puts(m, "PSR Unsupported\n");
+		return -ENODEV;
+	}


  if (connector->status != connector_status_connected) return -ENODEV;

drivers/gpu/drm/i915/i915_debugfs.c +0 -1
-	if (drm_dp_dpcd_readb(&intel_dp->aux, DP_PSR_STATUS, &val)

== 1) {

drivers/gpu/drm/i915/i915_debugfs.c +1 -0
+	ret = drm_dp_dpcd_readb(&intel_dp->aux, DP_PSR_STATUS,

&val);

drivers/gpu/drm/i915/i915_debugfs.c +2 -0
+
+	if (ret == 1) {

  const char *str = "unknown";

  val &= DP_PSR_SINK_STATE_MASK;

drivers/gpu/drm/i915/i915_debugfs.c static int i915_psr_sink_status_show(struct · line 2633

Quoted 5 lines
drivers/gpu/drm/i915/i915_debugfs.c +0 -0
@@ -2620,7 +2629,7 @@ static int i915_psr_sink_status_show(struct
 seq_file *m, void *data)
  			str = sink_status[val];
  		seq_printf(m, "Sink PSR status: 0x%x [%s]\n", val,
 str);
  	} else {

dpcd_readb() is not expected to return anything other than 1 or a negative error code, so this looks good.

Are you also sending a similar fix for i915_dpcd_show()? That function also prints a DRM_ERROR() for failed aux transactions.

Quoted 6 lines
drivers/gpu/drm/i915/i915_debugfs.c +1 -1
-		DRM_ERROR("dpcd read (at %u) failed\n",
 DP_PSR_STATUS);
+		return ret;

  }

  return 0;

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

author maintainer
#4 lore raw
Quoted 61 lines · Dhinakaran Pandiyan
Quoted 52 lines · Rodrigo Vivi

First of all don't try to read dpcd if PSR is not even supported.

But also, if read failed return -EIO instead of reporting via a backchannel.

v2: fix dev_priv: At this level m->private is the connector. (CI/DK) don't convert dpcd read errors to EIO. (DK)

Fixes 5b7b30864d1d ("drm/i915/psr: Split sink status into a separate

debugfs node")

Cc Chris Wilson <[email protected]>
Cc Dhinakaran Pandiyan <[email protected]>
Cc José Roberto de Souza <[email protected]>

---
 drivers/gpu/drm/i915/i915_debugfs.c | 13 +++++++++++--

 1 file changed, 11 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/i915_debugfs.c +1 -0
index b3aefd623557..59dc0610ea44 100644
@@ -2606,13 +2606,22 @@ static int i915_psr_sink_status_show(struct
 seq_file *m, void *data)
  		"sink internal error",
  	};
  	struct drm_connector *connector = m->private;
+	struct drm_i915_private *dev_priv = to_i915(connector->dev);

  struct intel_dp *intel_dp = enc_to_intel_dp(&intel_attached_encoder(connector)-

Quoted 1 line

base);

drivers/gpu/drm/i915/i915_debugfs.c +6 -0
+	int ret;
+
+	if (!CAN_PSR(dev_priv)) {
+		seq_puts(m, "PSR Unsupported\n");
+		return -ENODEV;
+	}


  if (connector->status != connector_status_connected) return -ENODEV;

drivers/gpu/drm/i915/i915_debugfs.c +0 -1
-	if (drm_dp_dpcd_readb(&intel_dp->aux, DP_PSR_STATUS, &val)

== 1) {

drivers/gpu/drm/i915/i915_debugfs.c +1 -0
+	ret = drm_dp_dpcd_readb(&intel_dp->aux, DP_PSR_STATUS,

&val);

drivers/gpu/drm/i915/i915_debugfs.c +2 -0
+
+	if (ret == 1) {

  const char *str = "unknown";

  val &= DP_PSR_SINK_STATE_MASK;

drivers/gpu/drm/i915/i915_debugfs.c static int i915_psr_sink_status_show(struct · line 2633

Quoted 5 lines
drivers/gpu/drm/i915/i915_debugfs.c +0 -0
@@ -2620,7 +2629,7 @@ static int i915_psr_sink_status_show(struct
 seq_file *m, void *data)
  			str = sink_status[val];
  		seq_printf(m, "Sink PSR status: 0x%x [%s]\n", val,
 str);
  	} else {

dpcd_readb() is not expected to return anything other than 1 or a negative error code, so this looks good.

Quoted 1 line

thanks, pushed.

Quoted 4 lines

Are you also sending a similar fix for i915_dpcd_show()? That function also prints a DRM_ERROR() for failed aux transactions.

well... it is a bit different there because we cannot return in the middle of the loop because we might want to get other regs read. but probably it is a good idea to print the error message along with the reads so you don't have to look to 2 places.

I will put a simple patch and we can wait until Jani is back from vacation since he was the author there.

Quoted 7 lines
Quoted 7 lines
drivers/gpu/drm/i915/i915_debugfs.c +1 -1
-		DRM_ERROR("dpcd read (at %u) failed\n",
 DP_PSR_STATUS);
+		return ret;

  }

  return 0;

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw
Quoted 88 lines · Rodrigo Vivi
Quoted 70 lines · Dhinakaran Pandiyan
Quoted 60 lines · Rodrigo Vivi

First of all don't try to read dpcd if PSR is not even supported.

But also, if read failed return -EIO instead of reporting via a backchannel.

v2: fix dev_priv: At this level m->private is the connector. (CI/DK)
    don't convert dpcd read errors to EIO. (DK)

Fixes 5b7b30864d1d ("drm/i915/psr: Split sink status into a

separate
debugfs node")

Cc Chris Wilson <[email protected]>
Cc Dhinakaran Pandiyan <[email protected]>
Cc José Roberto de Souza <[email protected]>

---
 drivers/gpu/drm/i915/i915_debugfs.c | 13 +++++++++++--

 1 file changed, 11 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/i915_debugfs.c +0 -0
index b3aefd623557..59dc0610ea44 100644
@@ -2606,13 +2606,22 @@ static int

i915_psr_sink_status_show(struct
seq_file *m, void *data)
  "sink internal error",
  };
  struct drm_connector *connector = m->private;

drivers/gpu/drm/i915/i915_debugfs.c +1 -0
+	struct drm_i915_private *dev_priv = to_i915(connector-
Quoted 1 line

dev);

  struct intel_dp *intel_dp = enc_to_intel_dp(&intel_attached_encoder(connecto r)-

Quoted 2 lines

base);

drivers/gpu/drm/i915/i915_debugfs.c +6 -0
+	int ret;
+
+	if (!CAN_PSR(dev_priv)) {
+		seq_puts(m, "PSR Unsupported\n");
+		return -ENODEV;
+	}


  if (connector->status != connector_status_connected) return -ENODEV;

drivers/gpu/drm/i915/i915_debugfs.c +0 -1
-	if (drm_dp_dpcd_readb(&intel_dp->aux, DP_PSR_STATUS,

&val)
== 1) {

drivers/gpu/drm/i915/i915_debugfs.c +1 -0
+	ret = drm_dp_dpcd_readb(&intel_dp->aux, DP_PSR_STATUS,

&val);

drivers/gpu/drm/i915/i915_debugfs.c +2 -0
+
+	if (ret == 1) {

  const char *str = "unknown";

  val &= DP_PSR_SINK_STATE_MASK;

drivers/gpu/drm/i915/i915_debugfs.c static int i915_psr_sink_status_show(struct · line 2634

Quoted 6 lines
drivers/gpu/drm/i915/i915_debugfs.c +0 -0
@@ -2620,7 +2629,7 @@ static int i915_psr_sink_status_show(struct
 seq_file *m, void *data)
  			str = sink_status[val];
  		seq_printf(m, "Sink PSR status: 0x%x [%s]\n",
 val,
 str);
  	} else {

dpcd_readb() is not expected to return anything other than 1 or a negative error code, so this looks good.

Quoted 1 line

thanks, pushed.

Quoted 6 lines

Are you also sending a similar fix for i915_dpcd_show()? That function
also prints a DRM_ERROR() for failed aux transactions.

well... it is a bit different there because we cannot return in the middle
of the loop because we might want to get other regs read. but probably it
is a good idea to print the error message along with the reads so you don't
have to look to 2 places.

Quoted 2 lines

I will put a simple patch and we can wait until Jani is back from vacation since he was the author there.

Okay.

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
drivers/gpu/drm/i915/i915_debugfs.c +0 -1
-		DRM_ERROR("dpcd read (at %u) failed\n",

DP_PSR_STATUS);

drivers/gpu/drm/i915/i915_debugfs.c +1 -0
+		return ret;

  }

  return 0;

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#6 lore raw

✗ Fi.CI.BAT: failure for drm/i915: Fix psr sink status report. (rev3)

In reply to Rodrigo Vivi
== Series Details ==

== Series Details ==

Series: drm/i915: Fix psr sink status report. (rev3)
URL : https://patchwork.freedesktop.org/series/46831/
State : failure

== Summary ==

= CI Bug Log - changes from CI_DRM_4518 -> Patchwork_9726 =

== Summary - FAILURE ==

Serious unknown changes coming with Patchwork_9726 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_9726, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/46831/revisions/3/mbox/

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_9726:

=== IGT changes ===

    ==== Possible regressions ====

    igt@drv_selftest@live_requests:
      fi-bsw-n3050:       PASS -> INCOMPLETE

== Known issues ==

Here are the changes found in Patchwork_9726 that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@drv_selftest@live_coherency:
      fi-gdg-551:         PASS -> DMESG-FAIL (fdo#107164)

    igt@drv_selftest@live_hangcheck:
      fi-kbl-7567u:       PASS -> DMESG-FAIL (fdo#106947, fdo#106560)

    igt@drv_selftest@live_workarounds:
      fi-bsw-n3050:       PASS -> DMESG-FAIL (fdo#107292)

    
    ==== Possible fixes ====

    igt@drv_selftest@live_workarounds:
      {fi-cfl-8109u}:     DMESG-FAIL (fdo#107292) -> PASS

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
fdo#106947 https://bugs.freedesktop.org/show_bug.cgi?id=106947
fdo#107164 https://bugs.freedesktop.org/show_bug.cgi?id=107164
fdo#107292 https://bugs.freedesktop.org/show_bug.cgi?id=107292

== Participating hosts (47 -> 41) ==

Missing (6): fi-ilk-m540 fi-bxt-dsi fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600

== Build changes ==

* Linux: CI_DRM_4518 -> Patchwork_9726

CI_DRM_4518: 85bdcb875339b30f7beecbc7cba6bc2041cdd28b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4569: bf70728a951cd3c08dd9bbc9310e16aaa252164f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9726: 1593ca0bae97db5945ea3b294655b4d4e540a3ca @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

1593ca0bae97 drm/i915: Fix psr sink status report.

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9726/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#7 lore raw

✓ Fi.CI.IGT: success for drm/i915: Fix psr sink status report. (rev3)

In reply to Rodrigo Vivi
== Series Details ==

== Series Details ==

Series: drm/i915: Fix psr sink status report. (rev3)
URL : https://patchwork.freedesktop.org/series/46831/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4518_full -> Patchwork_9726_full =

== Summary - WARNING ==

Minor unknown changes coming with Patchwork_9726_full need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_9726_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_9726_full:

=== IGT changes ===

    ==== Warnings ====

    igt@gem_exec_schedule@deep-blt:
      shard-kbl:          SKIP -> PASS +1

    igt@gem_exec_schedule@deep-bsd1:
      shard-kbl:          PASS -> SKIP

== Known issues ==

Here are the changes found in Patchwork_9726_full that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@drv_suspend@shrink:
      shard-glk:          PASS -> INCOMPLETE (fdo#103359, k.org#198133, fdo#106886)

    igt@kms_available_modes_crc@available_mode_test_crc:
      shard-kbl:          NOTRUN -> FAIL (fdo#106641)

    igt@kms_flip@2x-plain-flip-ts-check:
      shard-glk:          PASS -> FAIL (fdo#100368)

    igt@kms_flip@dpms-vs-vblank-race-interruptible:
      shard-apl:          PASS -> FAIL (fdo#103060)

    
    ==== Possible fixes ====

    igt@drv_suspend@shrink:
      shard-kbl:          FAIL (fdo#106886) -> PASS

    igt@gem_ppgtt@blt-vs-render-ctx0:
      shard-kbl:          INCOMPLETE (fdo#103665, fdo#106023) -> PASS

    igt@kms_setmode@basic:
      shard-apl:          FAIL (fdo#99912) -> PASS

fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133

== Participating hosts (5 -> 5) ==

No changes in participating hosts

== Build changes ==

* Linux: CI_DRM_4518 -> Patchwork_9726

CI_DRM_4518: 85bdcb875339b30f7beecbc7cba6bc2041cdd28b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4569: bf70728a951cd3c08dd9bbc9310e16aaa252164f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9726: 1593ca0bae97db5945ea3b294655b4d4e540a3ca @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9726/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#8 lore raw

✓ Fi.CI.BAT: success for drm/i915: Fix psr sink status report. (rev3)

In reply to Rodrigo Vivi
== Series Details ==

== Series Details ==

Series: drm/i915: Fix psr sink status report. (rev3)
URL : https://patchwork.freedesktop.org/series/46831/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4519 -> Patchwork_9735 =

== Summary - SUCCESS ==

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/46831/revisions/3/mbox/

== Known issues ==

Here are the changes found in Patchwork_9735 that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@drv_selftest@live_workarounds:
      {fi-cfl-8109u}:     PASS -> DMESG-FAIL (fdo#107292)

    
    ==== Possible fixes ====

    igt@drm_mm@insert_range:
      fi-bsw-n3050:       INCOMPLETE -> PASS

    igt@drv_selftest@live_hangcheck:
      fi-skl-guc:         DMESG-FAIL (fdo#107174) -> PASS
      fi-bxt-j4205:       DMESG-FAIL (fdo#106560) -> PASS

    igt@prime_vgem@basic-fence-flip:
      fi-ilk-650:         FAIL (fdo#104008) -> PASS

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
fdo#107174 https://bugs.freedesktop.org/show_bug.cgi?id=107174
fdo#107292 https://bugs.freedesktop.org/show_bug.cgi?id=107292

== Participating hosts (44 -> 41) ==

Additional (2): fi-hsw-4770 fi-byt-n2820
Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u

== Build changes ==

* Linux: CI_DRM_4519 -> Patchwork_9735

CI_DRM_4519: f14c0ec8fe9acce6fd1be84766f854ab8874eb33 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4569: bf70728a951cd3c08dd9bbc9310e16aaa252164f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9735: 15623bcbe147a8278c1ee24a2109347988434426 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

15623bcbe147 drm/i915: Fix psr sink status report.

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9735/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#9 lore raw

✓ Fi.CI.IGT: success for drm/i915: Fix psr sink status report. (rev3)

In reply to Rodrigo Vivi
== Series Details ==

== Series Details ==

Series: drm/i915: Fix psr sink status report. (rev3)
URL : https://patchwork.freedesktop.org/series/46831/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4519_full -> Patchwork_9735_full =

== Summary - WARNING ==

Minor unknown changes coming with Patchwork_9735_full need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_9735_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_9735_full:

=== IGT changes ===

    ==== Warnings ====

    igt@gem_exec_schedule@deep-bsd1:
      shard-kbl:          SKIP -> PASS

    igt@gem_exec_schedule@deep-render:
      shard-kbl:          PASS -> SKIP

    igt@kms_cursor_crc@cursor-256x256-sliding:
      shard-snb:          SKIP -> PASS +2

    igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite:
      shard-snb:          PASS -> SKIP +1

== Known issues ==

Here are the changes found in Patchwork_9735_full that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@gem_ppgtt@blt-vs-render-ctx0:
      shard-kbl:          PASS -> INCOMPLETE (fdo#103665, fdo#106023)

    igt@kms_flip@2x-flip-vs-blocking-wf-vblank:
      shard-glk:          PASS -> FAIL (fdo#100368)

    igt@kms_setmode@basic:
      shard-snb:          PASS -> FAIL (fdo#99912)

    
    ==== Possible fixes ====

    igt@kms_cursor_legacy@cursor-vs-flip-varying-size:
      shard-hsw:          FAIL (fdo#103355) -> PASS

    igt@kms_flip@2x-plain-flip-ts-check:
      shard-glk:          FAIL (fdo#100368) -> PASS

    igt@kms_setmode@basic:
      shard-apl:          FAIL (fdo#99912) -> PASS

    igt@kms_universal_plane@cursor-fb-leak-pipe-c:
      shard-apl:          FAIL (fdo#107241) -> PASS

fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103355 https://bugs.freedesktop.org/show_bug.cgi?id=103355
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
fdo#107241 https://bugs.freedesktop.org/show_bug.cgi?id=107241
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912

== Participating hosts (5 -> 5) ==

No changes in participating hosts

== Build changes ==

* Linux: CI_DRM_4519 -> Patchwork_9735

CI_DRM_4519: f14c0ec8fe9acce6fd1be84766f854ab8874eb33 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4569: bf70728a951cd3c08dd9bbc9310e16aaa252164f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9735: 15623bcbe147a8278c1ee24a2109347988434426 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9735/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx