exec: don't force_sigsegv processes with a pending fatal signal
Subsystems (2)
PATCH 1/1 exec: don't force_sigsegv processes with a pending fatal signal
We were seeing unexplained segfaults in coreutils processes and other basic utilities that we tracked down to binfmt_elf failing to load segments for ld.so. Digging further, the actual problem seems to occur when a process gets sigkilled while it is still being loaded by the kernel. In our case when _do_page_fault goes for a retry it will return early as it first checks for fatal_signal_pending(), so load_elf_interp also returns with error and as a result search_binary_handler will force_sigsegv() which is pretty confusing as nothing actually failed here.
Fixes 19d860a140be ("handle suicide on late failure exits in execve() in search_binary_handler()")
Reference: https://lkml.org/lkml/2013/2/14/5
Signed-off-by Ivan Delalande <[email protected]>
--- fs/exec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
fs/exec.c +2 -1
@@ -1657,7 +1657,8 @@ int search_binary_handler(struct linux_binprm *bprm)if (retval <0 && !bprm->mm) {/* we got to flush_old_exec() and failed after it */ read_unlock (&binfmt_lock); -force_sigsegv (SIGSEGV , current); +if (!fatal_signal_pending (current)) +force_sigsegv (SIGSEGV , current);return retval; }if (retval != -ENOEXEC || !bprm->file) {
Signature · 1 line
2.18.0