Skip to contentSkip to conversation

PCI: mediatek: Fix unchecked return value

PATCH Applied Gustavo A. R. Silva 3 participants 3 messages Jul 20, 2018 – Sep 18, 2018

Subsystems (4)
PCI Arm MediaTek PCI native host bridge and endpoint drivers PCIe driver for MediaTek
lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 PCI: mediatek: Fix unchecked return value

Check return value of devm_pci_remap_iospace.

Notice that, currently, all instances of devm_pci_remap_iospace are being checked.

Addresses-Coverity-ID: 1471965 ("Unchecked return value")

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/pci/controller/pcie-mediatek.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/pci/controller/pcie-mediatek.c +3 -1
index 861dda6..1477939 100644
@@ -1109,7 +1109,9 @@ static int mtk_pcie_request_resources(struct mtk_pcie *pcie)
 	if (err < 0)
 		return err;
 
-	devm_pci_remap_iospace(dev, &pcie->pio, pcie->io.start);
+	err = devm_pci_remap_iospace(dev, &pcie->pio, pcie->io.start);
+	if (err)
+		return err;
 
 	return 0;
 }
Signature · 1 line
2.7.4
Acked-by on v1 1/1
#1 lore raw
Quoted 11 lines · Gustavo A. R. Silva

Check return value of devm_pci_remap_iospace.

Notice that, currently, all instances of devm_pci_remap_iospace are being checked.

Addresses-Coverity-ID: 1471965 ("Unchecked return value")

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/pci/controller/pcie-mediatek.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Hi, Gustavo, thanks for your help.

Acked-by Honghui Zhang <[email protected]>
Quoted 15 lines
drivers/pci/controller/pcie-mediatek.c +3 -1
index 861dda6..1477939 100644
@@ -1109,7 +1109,9 @@ static int mtk_pcie_request_resources(struct mtk_pcie *pcie)
 	if (err < 0)
 		return err;
 
-	devm_pci_remap_iospace(dev, &pcie->pio, pcie->io.start);
+	err = devm_pci_remap_iospace(dev, &pcie->pio, pcie->io.start);
+	if (err)
+		return err;
 
 	return 0;
 }
Applied
#2 lore raw
In reply to Gustavo A. R. Silva
Quoted 10 lines · Gustavo A. R. Silva

Check return value of devm_pci_remap_iospace.

Notice that, currently, all instances of devm_pci_remap_iospace are being checked.

Addresses-Coverity-ID: 1471965 ("Unchecked return value")

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/pci/controller/pcie-mediatek.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Applied to pci/mediatek for v4.20, thanks.

Lorenzo

Quoted 18 lines
drivers/pci/controller/pcie-mediatek.c +3 -1
index 861dda6..1477939 100644
@@ -1109,7 +1109,9 @@ static int mtk_pcie_request_resources(struct mtk_pcie *pcie)
 	if (err < 0)
 		return err;
 
-	devm_pci_remap_iospace(dev, &pcie->pio, pcie->io.start);
+	err = devm_pci_remap_iospace(dev, &pcie->pio, pcie->io.start);
+	if (err)
+		return err;
 
 	return 0;
 }
Signature · 1 line
2.7.4