Skip to contentSkip to conversation

hwmon: rpi: add module alias to raspberrypi-hwmon

PATCH In review Peter Robinson 5 participants 5 messages Jul 20, 2018 – Aug 2, 2018

Subsystems (2)
Hardware monitoring Broadcom BCM2711/BCM2835 Arm architecture
lore
Share & tools
lore

Peter Robinson

author
#0 lore raw

PATCH 1/1 hwmon: rpi: add module alias to raspberrypi-hwmon

The raspberrypi-hwmon driver doesn't automatically load, although it does work when loaded, by adding the alias it auto loads as expected when built as a module. Tested on RPi2/RPi3 on 32 bit kernel and RPi3B+ on aarch64 with Fedora 28 and a patched 4.18 RC kernel.

Fixes q3c493c885cf ("hwmon: Add support for RPi voltage sensor")
Signed-off-by Peter Robinson <[email protected]>
CC Stefan Wahren <[email protected]>
CC Eric Anholt <[email protected]>
---
 drivers/hwmon/raspberrypi-hwmon.c | 1 +
 1 file changed, 1 insertion(+)
drivers/hwmon/raspberrypi-hwmon.c +1 -0
index fb4e4a6bb1f63..be5ba46908953 100644
@@ -164,3 +164,4 @@ module_platform_driver(rpi_hwmon_driver);
 MODULE_AUTHOR("Stefan Wahren <[email protected]>");
 MODULE_DESCRIPTION("Raspberry Pi voltage sensor driver");
 MODULE_LICENSE("GPL v2");
+MODULE_ALIAS("platform:raspberrypi-hwmon");
Signature · 1 line
2.17.1
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Peter Robinson

The raspberrypi-hwmon driver doesn't automatically load, although it does work when loaded, by adding the alias it auto loads as expected when built as a module. Tested on RPi2/RPi3 on 32 bit kernel and RPi3B+ on aarch64 with Fedora 28 and a patched 4.18 RC kernel.

Fixes q3c493c885cf ("hwmon: Add support for RPi voltage sensor")
Signed-off-by Peter Robinson <[email protected]>
CC Stefan Wahren <[email protected]>
CC Eric Anholt <[email protected]>
Acked-by Guenter Roeck <[email protected]>

Florian, I think the driver is in your tree - can you take this patch ?

Thanks,
Guenter

Quoted 14 lines
---
  drivers/hwmon/raspberrypi-hwmon.c | 1 +
  1 file changed, 1 insertion(+)
drivers/hwmon/raspberrypi-hwmon.c +1 -0
index fb4e4a6bb1f63..be5ba46908953 100644
@@ -164,3 +164,4 @@ module_platform_driver(rpi_hwmon_driver);
  MODULE_AUTHOR("Stefan Wahren <[email protected]>");
  MODULE_DESCRIPTION("Raspberry Pi voltage sensor driver");
  MODULE_LICENSE("GPL v2");
+MODULE_ALIAS("platform:raspberrypi-hwmon");
#2 lore raw
Quoted 6 lines · Guenter Roeck
Quoted 5 lines · Peter Robinson

The raspberrypi-hwmon driver doesn't automatically load, although it does work when loaded, by adding the alias it auto loads as expected when built as a module. Tested on RPi2/RPi3 on 32 bit kernel and RPi3B+ on aarch64 with Fedora 28 and a patched 4.18 RC kernel.

Quoted 8 lines
Quoted 4 lines
Fixes q3c493c885cf ("hwmon: Add support for RPi voltage sensor")
Signed-off-by Peter Robinson <[email protected]>
CC Stefan Wahren <[email protected]>
CC Eric Anholt <[email protected]>
Acked-by Guenter Roeck <[email protected]>

Florian, I think the driver is in your tree - can you take this patch ?

Florian's been on vacation for a bit, but hopefully when he gets back (next week, iirc?) he can just apply it with my r-b as well :)

Thanks, Peter!

#3 lore raw
In reply to Guenter Roeck
Quoted 8 lines · Guenter Roeck
Quoted 7 lines · Peter Robinson

The raspberrypi-hwmon driver doesn't automatically load, although it does work
when loaded, by adding the alias it auto loads as expected when built as a
module. Tested on RPi2/RPi3 on 32 bit kernel and RPi3B+ on aarch64 with Fedora 28 and a patched 4.18 RC kernel.

Quoted 8 lines
Quoted 4 lines
Fixes q3c493c885cf ("hwmon: Add support for RPi voltage sensor")
Signed-off-by Peter Robinson <[email protected]>
CC Stefan Wahren <[email protected]>
CC Eric Anholt <[email protected]>
Acked-by Guenter Roeck <[email protected]>

Florian, I think the driver is in your tree - can you take this patch ?

Yes, now applied to drivers/next, thanks for your patience, I was on holiday for quite a while.

Signature · 1 line
Florian
Tested-by on v1 1/1
#4 lore raw
In reply to Peter Robinson
Quoted 9 lines

Peter Robinson <[email protected]> hat am 21. Juli 2018 um 01:02 geschrieben:

The raspberrypi-hwmon driver doesn't automatically load, although it does work when loaded, by adding the alias it auto loads as expected when built as a module. Tested on RPi2/RPi3 on 32 bit kernel and RPi3B+ on aarch64 with Fedora 28 and a patched 4.18 RC kernel.

Quoted 5 lines
Fixes q3c493c885cf ("hwmon: Add support for RPi voltage sensor")
Signed-off-by Peter Robinson <[email protected]>
CC Stefan Wahren <[email protected]>
CC Eric Anholt <[email protected]>

---

Tested-by Stefan Wahren <[email protected]>

Thanks