Removal of usused definitions - Style
cover Removal of usused definitions - Style
Clean up of the file drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h
A number of the definitions in the file are unused so were removed from the file.
John Whitmore (15):
staging:rtl8192u: Remove typedef of u32 to QOS_MODE - Style staging:rtl8192u: Remove unused enumerated type ACK_POLICY - Style staging:rtl8192u: Remove unused QOS definitions - Style staging:rtl8192u: Removed unused structure BSS_QOS - Style staging:rtl8192u: Remove unused structure STA_QOS - Style staging:rtl8192u: Remove unused structure QOS_CTRL_FIELD - Style staging:rtl8192u: Remove unused union QOS_INFO_FIELD - Style staging:rtl8192u: Remove the unused AC_CODING definitions - Style staging:rtl8192u: Remove unused enumerated type QOS_ELE_SUBTYPE -
Style
staging:rtl8192u: Remove unused structure QOS_TSTREAM - Style staging:rtl8192u: Remove unused structure WMM_TSPEC - Style staging:rtl8192u: Remove unused enumerated type ACM_METHOD - Style staging:rtl8192u: Remove unused structure ACM - Style staging:rtl8192u: Remove unused AC_UAPSD definitions - Style staging:rtl8192u: Remove unused definition of sQoSCtlLng - Style
.../staging/rtl8192u/ieee80211/rtl819x_Qos.h | 336 ------------------ 1 file changed, 336 deletions(-)
Signature · 1 line
2.18.0
PATCH 1/15 staging:rtl8192u: Remove typedef of u32 to QOS_MODE - Style
The typedef of QOS_MODE as a u32 is contrary to coding standard and fails the checkpatch tests for defining new types in code. Definitions of type QOS_MODE have simply been replaced with a u32 type.
This is a coding style change which should not impact runtime execution.
--- drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h +3 -4
@@ -16,7 +16,6 @@// QOS_HCCA = 4, //}QOS_MODE,*PQOS_MODE; // -typedef u32 QOS_MODE , *PQOS_MODE ;#define QOS_DISABLE 0#define QOS_WMM 1#define QOS_WMMSA 2
@@ -454,8 +453,8 @@ typedef struct _STA_QOS {u8 *WMMIE ;// Part 1. Self QoS Mode. -QOS_MODE QosCapability;//QoS Capability, 2006-06-14 Isaiah -QOS_MODE CurrentQosMode; +u32 QosCapability;// QOS_MODE QoS Capability, 2006-06-14 Isaiah +u32 CurrentQosMode;// QOS_MODE // For WMM Power Save Mode : // ACs are trigger/delivery enabled or legacy power save enabled. 2006-06-13 Isaiah
@@ -502,7 +501,7 @@ typedef struct _STA_QOS {// Ref: BssDscr in 8185 code. [def. in BssDscr.h] // typedef struct _BSS_QOS { - QOS_MODE bdQoSMode; + u32 bdQoSMode; // QOS_MODE u8 bdWMMIEBuf[MAX_WMMELE_LENGTH]; u8 *bdWMMIE;
Signature · 1 line
2.18.0
PATCH 2/15 staging:rtl8192u: Remove unused enumerated type ACK_POLICY - Style
In reply to John WhitmoreThe enumerated type ACK_POLICY is not used in code so it has been removed from the source code. This is a coding style change and should have no impact on runtime code execution.
--- drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h | 9 --------- 1 file changed, 9 deletions(-)
drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h +0 -9
@@ -26,15 +26,6 @@#define AC_PARAM_SIZE 4#define WMM_PARAM_ELE_BODY_LEN 18 -// -// QoS ACK Policy Field Values -// Ref: WMM spec 2.1.6: QoS Control Field, p.10. -// -typedef enum _ACK_POLICY { - eAckPlc0_ACK =0x00 , - eAckPlc1_NoACK =0x01 , -}ACK_POLICY , *PACK_POLICY ; -#define WMM_PARAM_ELEMENT_SIZE (8+(4*AC_PARAM_SIZE))//
Signature · 1 line
2.18.0
PATCH 3/15 staging:rtl8192u: Remove unused QOS definitions - Style
In reply to John WhitmoreRemove the unused QOS related types.
Since definitions are not used simply remove from code. This change is a coding style change and should not impact runtime execution.
--- .../staging/rtl8192u/ieee80211/rtl819x_Qos.h | 22 ------------------- 1 file changed, 22 deletions(-)
drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h +0 -22
@@ -4,25 +4,6 @@#define MAX_WMMELE_LENGTH 64 -// -// QoS mode. -// enum 0, 1, 2, 4: since we can use the OR(|) operation. -// -// QOS_MODE is redefined for enum can't be ++, | under C++ compiler, 2006.05.17, by rcnjko. -//typedef enum _QOS_MODE{ -// QOS_DISABLE = 0, -// QOS_WMM = 1, -// QOS_EDCA = 2, -// QOS_HCCA = 4, -//}QOS_MODE,*PQOS_MODE; -// -#define QOS_DISABLE 0 -#define QOS_WMM 1 -#define QOS_WMMSA 2 -#define QOS_EDCA 4 -#define QOS_HCCA 8 -#define QOS_WMM_UAPSD 16 //WMM Power Save, 2006-06-14 Isaiah -#define AC_PARAM_SIZE 4#define WMM_PARAM_ELE_BODY_LEN 18
@@ -506,14 +487,11 @@ typedef struct _BSS_QOS {AC_PARAM AcParameter[4 ]; }BSS_QOS , *PBSS_QOS ; -// // Ref: sQoSCtlLng and QoSCtl definition in 8185 QoS code. //#define QoSCtl (( (Adapter->bRegQoS) && (Adapter->dot11QoS.QoSMode &(QOS_EDCA|QOS_HCCA)) ) ?sQoSCtlLng:0) // #define sQoSCtlLng 2 -#define QOS_CTRL_LEN (_QosMode) ((_QosMode > QOS_DISABLE) ? sQoSCtlLng : 0) -//Added by joseph //UP Mapping to AC, using in MgntQuery_SequenceNumber() and maybe for DSCP
Signature · 1 line
2.18.0
PATCH 4/15 staging:rtl8192u: Removed unused structure BSS_QOS - Style
In reply to John WhitmoreThe structure BSS_QOS is not used in code so has simply been removed. The change is a coding style change and should not impact runtime execution.
--- .../staging/rtl8192u/ieee80211/rtl819x_Qos.h | 19 ------------------- 1 file changed, 19 deletions(-)
drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h +0 -19
@@ -468,25 +468,6 @@ typedef struct _STA_QOS { }STA_QOS , *PSTA_QOS ; -// -// BSS QOS data. -// Ref: BssDscr in 8185 code. [def. in BssDscr.h] -// -typedef struct _BSS_QOS { -u32 bdQoSMode;// QOS_MODE - -u8 bdWMMIEBuf[MAX_WMMELE_LENGTH ]; -u8 *bdWMMIE; - -QOS_ELE_SUBTYPE EleSubType; - -u8 *pWMMInfoEle; -u8 *pWMMParamEle; - -QOS_INFO_FIELD QosInfoField; -AC_PARAM AcParameter[4 ]; -}BSS_QOS , *PBSS_QOS ; -// // Ref: sQoSCtlLng and QoSCtl definition in 8185 QoS code. //#define QoSCtl (( (Adapter->bRegQoS) && (Adapter->dot11QoS.QoSMode &(QOS_EDCA|QOS_HCCA)) ) ?sQoSCtlLng:0)
Signature · 1 line
2.18.0
PATCH 5/15 staging:rtl8192u: Remove unused structure STA_QOS - Style
In reply to John WhitmoreRemove structure STA_QOS as it is unused in code. This change is a coding style change so should not impact runtime code execution.
--- .../staging/rtl8192u/ieee80211/rtl819x_Qos.h | 53 ------------------- 1 file changed, 53 deletions(-)
drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h +0 -53
@@ -415,59 +415,6 @@ typedef struct _OCTET_STRING {u16 Length; }OCTET_STRING , *POCTET_STRING ; -// -// STA QoS data. -// Ref: DOT11_QOS in 8185 code. [def. in QoS_mp.h] -// -typedef struct _STA_QOS { -//DECLARE_RT_OBJECT(STA_QOS); -u8 WMMIEBuf[MAX_WMMELE_LENGTH ]; -u8 *WMMIE; - -// Part 1. Self QoS Mode. -u32 QosCapability;// QOS_MODE QoS Capability, 2006-06-14 Isaiah -u32 CurrentQosMode;// QOS_MODE - -// For WMM Power Save Mode : -// ACs are trigger/delivery enabled or legacy power save enabled. 2006-06-13 Isaiah -AC_UAPSD b4ac_Uapsd;//VoUapsd(bit0), ViUapsd(bit1), BkUapsd(bit2), BeUapsd(bit3), -AC_UAPSD Curr4acUapsd; -u8 bInServicePeriod; -u8 MaxSPLength; -int NumBcnBeforeTrigger; - -// Part 2. EDCA Parameter (perAC) -u8 *pWMMInfoEle; -u8 WMMParamEle[WMM_PARAM_ELEMENT_SIZE ]; -u8 WMMPELength; - -// <Bruce_Note> -//2 ToDo: remove the Qos Info Field and replace it by the above WMM Info element. -// By Bruce, 2008-01-30. -// Part 2. EDCA Parameter (perAC) -QOS_INFO_FIELD QosInfoField_STA;// Maintained by STA -QOS_INFO_FIELD QosInfoField_AP;// Retrieved from AP - -AC_PARAM CurAcParameters[4 ]; - -// Part 3. ACM -ACM acm[4 ]; -ACM_METHOD AcmMethod; - -// Part 4. Per TID (Part 5: TCLASS will be described by TStream) -QOS_TSTREAM TStream[16 ]; -WMM_TSPEC TSpec; - -u32 QBssWirelessMode; - -// No Ack Setting -u8 bNoAck; - -// Enable/Disable Rx immediate BA capability. -u8 bEnableRxImmBA; - -}STA_QOS , *PSTA_QOS ; -// // Ref: sQoSCtlLng and QoSCtl definition in 8185 QoS code. //#define QoSCtl (( (Adapter->bRegQoS) && (Adapter->dot11QoS.QoSMode &(QOS_EDCA|QOS_HCCA)) ) ?sQoSCtlLng:0)
Signature · 1 line
2.18.0
PATCH 6/15 staging:rtl8192u: Remove unused structure QOS_CTRL_FIELD - Style
In reply to John WhitmoreThe structure QOS_CTRL_FIELD is unused in code so has simply been removed from source. This is a coding style change and should have no impact on runtime code execution.
--- .../staging/rtl8192u/ieee80211/rtl819x_Qos.h | 50 ------------------- 1 file changed, 50 deletions(-)
drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h +0 -50
@@ -9,56 +9,6 @@#define WMM_PARAM_ELEMENT_SIZE (8+(4*AC_PARAM_SIZE)) -// -// QoS Control Field -// Ref: -// 1. WMM spec 2.1.6: QoS Control Field, p.9. -// 2. 802.11e/D13.0 7.1.3.5, p.26. -// -typedef union _QOS_CTRL_FIELD { -u8 charData[2 ]; -u16 shortData; - -// WMM spec -struct { -u8 UP:3 ; -u8 usRsvd1:1 ; -u8 EOSP:1 ; -u8 AckPolicy:2 ; -u8 usRsvd2:1 ; -u8 ucRsvdByte; - } WMM; - -// 802.11e: QoS data type frame sent by non-AP QSTAs. -struct { -u8 TID:4 ; -u8 bIsQsize:1 ;// 0: BIT[8:15] is TXOP Duration Requested, 1: BIT[8:15] is Queue Size. -u8 AckPolicy:2 ; -u8 usRsvd:1 ; -u8 TxopOrQsize;// (BIT4=0)TXOP Duration Requested or (BIT4=1)Queue Size. - } BySta; - -// 802.11e: QoS data, QoS Null, and QoS Data+CF-Ack frames sent by HC. -struct { -u8 TID:4 ; -u8 EOSP:1 ; -u8 AckPolicy:2 ; -u8 usRsvd:1 ; -u8 PSBufState;// QAP PS Buffer State. - } ByHc_Data; - -// 802.11e: QoS (+) CF-Poll frames sent by HC. -struct { -u8 TID:4 ; -u8 EOSP:1 ; -u8 AckPolicy:2 ; -u8 usRsvd:1 ; -u8 TxopLimit;// TXOP Limit. - } ByHc_CFP; - -}QOS_CTRL_FIELD , *PQOS_CTRL_FIELD ; - -// // QoS Info Field // Ref:
Signature · 1 line
2.18.0
PATCH 7/15 staging:rtl8192u: Remove unused union QOS_INFO_FIELD - Style
In reply to John WhitmoreThe union QOS_INFO_FIELD is unused in code so has been removed from source. This change is a coding style change so should have no impact on runtime code execution.
--- .../staging/rtl8192u/ieee80211/rtl819x_Qos.h | 86 ------------------- 1 file changed, 86 deletions(-)
drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h +0 -86
@@ -9,92 +9,6 @@#define WMM_PARAM_ELEMENT_SIZE (8+(4*AC_PARAM_SIZE)) -// -// QoS Info Field -// Ref: -// 1. WMM spec 2.2.1: WME Information Element, p.11. -// 2. 8185 QoS code: QOS_INFO [def. in QoS_mp.h] -// -typedef union _QOS_INFO_FIELD { -u8 charData; - -struct { -u8 ucParameterSetCount:4 ; -u8 ucReserved:4 ; - } WMM; - -struct { -//Ref WMM_Specification_1-1.pdf, 2006-06-13 Isaiah -u8 ucAC_VO_UAPSD:1 ; -u8 ucAC_VI_UAPSD:1 ; -u8 ucAC_BE_UAPSD:1 ; -u8 ucAC_BK_UAPSD:1 ; -u8 ucReserved1:1 ; -u8 ucMaxSPLen:2 ; -u8 ucReserved2:1 ; - - } ByWmmPsSta; - -struct { -//Ref WMM_Specification_1-1.pdf, 2006-06-13 Isaiah -u8 ucParameterSetCount:4 ; -u8 ucReserved:3 ; -u8 ucApUapsd:1 ; - } ByWmmPsAp; - -struct { -u8 ucAC3_UAPSD:1 ; -u8 ucAC2_UAPSD:1 ; -u8 ucAC1_UAPSD:1 ; -u8 ucAC0_UAPSD:1 ; -u8 ucQAck:1 ; -u8 ucMaxSPLen:2 ; -u8 ucMoreDataAck:1 ; - } By11eSta; - -struct { -u8 ucParameterSetCount:4 ; -u8 ucQAck:1 ; -u8 ucQueueReq:1 ; -u8 ucTXOPReq:1 ; -u8 ucReserved:1 ; - } By11eAp; - -struct { -u8 ucReserved1:4 ; -u8 ucQAck:1 ; -u8 ucReserved2:2 ; -u8 ucMoreDataAck:1 ; - } ByWmmsaSta; - -struct { -u8 ucReserved1:4 ; -u8 ucQAck:1 ; -u8 ucQueueReq:1 ; -u8 ucTXOPReq:1 ; -u8 ucReserved2:1 ; - } ByWmmsaAp; - -struct { -u8 ucAC3_UAPSD:1 ; -u8 ucAC2_UAPSD:1 ; -u8 ucAC1_UAPSD:1 ; -u8 ucAC0_UAPSD:1 ; -u8 ucQAck:1 ; -u8 ucMaxSPLen:2 ; -u8 ucMoreDataAck:1 ; - } ByAllSta; - -struct { -u8 ucParameterSetCount:4 ; -u8 ucQAck:1 ; -u8 ucQueueReq:1 ; -u8 ucTXOPReq:1 ; -u8 ucApUapsd:1 ; - } ByAllAp; - -}QOS_INFO_FIELD , *PQOS_INFO_FIELD ; -// // ACI to AC coding. // Ref: WMM spec 2.2.2: WME Parameter Element, p.13.
Signature · 1 line
2.18.0
PATCH 8/15 staging:rtl8192u: Remove the unused AC_CODING definitions - Style
In reply to John WhitmoreThe AC_CODING definitions are unused in code, so have simply been removed from source. This is a coding style change and should not impact runtime code execution.
--- .../staging/rtl8192u/ieee80211/rtl819x_Qos.h | 20 ------------------- 1 file changed, 20 deletions(-)
drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h +0 -20
@@ -9,26 +9,6 @@#define WMM_PARAM_ELEMENT_SIZE (8+(4*AC_PARAM_SIZE)) -// -// ACI to AC coding. -// Ref: WMM spec 2.2.2: WME Parameter Element, p.13. -// -// AC_CODING is redefined for enum can't be ++, | under C++ compiler, 2006.05.17, by rcnjko. -//typedef enum _AC_CODING{ -// AC0_BE = 0, // ACI: 0x00 // Best Effort -// AC1_BK = 1, // ACI: 0x01 // Background -// AC2_VI = 2, // ACI: 0x10 // Video -// AC3_VO = 3, // ACI: 0x11 // Voice -// AC_MAX = 4, // Max: define total number; Should not to be used as a real enum. -//}AC_CODING,*PAC_CODING; -// -typedef u32 AC_CODING ; -#define AC0_BE 0 // ACI: 0x00 // Best Effort -#define AC1_BK 1 // ACI: 0x01 // Background -#define AC2_VI 2 // ACI: 0x10 // Video -#define AC3_VO 3 // ACI: 0x11 // Voice -#define AC_MAX 4 // Max: define total number; Should not to be used as a real enum. -// // ACI/AIFSN Field. // Ref: WMM spec 2.2.2: WME Parameter Element, p.12.
Signature · 1 line
2.18.0
PATCH 9/15 staging:rtl8192u: Remove unused enumerated type QOS_ELE_SUBTYPE - Style
In reply to John WhitmoreThe enumerated type QOS_ELE_SUBTYPE is unused in code so has been removed from code. This is a coding style change which should have not impact on runtime code execution.
--- drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h | 11 ----------- 1 file changed, 11 deletions(-)
drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h +0 -11
@@ -51,17 +51,6 @@ typedef union _AC_PARAM { } f;// Field }AC_PARAM , *PAC_PARAM ; - - -// -// QoS element subtype -// -typedef enum _QOS_ELE_SUBTYPE { -QOSELE_TYPE_INFO =0x00 ,// 0x00: Information element -QOSELE_TYPE_PARAM =0x01 ,// 0x01: parameter element -}QOS_ELE_SUBTYPE , *PQOS_ELE_SUBTYPE ; - -// // Direction Field Values. // Ref: WMM spec 2.2.11: WME TSPEC Element, p.18.
Signature · 1 line
2.18.0
PATCH 10/15 staging:rtl8192u: Remove unused structure QOS_TSTREAM - Style
In reply to John WhitmoreThe structure QOS_TSTREAM is unused in code so has simply been removed. This change is a coding style change and should have no impact on runtime code execution.
--- drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h | 11 ----------- 1 file changed, 11 deletions(-)
drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h +0 -11
@@ -214,17 +214,6 @@ typedef union _QOS_TCLAS { }TYPE2_8021Q ; }QOS_TCLAS , *PQOS_TCLAS ; -//typedef struct _WMM_TSTREAM{ -// -//- TSPEC -//- AC (which to mapping) -//} WMM_TSTREAM, *PWMM_TSTREAM; -typedef struct _QOS_TSTREAM { -u8 AC; -WMM_TSPEC TSpec; -QOS_TCLAS TClass; -}QOS_TSTREAM , *PQOS_TSTREAM ; -//typedef struct _U_APSD{ //- TriggerEnable [4] //- MaxSPLength
Signature · 1 line
2.18.0
PATCH 11/15 staging:rtl8192u: Remove unused structure WMM_TSPEC - Style
In reply to John WhitmoreRemove the structure WMM_TSPEC as it is unused. This change is a coding style change and should not impact runtime code execution.
--- drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h | 15 --------------- 1 file changed, 15 deletions(-)
drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h +0 -15
@@ -112,21 +112,6 @@ typedef union _TSPEC_BODY { } f;// Field }TSPEC_BODY , *PTSPEC_BODY ; - -// -// WMM TSPEC Element. -// Ref: WMM spec 2.2.11: WME TSPEC Element, p.16. -// -typedef struct _WMM_TSPEC { -u8 ID; -u8 Length; -u8 OUI[3 ]; -u8 OUI_Type; -u8 OUI_SubType; -u8 Version; -TSPEC_BODY Body; -}WMM_TSPEC , *PWMM_TSPEC ; -// // ACM implementation method. // Annie, 2005-12-13.
Signature · 1 line
2.18.0
PATCH 12/15 staging:rtl8192u: Remove unused enumerated type ACM_METHOD - Style
In reply to John WhitmoreRemove the enumerated type ACM_METHOD as it is unused in code. This is a coding style change and should not impact runtime code execution.
--- drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h | 11 ----------- 1 file changed, 11 deletions(-)
drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h +0 -11
@@ -112,17 +112,6 @@ typedef union _TSPEC_BODY { } f;// Field }TSPEC_BODY , *PTSPEC_BODY ; -// -// ACM implementation method. -// Annie, 2005-12-13. -// -typedef enum _ACM_METHOD { - eAcmWay0_SwAndHw =0 ,// By SW and HW. - eAcmWay1_HW =1 ,// By HW. - eAcmWay2_SW =2 ,// By SW. -}ACM_METHOD , *PACM_METHOD ; - - typedef struct _ACM { // u8 RegEnableACM; u64 UsedTime;
Signature · 1 line
2.18.0
PATCH 13/15 staging:rtl8192u: Remove unused structure ACM - Style
In reply to John WhitmoreRemove the structure ACM as it is unused in code. This change is a coding style change and should have no impact on runtime code execution.
--- drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h | 7 ------- 1 file changed, 7 deletions(-)
drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h +0 -7
@@ -112,13 +112,6 @@ typedef union _TSPEC_BODY { } f;// Field }TSPEC_BODY , *PTSPEC_BODY ; -typedef struct _ACM { -// u8 RegEnableACM; -u64 UsedTime; -u64 MediumTime; -u8 HwAcmCtl;// TRUE: UsedTime exceed => Do NOT USE this AC. It wll be written to ACM_CONTROL(0xBF BIT 0/1/2 in 8185B). -}ACM , *PACM ; -typedef u8 AC_UAPSD , *PAC_UAPSD ;#define GET_VO_UAPSD (_apsd) ((_apsd) & BIT(0))
Signature · 1 line
2.18.0
PATCH 14/15 staging:rtl8192u: Remove unused AC_UAPSD definitions - Style
In reply to John WhitmoreRemove the definitions associated with AC_UAPSD. These definitions are not used in code so have simply been removed. This is a coding style change and should have no impact on runtime execution.
--- drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h | 15 --------------- 1 file changed, 15 deletions(-)
drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h +0 -15
@@ -112,21 +112,6 @@ typedef union _TSPEC_BODY { } f;// Field }TSPEC_BODY , *PTSPEC_BODY ; -typedef u8 AC_UAPSD , *PAC_UAPSD ; - -#define GET_VO_UAPSD (_apsd) ((_apsd) & BIT(0)) -#define SET_VO_UAPSD (_apsd) ((_apsd) |= BIT(0)) - -#define GET_VI_UAPSD (_apsd) ((_apsd) & BIT(1)) -#define SET_VI_UAPSD (_apsd) ((_apsd) |= BIT(1)) - -#define GET_BK_UAPSD (_apsd) ((_apsd) & BIT(2)) -#define SET_BK_UAPSD (_apsd) ((_apsd) |= BIT(2)) - -#define GET_BE_UAPSD (_apsd) ((_apsd) & BIT(3)) -#define SET_BE_UAPSD (_apsd) ((_apsd) |= BIT(3)) - -//typedef struct _TCLASS{ // TODO //} TCLASS, *PTCLASS;
Signature · 1 line
2.18.0
PATCH 15/15 staging:rtl8192u: Remove unused definition of sQoSCtlLng - Style
In reply to John WhitmoreRemove sQoSCtlLng. The constant sQoSCtlLng is never used in code so has been removed. This is a coding style change so should have no impact on runtime code execution.
--- drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h | 6 ------ 1 file changed, 6 deletions(-)
drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h +0 -6
@@ -189,12 +189,6 @@ typedef struct _OCTET_STRING {u16 Length; }OCTET_STRING , *POCTET_STRING ; -// -// Ref: sQoSCtlLng and QoSCtl definition in 8185 QoS code. -//#define QoSCtl (( (Adapter->bRegQoS) && (Adapter->dot11QoS.QoSMode &(QOS_EDCA|QOS_HCCA)) ) ?sQoSCtlLng:0) -// -#define sQoSCtlLng 2 -//Added by joseph //UP Mapping to AC, using in MgntQuery_SequenceNumber() and maybe for DSCP //#define UP2AC(up) ((up<3)?((up==0)?1:0):(up>>1))
Signature · 1 line
2.18.0