Skip to contentSkip to conversation

eventfs: include linux/errno.h in header

PATCH New Arnd Bergmann 1 participant 1 message Jul 24, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 eventfs: include linux/errno.h in header

The new gasket staging driver ran into a randconfig build failure when CONFIG_EVENTFD is disabled:

In file included from drivers/staging/gasket/gasket_interrupt.h:11,
from drivers/staging/gasket/gasket_interrupt.c:4:
include/linux/eventfd.h: In function 'eventfd_ctx_fdget':
include/linux/eventfd.h:51:9: error: implicit declaration of function 'ERR_PTR' [-Werror=implicit-function-declaration]

I can't see anything wrong with including eventfd.h before err.h, so the easiest fix is to make it possible to do this by including the file where it is needed.

Fixes 9a69f5087ccc ("drivers/staging: Gasket driver framework + Apex driver")
---
 include/linux/eventfd.h | 1 +
 1 file changed, 1 insertion(+)
include/linux/eventfd.h +1 -0
index 7094718b653b..ffcc7724ca21 100644
@@ -11,6 +11,7 @@
 
 #include <linux/fcntl.h>
 #include <linux/wait.h>
+#include <linux/err.h>
 
 /*
  * CAREFUL: Check include/uapi/asm-generic/fcntl.h when defining
Signature · 1 line
2.18.0